arm, omap3: Add support for TechNexion modules
PATCH 4/4 arm, omap3: Add support for TechNexion modules
Add support for TechNexion TDM3730 SoM
--- board/technexion/tdm3730/Makefile | 49 ++++ board/technexion/tdm3730/tdm3730.c | 173 ++++++++++++++++ board/technexion/tdm3730/tdm3730.h | 383 +++++++++++++++++++++++++++++++++++++ boards.cfg | 1 include/configs/tdm3730.h | 360 ++++++++++++++++++++++++++++++++++ 5 files changed, 966 insertions(+)
board/technexion/tdm3730/Makefile new file +49 -0
@@ -0,0 +1,49 @@ +# +# (C) Copyright 2000, 2001, 2002 +# Wolfgang Denk, DENX Software Engineering, wd at denx.de. +# +# See file CREDITS for list of people who contributed to this +# project. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 59 Temple Place, Suite 330, Boston, +# MA 02111-1307 USA +# + +include $(TOPDIR)/config.mk + +LIB = $(obj)lib$(BOARD).o + +COBJS := tdm3730.o + +SRCS := $(COBJS:.o=.c) +OBJS := $(addprefix $(obj),$(COBJS)) + +$(LIB): $(obj).depend $(OBJS) + $(call cmd_link_o_target, $(OBJS)) + +clean: + rm -f $(OBJS) + +distclean: clean + rm -f $(LIB) core *.bak $(obj).depend + +######################################################################### + +# defines $(obj).depend target +include $(SRCTREE)/rules.mk + +sinclude $(obj).depend + +#########################################################################
board/technexion/tdm3730/tdm3730.c new file +173 -0
173 lines not on this page · raw message
board/technexion/tdm3730/tdm3730.h new file +383 -0
383 lines not on this page · raw message
boards.cfg +1 -0
@@ -190,6 +190,7 @@ omap3_zoom2 arm armv7 zoom2 logicpd omap3_mvblx arm armv7 mvblx matrix_vision omap3 tam3517 arm armv7 tam3517 technexion omap3 tao3530 arm armv7 tao3530 technexion omap3 +tdm3730 arm armv7 tdm3730 technexion omap3 omap3_beagle arm armv7 beagle ti omap3 omap3_evm arm armv7 evm ti omap3 omap3_evm_quick_mmc arm armv7 evm ti omap3
include/configs/tdm3730.h new file +360 -0
360 lines not on this page · raw message
--
1.7.6
PATCH 4/4 arm, omap3: Add support for TechNexion modules
Dear Tapani Utriainen,
Quoted 2 lines · In message <20111121165205.4624b13b@myhost> you wrote:
Add support for TechNexion TDM3730 SoM
Please use a better Subject: and add a bit more of information to the commit message itself.
Quoted 9 lines
Signed-off-by Tapani Utriainen <[email protected]>CC Sandeep Paulraj <[email protected]>--- board/technexion/tdm3730/Makefile | 49 ++++ board/technexion/tdm3730/tdm3730.c | 173 ++++++++++++++++ board/technexion/tdm3730/tdm3730.h | 383 +++++++++++++++++++++++++++++++++++++ boards.cfg | 1 include/configs/tdm3730.h | 360 ++++++++++++++++++++++++++++++++++ 5 files changed, 966 insertions(+)
Same comments as before, entry to MAINTAINERS missing, etc, etc,
board/technexion/tdm3730/tdm3730.c line 5
Quoted 8 lines
board/technexion/tdm3730/tdm3730.c new file +5
-0@@ -0,0 +1,173 @@ +/* +* TechNexion, <www.technexion.com> +* +* Maintainer : +* Tapani Utriainen <[email protected]>
This belongs into the MAINTAINERS file.
...
board/technexion/tdm3730/tdm3730.c line 6
Quoted 1 line
board/technexion/tdm3730/tdm3730.c new file +1
-0+#define CONFIG_EXTRA_ENV_SETTINGS \
It appears the environment settings on these boards are pretty much similar (which certainly makes sense). Please consider factoring out these common parts into a separate header file instead of repeating them all over.
board/technexion/tdm3730/tdm3730.c line 8
Quoted 2 lines
board/technexion/tdm3730/tdm3730.c new file +2
-0+#define CONFIG_SYS_INIT_RAM_ADDR 0x4020f800 +#define CONFIG_SYS_INIT_RAM_SIZE 0x800
Has this been tested?
Best regards,
Wolfgang Denk
Signature · 4 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Time is an illusion perpetrated by the manufacturers of space.