linux-next: build warning after merge of the wireless-next tree

Hi John,

After merging the wireless-next tree, today's linux-next build (x86_64_allmodconfig) produced this warning:

drivers/net/wireless/iwlegacy/debug.c:1395:1: warning: data definition has no type or storage class [enabled by default] drivers/net/wireless/iwlegacy/debug.c:1395:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int] drivers/net/wireless/iwlegacy/debug.c:1395:1: warning: parameter names (without types) in function declaration [enabled by default] drivers/net/wireless/iwlegacy/debug.c:1410:1: warning: data definition has no type or storage class [enabled by default] drivers/net/wireless/iwlegacy/debug.c:1410:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int] drivers/net/wireless/iwlegacy/debug.c:1410:1: warning: parameter names (without types) in function declaration [enabled by default]

This indicates that this file needs to include export.h.

Cheers,
Stephen Rothwell                    [email protected]
http://www.canb.auug.org.au/~sfr/

I think adding export.h to debug.c should be part of current wireless-next manual merge (debug.c include old iwl-debugfs.c, which was modified with export.h). If not, I'm posting patch with fix in the following email.

Thanks
Stanislaw

Fix:

drivers/net/wireless/iwlegacy/debug.c:1395:1: warning: data definition has no type or storage class [enabled by default] drivers/net/wireless/iwlegacy/debug.c:1395:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int] drivers/net/wireless/iwlegacy/debug.c:1395:1: warning: parameter names (without types) in function declaration [enabled by default] drivers/net/wireless/iwlegacy/debug.c:1410:1: warning: data definition has no type or storage class [enabled by default] drivers/net/wireless/iwlegacy/debug.c:1410:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int] drivers/net/wireless/iwlegacy/debug.c:1410:1: warning: parameter names (without types) in function declaration [enabled by default]

---
This is linux-next patch only, in wireless-next we do not have include/linux/export.h file.

 drivers/net/wireless/iwlegacy/debug.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

index 928bdbb..b1b8926 100644
@@ -26,6 +26,7 @@
  * Intel Corporation, 5200 N.E. Elam Young Parkway, Hillsboro, OR 97124-6497
  *****************************************************************************/
 #include <linux/ieee80211.h>
+#include <linux/export.h>
 #include <net/mac80211.h>
 
 #include "common.h"

1.7.1

Hi Stanislaw,

I will queue this up for as a merge fix in linux-next for tomorrow. Alternatively, John, you could merge v3.2-rc1 or rc2 into wireless-next and apply this as a merge fixup.

Cheers,
Stephen Rothwell                    [email protected]
http://www.canb.auug.org.au/~sfr/