Skip to contentSkip to conversation

PCI / Hotplug: Fix the ordering of operations in pcied_cleanup()

PATCH In review Rafael J. Wysocki 2 participants 2 messages Nov 22, 2011 – Nov 23, 2011 PCI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 PCI / Hotplug: Fix the ordering of operations in pcied_cleanup()

From: Rafael J. Wysocki <[email protected]>

Make pcied_cleanup() unregister the port service before destroying workqueues that are flushed during the port service unregistration.

---
 drivers/pci/hotplug/pciehp_core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/hotplug/pciehp_core.c +1 -1
Index: linux/drivers/pci/hotplug/pciehp_core.c
===================================================================
@@ -366,9 +366,9 @@ static int __init pcied_init(void)
 static void __exit pcied_cleanup(void)
 {
 	dbg("unload_pciehpd()\n");
+	pcie_port_service_unregister(&hpdriver_portdrv);
 	destroy_workqueue(pciehp_ordered_wq);
 	destroy_workqueue(pciehp_wq);
-	pcie_port_service_unregister(&hpdriver_portdrv);
 	info(DRIVER_DESC " version: " DRIVER_VERSION " unloaded\n");
 }
 
#1 lore raw

I've sent the patch to fix the problem a few weeks ago, and it is in Jesse's -next tree.

Regards,
Kenji Kaneshige

Quoted 32 lines · Rafael J. Wysocki

From: Rafael J. Wysocki<[email protected]>

Make pcied_cleanup() unregister the port service before destroying workqueues that are flushed during the port service unregistration.

---
  drivers/pci/hotplug/pciehp_core.c |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux/drivers/pci/hotplug/pciehp_core.c
===================================================================

drivers/pci/hotplug/pciehp_core.c +1 -2
@@ -366,9 +366,9 @@ static int __init pcied_init(void)
  static void __exit pcied_cleanup(void)
  {
  	dbg("unload_pciehpd()\n");
+	pcie_port_service_unregister(&hpdriver_portdrv);
  	destroy_workqueue(pciehp_ordered_wq);
  	destroy_workqueue(pciehp_wq);
-	pcie_port_service_unregister(&hpdriver_portdrv);
  	info(DRIVER_DESC " version: " DRIVER_VERSION " unloaded\n");
  }
 
--

To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html