Adding USB device 13d3:3375 (a bluetooth module embedded in the Asus UX31) as an Atheros AR3012 device.
PATCH 1/1 Adding USB device 13d3:3375 (a bluetooth module embedded in the Asus UX31) as an Atheros AR3012 device.
From: Eran <[email protected]>
The bluetooth module in the Asus UX31/UX21 is based on Atheros AR3012 and requires a firmware to be uploaded before it's usable.
--- drivers/bluetooth/ath3k.c | 2 ++ drivers/bluetooth/btusb.c | 1 + 2 files changed, 3 insertions(+), 0 deletions(-)
drivers/bluetooth/ath3k.c +2 -0
@@ -70,6 +70,7 @@ static struct usb_device_id ath3k_table[] = {/* Atheros AR3012 with sflash firmware*/ { USB_DEVICE(0x0CF3, 0x3004) }, + { USB_DEVICE(0x13d3, 0x3375) },/* Atheros AR5BBU12 with sflash firmware */ { USB_DEVICE(0x0489, 0xE02C) },
@@ -86,6 +87,7 @@ static struct usb_device_id ath3k_blist_tbl[] = {/* Atheros AR3012 with sflash firmware*/ { USB_DEVICE(0x0cf3, 0x3004), .driver_info = BTUSB_ATH3012 }, + { USB_DEVICE(0x13d3, 0x3375), .driver_info = BTUSB_ATH3012 }, { }/* Terminating entry */ };
drivers/bluetooth/btusb.c +1 -0
@@ -122,6 +122,7 @@ static struct usb_device_id blacklist_table[] = {/* Atheros 3012 with sflash firmware */ { USB_DEVICE(0x0cf3, 0x3004), .driver_info = BTUSB_ATH3012 }, + { USB_DEVICE(0x13d3, 0x3375), .driver_info = BTUSB_ATH3012 }, /* Atheros AR5BBU12 with sflash firmware */ { USB_DEVICE(0x0489, 0xe02c), .driver_info = BTUSB_IGNORE },
Signature · 1 line
1.7.2.5
Hi Eran,
Just a few cosmetic comments, and a disclaimer: I don't have any idea why it seems that every new Atheros device needs another entry in those tables.
Apart from those minor points it looks good.
Quoted 1 line · eran
From: Eran <[email protected]>
Keep the subject line shorter, under 60 or so characters, i.e. remove the part between parentheses. And prefix your subject with "Bluetooth:".
Quoted 2 lines
The bluetooth module in the Asus UX31/UX21 is based on Atheros AR3012 and requires a firmware to be uploaded before it's usable.
Please break the comment at 70 or so characters.
Quoted 46 lines
Signed-off-by Eran <[email protected]>--- drivers/bluetooth/ath3k.c | 2 ++ drivers/bluetooth/btusb.c | 1 + 2 files changed, 3 insertions(+), 0 deletions(-)drivers/bluetooth/ath3k.c +2
-0@@ -70,6 +70,7 @@ static struct usb_device_id ath3k_table[] = {/* Atheros AR3012 with sflash firmware*/ { USB_DEVICE(0x0CF3, 0x3004) }, + { USB_DEVICE(0x13d3, 0x3375) },/* Atheros AR5BBU12 with sflash firmware */ { USB_DEVICE(0x0489, 0xE02C) },@@ -86,6 +87,7 @@ static struct usb_device_id ath3k_blist_tbl[] = {/* Atheros AR3012 with sflash firmware*/ { USB_DEVICE(0x0cf3, 0x3004), .driver_info = BTUSB_ATH3012 }, + { USB_DEVICE(0x13d3, 0x3375), .driver_info = BTUSB_ATH3012 }, { }/* Terminating entry */ };drivers/bluetooth/btusb.c +1
-0@@ -122,6 +122,7 @@ static struct usb_device_id blacklist_table[] = {/* Atheros 3012 with sflash firmware */ { USB_DEVICE(0x0cf3, 0x3004), .driver_info = BTUSB_ATH3012 }, + { USB_DEVICE(0x13d3, 0x3375), .driver_info = BTUSB_ATH3012 }, /* Atheros AR5BBU12 with sflash firmware */ { USB_DEVICE(0x0489, 0xe02c), .driver_info = BTUSB_IGNORE },Signature · 6 lines
1.7.2.5 -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Cheers,
Signature · 1 line
Vinicius
PATCH 1/1 Bluetooth: Adding USB device 13d3:3375 as an Atheros AR3012.
From: Eran <[email protected]>
The bluetooth module in the Asus UX31/UX21 is based on Atheros AR3012 and requires a firmware to be uploaded before it's usable.
--- drivers/bluetooth/ath3k.c | 2 ++ drivers/bluetooth/btusb.c | 1 + 2 files changed, 3 insertions(+), 0 deletions(-)
drivers/bluetooth/ath3k.c +2 -0
@@ -70,6 +70,7 @@ static struct usb_device_id ath3k_table[] = {/* Atheros AR3012 with sflash firmware*/ { USB_DEVICE(0x0CF3, 0x3004) }, + { USB_DEVICE(0x13d3, 0x3375) },/* Atheros AR5BBU12 with sflash firmware */ { USB_DEVICE(0x0489, 0xE02C) },
@@ -86,6 +87,7 @@ static struct usb_device_id ath3k_blist_tbl[] = {/* Atheros AR3012 with sflash firmware*/ { USB_DEVICE(0x0cf3, 0x3004), .driver_info = BTUSB_ATH3012 }, + { USB_DEVICE(0x13d3, 0x3375), .driver_info = BTUSB_ATH3012 }, { }/* Terminating entry */ };
drivers/bluetooth/btusb.c +1 -0
@@ -122,6 +122,7 @@ static struct usb_device_id blacklist_table[] = {/* Atheros 3012 with sflash firmware */ { USB_DEVICE(0x0cf3, 0x3004), .driver_info = BTUSB_ATH3012 }, + { USB_DEVICE(0x13d3, 0x3375), .driver_info = BTUSB_ATH3012 }, /* Atheros AR5BBU12 with sflash firmware */ { USB_DEVICE(0x0489, 0xe02c), .driver_info = BTUSB_IGNORE },
Signature · 1 line
1.7.2.5
Quoted 69 lines · Vinicius Costa Gomes
Hi Eran,
Just a few cosmetic comments, and a disclaimer: I don't have any idea why it seems that every new Atheros device needs another entry in those tables.
Apart from those minor points it looks good.
Quoted 1 line · eran
From: Eran <[email protected]>
Keep the subject line shorter, under 60 or so characters, i.e. remove the part between parentheses. And prefix your subject with "Bluetooth:".
Quoted 2 lines
The bluetooth module in the Asus UX31/UX21 is based on Atheros AR3012 and requires a firmware to be uploaded before it's usable.
Please break the comment at 70 or so characters.
Quoted 46 lines
Signed-off-by Eran <[email protected]>--- drivers/bluetooth/ath3k.c | 2 ++ drivers/bluetooth/btusb.c | 1 + 2 files changed, 3 insertions(+), 0 deletions(-)drivers/bluetooth/ath3k.c +2
-0@@ -70,6 +70,7 @@ static struct usb_device_id ath3k_table[] = {/* Atheros AR3012 with sflash firmware*/ { USB_DEVICE(0x0CF3, 0x3004) }, + { USB_DEVICE(0x13d3, 0x3375) },/* Atheros AR5BBU12 with sflash firmware */ { USB_DEVICE(0x0489, 0xE02C) },@@ -86,6 +87,7 @@ static struct usb_device_id ath3k_blist_tbl[] = {/* Atheros AR3012 with sflash firmware*/ { USB_DEVICE(0x0cf3, 0x3004), .driver_info = BTUSB_ATH3012 }, + { USB_DEVICE(0x13d3, 0x3375), .driver_info = BTUSB_ATH3012 }, { }/* Terminating entry */ };drivers/bluetooth/btusb.c +1
-0@@ -122,6 +122,7 @@ static struct usb_device_id blacklist_table[] = {/* Atheros 3012 with sflash firmware */ { USB_DEVICE(0x0cf3, 0x3004), .driver_info = BTUSB_ATH3012 }, + { USB_DEVICE(0x13d3, 0x3375), .driver_info = BTUSB_ATH3012 }, /* Atheros AR5BBU12 with sflash firmware */ { USB_DEVICE(0x0489, 0xe02c), .driver_info = BTUSB_IGNORE },Signature · 6 lines
1.7.2.5 -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.htmlCheers,
Signature · 1 line
Vinicius
Re: [PATCH] Bluetooth: Adding USB device 13d3:3375 as an Atheros AR3012.
Hi Eran,
Quoted 10 lines · eran
From: Eran <[email protected]>
The bluetooth module in the Asus UX31/UX21 is based on Atheros AR3012 and requires a firmware to be uploaded before it's usable.
Signed-off-by Eran <[email protected]>--- drivers/bluetooth/ath3k.c | 2 ++ drivers/bluetooth/btusb.c | 1 + 2 files changed, 3 insertions(+), 0 deletions(-)
Please also add the output of the usb-devices scripts related to this device, then you can prove in the commit message that your change is really needed.
Gustavo
PATCH 1/1 Bluetooth: Adding USB device 13d3:3375 as an Atheros AR3012.
In reply to Vinicius Costa GomesFrom: Eran <[email protected]>
The bluetooth module in the Asus UX31/UX21 is based on Atheros AR3012 and requires a firmware to be uploaded before it's usable.
output of usb-devices for this module:
T: Bus=01 Lev=02 Prnt=02 Port=07 Cnt=03 Dev#= 6 Spd=12 MxCh= 0 D: Ver= 1.10 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs= 1 P: Vendor=13d3 ProdID=3375 Rev=00.02 S: Manufacturer=Atheros Communications S: Product=Bluetooth USB Host Controller S: SerialNumber=Alaska Day 2006 C: #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=100mA I: If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb I: If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
--- drivers/bluetooth/ath3k.c | 2 ++ drivers/bluetooth/btusb.c | 1 + 2 files changed, 3 insertions(+), 0 deletions(-)
drivers/bluetooth/ath3k.c +2 -0
@@ -70,6 +70,7 @@ static struct usb_device_id ath3k_table[] = {/* Atheros AR3012 with sflash firmware*/ { USB_DEVICE(0x0CF3, 0x3004) }, + { USB_DEVICE(0x13d3, 0x3375) },/* Atheros AR5BBU12 with sflash firmware */ { USB_DEVICE(0x0489, 0xE02C) },
@@ -86,6 +87,7 @@ static struct usb_device_id ath3k_blist_tbl[] = {/* Atheros AR3012 with sflash firmware*/ { USB_DEVICE(0x0cf3, 0x3004), .driver_info = BTUSB_ATH3012 }, + { USB_DEVICE(0x13d3, 0x3375), .driver_info = BTUSB_ATH3012 }, { }/* Terminating entry */ };
drivers/bluetooth/btusb.c +1 -0
@@ -122,6 +122,7 @@ static struct usb_device_id blacklist_table[] = {/* Atheros 3012 with sflash firmware */ { USB_DEVICE(0x0cf3, 0x3004), .driver_info = BTUSB_ATH3012 }, + { USB_DEVICE(0x13d3, 0x3375), .driver_info = BTUSB_ATH3012 }, /* Atheros AR5BBU12 with sflash firmware */ { USB_DEVICE(0x0489, 0xe02c), .driver_info = BTUSB_IGNORE },
Signature · 1 line
1.7.2.5
PATCH 1/1 Bluetooth: Adding USB device 13d3:3375 as an Atheros AR3012.
I verified this patch. It is works and seems to be correct. Please apply it. Tested on UX21 with/without patch and with/without firmware (from latest linux-firmware).
Gustavo Padovan
AppliedRe: [PATCH] Bluetooth: Adding USB device 13d3:3375 as an Atheros AR3012.
In reply to eranHi Eran,
Quoted 6 lines · eran
From: Eran <[email protected]>
The bluetooth module in the Asus UX31/UX21 is based on Atheros AR3012 and requires a firmware to be uploaded before it's usable.
output of usb-devices for this module:
Quoted 9 lines
T: Bus=01 Lev=02 Prnt=02 Port=07 Cnt=03 Dev#= 6 Spd=12 MxCh= 0 D: Ver= 1.10 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs= 1 P: Vendor=13d3 ProdID=3375 Rev=00.02 S: Manufacturer=Atheros Communications S: Product=Bluetooth USB Host Controller S: SerialNumber=Alaska Day 2006 C: #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=100mA I: If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb I: If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
I applied this patch now, thanks.
Gustavo