Skip to contentSkip to conversation

ARM: add subname parameter to mfp_set_groupg callers

PATCH In review Axel Lin 4 participants 5 messages Nov 24, 2011

Subsystems (4)
Sound ASoC SPI I2C subsystem host drivers
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 ARM: add subname parameter to mfp_set_groupg callers

commit 798681bf "ARM: 7158/1: add new MFP implement for NUC900" adds subname parameter for mfp_set_groupg.

Thus add subname parameter to the callers.

Signed-off-by Axel Lin <[email protected]>

---
commit 798681bf is in Russell King's tree, I think this patch should route via Russell's tree. This patch is against linux-next 20111123.

Axel

 drivers/i2c/busses/i2c-nuc900.c |    2 +-
 drivers/spi/spi-nuc900.c        |    2 +-
 sound/soc/nuc900/nuc900-ac97.c  |    3 ++-
 3 files changed, 4 insertions(+), 3 deletions(-)
drivers/i2c/busses/i2c-nuc900.c +1 -1
index 835e47b..03b6157 100644
@@ -593,7 +593,7 @@ static int __devinit nuc900_i2c_probe(struct platform_device *pdev)
 	i2c->adap.algo_data = i2c;
 	i2c->adap.dev.parent = &pdev->dev;
 
-	mfp_set_groupg(&pdev->dev);
+	mfp_set_groupg(&pdev->dev, NULL);
 
 	clk_get_rate(i2c->clk);
drivers/spi/spi-nuc900.c +1 -1
index e763254..21c70b2 100644
@@ -426,7 +426,7 @@ static int __devinit nuc900_spi_probe(struct platform_device *pdev)
 		goto err_clk;
 	}
 
-	mfp_set_groupg(&pdev->dev);
+	mfp_set_groupg(&pdev->dev, NULL);
 	nuc900_init_spi(hw);
 
 	err = spi_bitbang_start(&hw->bitbang);
sound/soc/nuc900/nuc900-ac97.c +2 -1
index d9343ee..dbf597f 100644
@@ -365,7 +365,8 @@ static int __devinit nuc900_ac97_drvprobe(struct platform_device *pdev)
 	if (ret)
 		goto out3;
 
-	mfp_set_groupg(nuc900_audio->dev); /* enbale ac97 multifunction pin*/
+	/* enbale ac97 multifunction pin */
+	mfp_set_groupg(nuc900_audio->dev, "nuc900-audio");
 
 	return 0;
Signature · 1 line
1.7.5.4
#2 lore raw
In reply to Axel Lin
Quoted 8 lines · Axel Lin

commit 798681bf "ARM: 7158/1: add new MFP implement for NUC900" adds subname parameter for mfp_set_groupg.

Thus add subname parameter to the callers.

Signed-off-by Axel Lin <[email protected]>

---
commit 798681bf is in Russell King's tree,

It's in mainline as of 20th November.

Quoted 2 lines

I think this patch should route via Russell's tree. This patch is against linux-next 20111123.

Is there a reason why this isn't copied to linux-arm-kernel ?

Signature · 3 lines
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
author
#3 lore raw

2011/11/24 Russell King <[email protected]>:

Quoted 11 lines · Axel Lin
Quoted 8 lines

commit 798681bf "ARM: 7158/1: add new MFP implement for NUC900" adds subname parameter for mfp_set_groupg.

Thus add subname parameter to the callers.

Signed-off-by Axel Lin <[email protected]>

---
commit 798681bf is in Russell King's tree,

It's in mainline as of 20th November.

Then this patch should be for 3.2. It fixes build errors.

Quoted 5 lines
Quoted 3 lines

I think this patch should route via Russell's tree. This patch is against linux-next 20111123.

Is there a reason why this isn't copied to linux-arm-kernel ?

Sorry.
I don't know why scripts/get_maintainer.pl does not suggest to Cc linux-arm-kernel
when I run scripts/get_maintainer.pl against this patch.

Regards,
Axel

Quoted 6 lines

--
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:

Acked-by
#4 lore raw

2011/11/24 Axel Lin <[email protected]>:

Quoted 19 lines

2011/11/24 Russell King <[email protected]>:

Quoted 11 lines · Axel Lin
Quoted 8 lines

commit 798681bf "ARM: 7158/1: add new MFP implement for NUC900" adds subname parameter for mfp_set_groupg.

Thus add subname parameter to the callers.

Signed-off-by Axel Lin <[email protected]>

---
commit 798681bf is in Russell King's tree,

It's in mainline as of 20th November.

Then this patch should be for 3.2. It fixes build errors.

Quoted 4 lines
Quoted 3 lines

I think this patch should route via Russell's tree. This patch is against linux-next 20111123.

Quoted 15 lines
Quoted 1 line

Is there a reason why this isn't copied to linux-arm-kernel ?

Sorry.
I don't know why scripts/get_maintainer.pl does not suggest to Cc linux-arm-kernel
when I run scripts/get_maintainer.pl against this patch.

Regards,
Axel

Quoted 6 lines

--
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:

Acked-by Wan Zongshun <[email protected]>

This is my omit, thanks Alex!

Signature · 2 lines
Wan ZongShun.
www.mcuos.com