Skip to contentSkip to conversation

arch/powerpc/cpu/mpc8xxx/ddr/interactive.c: Fix GCC 4.6 build warning

PATCH New Kumar Gala 2 participants 3 messages Nov 23, 2011 – Nov 24, 2011 PowerPC

lore
Share & tools
lore

Kumar Gala

author
#0 lore raw

PATCH 1/1 arch/powerpc/cpu/mpc8xxx/ddr/interactive.c: Fix GCC 4.6 build warning

Fix:

interactive.c: In function 'fsl_ddr_interactive':
interactive.c:1357:15: warning: variable 'len' set but not used [-Wunused-but-set-variable]

Signed-off-by Kumar Gala <[email protected]>
---
 arch/powerpc/cpu/mpc8xxx/ddr/interactive.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
arch/powerpc/cpu/mpc8xxx/ddr/interactive.c +1 -2
index d7d66ef..5b72437 100644
@@ -1354,7 +1354,6 @@ unsigned long long fsl_ddr_interactive(fsl_ddr_info_t *pinfo)
 {
 	unsigned long long ddrsize;
 	const char *prompt = "FSL DDR>";
-	unsigned int len;
 	char buffer[CONFIG_SYS_CBSIZE];
 	char *argv[CONFIG_SYS_MAXARGS + 1];	/* NULL terminated */
 	int argc;

@@ -1389,7 +1388,7 @@ unsigned long long fsl_ddr_interactive(fsl_ddr_info_t *pinfo)
 		 * No need to worry for buffer overflow here in
 		 * this function;  readline() maxes out at CFG_CBSIZE
 		 */
-		len = readline_into_buffer(prompt,  buffer);
+		readline_into_buffer(prompt,  buffer);
 		argc = parse_line(buffer, argv);
 		if (argc == 0)
 			continue;
Signature · 1 line
1.7.3.4
#1 lore raw

PATCH 1/1 arch/powerpc/cpu/mpc8xxx/ddr/interactive.c: Fix GCC 4.6 build warning

Quoted 24 lines

Fix:

interactive.c: In function 'fsl_ddr_interactive':
interactive.c:1357:15: warning: variable 'len' set but not used [-Wunused-but-set-variable]

Signed-off-by Kumar Gala <[email protected]>
---
 arch/powerpc/cpu/mpc8xxx/ddr/interactive.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
(quoted diff) +0 -0

b/arch/powerpc/cpu/mpc8xxx/ddr/interactive.c index d7d66ef..5b72437 100644

arch/powerpc/cpu/mpc8xxx/ddr/interactive.c +0 -1
@@ -1354,7 +1354,6 @@ unsigned long long fsl_ddr_interactive(fsl_ddr_info_t
 *pinfo) {
 	unsigned long long ddrsize;
 	const char *prompt = "FSL DDR>";
-	unsigned int len;
 	char buffer[CONFIG_SYS_CBSIZE];
 	char *argv[CONFIG_SYS_MAXARGS + 1];	/* NULL terminated */
 	int argc;

arch/powerpc/cpu/mpc8xxx/ddr/interactive.c unsigned long long fsl_ddr_interactive(fsl_ddr_info_t · line 1394

Quoted 8 lines
arch/powerpc/cpu/mpc8xxx/ddr/interactive.c +1 -1
@@ -1389,7 +1388,7 @@ unsigned long long fsl_ddr_interactive(fsl_ddr_info_t
 *pinfo) * No need to worry for buffer overflow here in
 		 * this function;  readline() maxes out at CFG_CBSIZE
 		 */
-		len = readline_into_buffer(prompt,  buffer);
+		readline_into_buffer(prompt,  buffer);
 		argc = parse_line(buffer, argv);
 		if (argc == 0)
 			continue;

Ok, I'll pick this one.

#2 lore raw

PATCH 1/1 arch/powerpc/cpu/mpc8xxx/ddr/interactive.c: Fix GCC 4.6 build warning

Quoted 38 lines
Quoted 38 lines

Fix:

interactive.c: In function 'fsl_ddr_interactive':
interactive.c:1357:15: warning: variable 'len' set but not used [-Wunused-but-set-variable]

Signed-off-by Kumar Gala <[email protected]>

---

 arch/powerpc/cpu/mpc8xxx/ddr/interactive.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
(quoted diff) +0 -0

b/arch/powerpc/cpu/mpc8xxx/ddr/interactive.c index d7d66ef..5b72437 100644 --- a/arch/powerpc/cpu/mpc8xxx/ddr/interactive.c +++ b/arch/powerpc/cpu/mpc8xxx/ddr/interactive.c

(quoted diff) +0 -1
@@ -1354,7 +1354,6 @@ unsigned long long
 fsl_ddr_interactive(fsl_ddr_info_t *pinfo) {
 
 	unsigned long long ddrsize;
 	const char *prompt = "FSL DDR>";
 
-	unsigned int len;
arch/powerpc/cpu/mpc8xxx/ddr/interactive.c +0 -0
 	char buffer[CONFIG_SYS_CBSIZE];
 	char *argv[CONFIG_SYS_MAXARGS + 1];	/* NULL terminated */
 	int argc;

@@ -1389,7 +1388,7 @@ unsigned long long

fsl_ddr_interactive(fsl_ddr_info_t *pinfo) * No need to worry for buffer overflow here in

arch/powerpc/cpu/mpc8xxx/ddr/interactive.c +1 -1
 		 * this function;  readline() maxes out at CFG_CBSIZE
 		 */
 
-		len = readline_into_buffer(prompt,  buffer);
+		readline_into_buffer(prompt,  buffer);
Quoted 6 lines

arch/powerpc/cpu/mpc8xxx/ddr/interactive.c unsigned long long fsl_ddr_interactive(fsl_ddr_info_t *pinfo) · line 1394

Quoted 4 lines
arch/powerpc/cpu/mpc8xxx/ddr/interactive.c +0 -0
 		argc = parse_line(buffer, argv);
 		if (argc == 0)
 
 			continue;

Ok, I'll pick this one.

Picked to:
u-boot-staging.git / marek.vasut at gmail.com