post: fix compile issue for post tests on kirkwood

PATCH New Holger Brunck 3 participants 9 messages Nov 24, 2011 – Nov 28, 2011

Share & tools

Holger Brunck

author

2011-11-24 13:09 UTC #0 lore raw

PATCH 1/1 post: fix compile issue for post tests on kirkwood

commit f31a911fe (arm, post: add missing post_time_ms for arm) enables get_ticks and get_tbclk for all arm based boards, but kirkwood has currently no implementation for this. So undefine this for kirkwood boards.

Signed-off-by Holger Brunck <[email protected]>

cc Heiko Schocher <[email protected]>

cc Prafulla Wadaskar <[email protected]>

cc Valentin Longchamp <[email protected]>

---
 post/post.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

post/post.c +1 -1

index 0e67ad7..422a819 100644
@@ -494,7 +494,7 @@ void post_reloc(void)
  */
 unsigned long post_time_ms(unsigned long base)
 {
-#if defined(CONFIG_PPC) || defined(CONFIG_ARM)
+#if defined(CONFIG_PPC) || defined(CONFIG_ARM) && !defined(CONFIG_KIRKWOOD)
 	return (unsigned long)(get_ticks() / (get_tbclk() / CONFIG_SYS_HZ))
 		- base;
 #else

Signature · 1 line

1.7.1

Marek Vasut

2011-11-25 08:52 UTC #1 lore raw

PATCH 1/1 post: fix compile issue for post tests on kirkwood

Quoted 4 lines

commit f31a911fe (arm, post: add missing post_time_ms for arm) enables get_ticks and get_tbclk for all arm based boards, but kirkwood has currently no implementation for this. So undefine this for kirkwood boards.

So this means the kirkwood timer doesn't conform to current timer api? Why work it around and not fix it then?

Prafulla Wadaskar

2011-11-25 09:16 UTC #2 lore raw

PATCH 1/1 post: fix compile issue for post tests on kirkwood

Quoted 11 lines

-----Original Message-----
From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Marek Vasut
Sent: 25 November 2011 14:22
To: u-boot at lists.denx.de
Cc: Valentin at theia.denx.de; Longchamp; Heiko Schocher; Holger Brunck
Subject: Re: [U-Boot] [PATCH] post: fix compile issue for post tests on kirkwood

Quoted 8 lines

Quoted 4 lines
commit f31a911fe (arm, post: add missing post_time_ms for arm) enables get_ticks and get_tbclk for all arm based boards, but kirkwood has currently no implementation for this. So undefine this for kirkwood boards.
So this means the kirkwood timer doesn't conform to current timer api? Why work
it around and not fix it then?

I think this is better approach

Regards..
Prafulla . . .

Marek Vasut

2011-11-25 09:22 UTC #3 lore raw

PATCH 1/1 post: fix compile issue for post tests on kirkwood

Quoted 14 lines

Quoted 14 lines
-----Original Message-----
From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Marek Vasut
Sent: 25 November 2011 14:22
To: u-boot at lists.denx.de
Cc: Valentin at theia.denx.de; Longchamp; Heiko Schocher; Holger Brunck
Subject: Re: [U-Boot] [PATCH] post: fix compile issue for post tests on kirkwood
Quoted 4 lines
commit f31a911fe (arm, post: add missing post_time_ms for arm) enables get_ticks and get_tbclk for all arm based boards, but kirkwood has currently no implementation for this. So undefine this for kirkwood boards.

Quoted 6 lines

Quoted 3 lines
So this means the kirkwood timer doesn't conform to current timer api? Why work
it around and not fix it then?
I think this is better approach

Right? :) So now the question is ... who's gonna do it ? ;-)

Prafulla Wadaskar

2011-11-26 10:29 UTC #4 lore raw

PATCH 1/1 post: fix compile issue for post tests on kirkwood

Quoted 27 lines

-----Original Message-----
From: Marek Vasut [mailto:marek.vasut at gmail.com]
Sent: 25 November 2011 14:52
To: Prafulla Wadaskar
Cc: u-boot at lists.denx.de; Valentin at theia.denx.de; Longchamp; Heiko Schocher; Holger Brunck
Subject: Re: [U-Boot] [PATCH] post: fix compile issue for post tests on kirkwood
Quoted 2 lines
Quoted 2 lines
-----Original Message-----
From: u-boot-bounces at lists.denx.de [mailto:u-boot-
bounces at lists.denx.de]
Quoted 5 lines
Quoted 5 lines
On Behalf Of Marek Vasut
Sent: 25 November 2011 14:22
To: u-boot at lists.denx.de
Cc: Valentin at theia.denx.de; Longchamp; Heiko Schocher; Holger Brunck
Subject: Re: [U-Boot] [PATCH] post: fix compile issue for post tests
on
Quoted 7 lines
Quoted 7 lines
kirkwood
Quoted 4 lines
commit f31a911fe (arm, post: add missing post_time_ms for arm) enables get_ticks and get_tbclk for all arm based boards, but kirkwood has currently no implementation for this. So undefine this for kirkwood boards.

Quoted 7 lines

Quoted 6 lines
Quoted 3 lines
So this means the kirkwood timer doesn't conform to current timer api? Why work
it around and not fix it then?
I think this is better approach
Right? :) So now the question is ... who's gonna do it ? ;-)

Patch from any one is welcomed. :-D

Regards..
Prafulla . . .

Marek Vasut

2011-11-26 11:45 UTC #5 lore raw

PATCH 1/1 post: fix compile issue for post tests on kirkwood

Quoted 33 lines

Quoted 33 lines
-----Original Message-----
From: Marek Vasut [mailto:marek.vasut at gmail.com]
Sent: 25 November 2011 14:52
To: Prafulla Wadaskar
Cc: u-boot at lists.denx.de; Valentin at theia.denx.de; Longchamp; Heiko Schocher; Holger Brunck
Subject: Re: [U-Boot] [PATCH] post: fix compile issue for post tests on kirkwood
Quoted 2 lines
Quoted 2 lines
-----Original Message-----
From: u-boot-bounces at lists.denx.de [mailto:u-boot-
bounces at lists.denx.de]
Quoted 5 lines
Quoted 5 lines
On Behalf Of Marek Vasut
Sent: 25 November 2011 14:22
To: u-boot at lists.denx.de
Cc: Valentin at theia.denx.de; Longchamp; Heiko Schocher; Holger Brunck
Subject: Re: [U-Boot] [PATCH] post: fix compile issue for post tests
on
Quoted 11 lines
Quoted 10 lines
kirkwood
Quoted 4 lines
commit f31a911fe (arm, post: add missing post_time_ms for arm) enables get_ticks and get_tbclk for all arm based boards, but kirkwood has currently no implementation for this. So undefine this for kirkwood boards.
So this means the kirkwood timer doesn't conform to current timer api? Why work
it around and not fix it then?

Quoted 5 lines

Quoted 3 lines
Quoted 1 line
I think this is better approach
Right? :) So now the question is ... who's gonna do it ? ;-)
Patch from any one is welcomed. :-D

Anyone, eh? Anyone ... anyone like the maintainer maybe ? >:-D M

Prafulla Wadaskar

2011-11-27 05:56 UTC #6 lore raw

PATCH 1/1 post: fix compile issue for post tests on kirkwood

Quoted 47 lines

-----Original Message-----
From: Marek Vasut [mailto:marek.vasut at gmail.com]
Sent: 26 November 2011 17:15
To: Prafulla Wadaskar
Cc: u-boot at lists.denx.de; Valentin at theia.denx.de; Longchamp; Heiko Schocher; Holger Brunck
Subject: Re: [U-Boot] [PATCH] post: fix compile issue for post tests on kirkwood
Quoted 7 lines
Quoted 7 lines
-----Original Message-----
From: Marek Vasut [mailto:marek.vasut at gmail.com]
Sent: 25 November 2011 14:52
To: Prafulla Wadaskar
Cc: u-boot at lists.denx.de; Valentin at theia.denx.de; Longchamp; Heiko Schocher; Holger Brunck
Subject: Re: [U-Boot] [PATCH] post: fix compile issue for post tests
on
Quoted 11 lines
Quoted 11 lines
kirkwood
Quoted 2 lines
Quoted 2 lines
-----Original Message-----
From: u-boot-bounces at lists.denx.de [mailto:u-boot-
bounces at lists.denx.de]
Quoted 4 lines
Quoted 4 lines
On Behalf Of Marek Vasut
Sent: 25 November 2011 14:22
To: u-boot at lists.denx.de
Cc: Valentin at theia.denx.de; Longchamp; Heiko Schocher; Holger
Brunck
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Subject: Re: [U-Boot] [PATCH] post: fix compile issue for post
tests
Quoted 14 lines
Quoted 14 lines
on
Quoted 11 lines
Quoted 10 lines
kirkwood
Quoted 4 lines
commit f31a911fe (arm, post: add missing post_time_ms for arm) enables get_ticks and get_tbclk for all arm based boards, but kirkwood has currently no implementation for this. So undefine this for kirkwood boards.
So this means the kirkwood timer doesn't conform to current timer api? Why work
it around and not fix it then?

Quoted 7 lines

Quoted 5 lines
Quoted 3 lines
Quoted 1 line
I think this is better approach
Right? :) So now the question is ... who's gonna do it ? ;-)
Patch from any one is welcomed. :-D
Anyone, eh? Anyone ... anyone like the maintainer maybe ? >:-D

I would have loved to do it, but I am very busy with some other very important assignment. May be I will post a patch in feb2012

Regards..
Prafulla . .

Marek Vasut

2011-11-27 07:07 UTC #7 lore raw

PATCH 1/1 post: fix compile issue for post tests on kirkwood

Quoted 52 lines

Quoted 52 lines
-----Original Message-----
From: Marek Vasut [mailto:marek.vasut at gmail.com]
Sent: 26 November 2011 17:15
To: Prafulla Wadaskar
Cc: u-boot at lists.denx.de; Valentin at theia.denx.de; Longchamp; Heiko Schocher; Holger Brunck
Subject: Re: [U-Boot] [PATCH] post: fix compile issue for post tests on kirkwood
Quoted 7 lines
Quoted 7 lines
-----Original Message-----
From: Marek Vasut [mailto:marek.vasut at gmail.com]
Sent: 25 November 2011 14:52
To: Prafulla Wadaskar
Cc: u-boot at lists.denx.de; Valentin at theia.denx.de; Longchamp; Heiko Schocher; Holger Brunck
Subject: Re: [U-Boot] [PATCH] post: fix compile issue for post tests
on
Quoted 11 lines
Quoted 11 lines
kirkwood
Quoted 2 lines
Quoted 2 lines
-----Original Message-----
From: u-boot-bounces at lists.denx.de [mailto:u-boot-
bounces at lists.denx.de]
Quoted 4 lines
Quoted 4 lines
On Behalf Of Marek Vasut
Sent: 25 November 2011 14:22
To: u-boot at lists.denx.de
Cc: Valentin at theia.denx.de; Longchamp; Heiko Schocher; Holger
Brunck
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Subject: Re: [U-Boot] [PATCH] post: fix compile issue for post
tests
Quoted 15 lines
Quoted 15 lines
on
Quoted 12 lines
Quoted 10 lines
kirkwood
Quoted 4 lines
commit f31a911fe (arm, post: add missing post_time_ms for arm) enables get_ticks and get_tbclk for all arm based boards, but kirkwood has currently no implementation for this. So undefine this for kirkwood boards.
So this means the kirkwood timer doesn't conform to current timer api? Why work
it around and not fix it then?
I think this is better approach

Quoted 9 lines

Quoted 5 lines
Quoted 3 lines
Quoted 1 line
Right? :) So now the question is ... who's gonna do it ? ;-)
Patch from any one is welcomed. :-D
Anyone, eh? Anyone ... anyone like the maintainer maybe ? >:-D
I would have loved to do it, but I am very busy with some other very important assignment. May be I will post a patch in feb2012

I'll keep an eye on this ;-)

Holger Brunck

author

2011-11-28 08:51 UTC #8 lore raw

PATCH 1/1 post: fix compile issue for post tests on kirkwood

Hi,

Quoted 16 lines · Marek Vasut

Quoted 16 lines
Quoted 16 lines
Quoted 15 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 5 lines
commit f31a911fe (arm, post: add missing post_time_ms for arm) enables get_ticks and get_tbclk for all arm based boards, but kirkwood has currently no implementation for this. So undefine this for kirkwood boards.
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
So this means the kirkwood timer doesn't conform to current timer api? Why work
it around and not fix it then?
I think this is better approach
Right? :) So now the question is ... who's gonna do it ? ;-)
Patch from any one is welcomed. :-D

Quoted 7 lines

Quoted 5 lines
Quoted 1 line
Anyone, eh? Anyone ... anyone like the maintainer maybe ? >:-D
I would have loved to do it, but I am very busy with some other very important assignment. May be I will post a patch in feb2012
I'll keep an eye on this ;-)

I do also agree that implementing the functions would be better then adding an #ifdef as my patch does. But I currently got also no time to do this.

So could someone please pick this patch up that the keymile ARM boards are compilable again?

Best regards
Holger