Skip to contentSkip to conversation

dataflash: fix parameters order in write_dataflash()

PATCH New Igor Grinberg 2 participants 4 messages Nov 5, 2011 – Nov 27, 2011

lore
Share & tools
lore

Igor Grinberg

author
#0 lore raw

PATCH 1/1 dataflash: fix parameters order in write_dataflash()

Fix parameters order in write_dataflash() function extern declaration in the header file.
Parameters order, as in function definition, should be:
addr_dest, addr_src, size.

Signed-off-by Igor Grinberg <[email protected]>
---
 include/dataflash.h |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
include/dataflash.h +2 -1
index 96ac097..094babb 100644
@@ -207,7 +207,8 @@ extern int addr2ram(ulong addr);
 extern int dataflash_real_protect (int flag, unsigned long start_addr, unsigned long end_addr);
 extern int addr_dataflash (unsigned long addr);
 extern int read_dataflash (unsigned long addr, unsigned long size, char *result);
-extern int write_dataflash (unsigned long addr, unsigned long dest, unsigned long size);
+extern int write_dataflash(unsigned long addr_dest, unsigned long addr_src,
+			   unsigned long size);
 extern void dataflash_print_info (void);
 extern void dataflash_perror (int err);
 extern void AT91F_DataflashSetEnv (void);
Signature · 1 line
1.7.3.4
author
#1 lore raw

PATCH 1/1 dataflash: fix parameters order in write_dataflash()

Hi all,

This is a trivial patch and it has been 18 days since posting it. Can someone take care of it, please?

Quoted 24 lines · Igor Grinberg

Fix parameters order in write_dataflash() function extern declaration in the header file.
Parameters order, as in function definition, should be:
addr_dest, addr_src, size.

Signed-off-by Igor Grinberg <[email protected]>
---
 include/dataflash.h |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
include/dataflash.h +2 -1
index 96ac097..094babb 100644
@@ -207,7 +207,8 @@ extern int addr2ram(ulong addr);
 extern int dataflash_real_protect (int flag, unsigned long start_addr, unsigned long end_addr);
 extern int addr_dataflash (unsigned long addr);
 extern int read_dataflash (unsigned long addr, unsigned long size, char *result);
-extern int write_dataflash (unsigned long addr, unsigned long dest, unsigned long size);
+extern int write_dataflash(unsigned long addr_dest, unsigned long addr_src,
+			   unsigned long size);
 extern void dataflash_print_info (void);
 extern void dataflash_perror (int err);
 extern void AT91F_DataflashSetEnv (void);
Signature · 2 lines
Regards,
Igor.
author
#2 lore raw

PATCH v2 1/1 dataflash: fix parameters order in write_dataflash()

In reply to Igor Grinberg

Fix parameters order in write_dataflash() function extern declaration in the header file.
Parameters order, as in function definition, should be:
addr_dest, addr_src, size.

Signed-off-by Igor Grinberg <[email protected]>

---
v2: rebase on TOT

 include/dataflash.h |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
include/dataflash.h +2 -1
index 056e18b..94f86b3 100644
@@ -207,7 +207,8 @@ extern int addr2ram(ulong addr);
 extern int dataflash_real_protect (int flag, unsigned long start_addr, unsigned long end_addr);
 extern int addr_dataflash (unsigned long addr);
 extern int read_dataflash (unsigned long addr, unsigned long size, char *result);
-extern int write_dataflash (unsigned long addr, unsigned long dest, unsigned long size);
+extern int write_dataflash(unsigned long addr_dest, unsigned long addr_src,
+			unsigned long size);
 extern int AT91F_DataflashInit(void);
 
 extern void dataflash_print_info (void);
Signature · 1 line
1.7.3.4
#3 lore raw

PATCH v2 1/1 dataflash: fix parameters order in write_dataflash()

Quoted 11 lines · On Sun, 27 Nov 2011 11:06:46 +0200 Igor Grinberg <[email protected]>…

Fix parameters order in write_dataflash() function extern declaration in the header file.
Parameters order, as in function definition, should be:
addr_dest, addr_src, size.

Signed-off-by Igor Grinberg <[email protected]>

---
v2: rebase on TOT

 include/dataflash.h |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

Applied to u-boot-staging/agust at denx.de. Thanks!

Anatolij