Skip to contentSkip to conversation

PNP: Use constant PNP_ID_LEN instead of literal number

PATCH New Witold Szczeponik 1 participant 1 message Nov 27, 2011

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 PNP: Use constant PNP_ID_LEN instead of literal number

The attached patch uses the constant PNP_ID_LEN instead of using a literal number for the length of a PNP ID in the scope of PNP quirks.

As a consequence, all IDs used in PNP quirks (c.f. "drivers/pnp/quirks.c") are now zero-terminated and standard functions that depend on the IDs to be zero-terminated now work reliably (c.f. "strlen" in "drivers/pnp/driver.c", function "compare_pnp_id").

The patch is applied against 3.1.

include/linux/pnp.h +1 -1
Index: linux/include/linux/pnp.h
===================================================================
@@ -295,7 +295,7 @@ static inline void pnp_set_drvdata(struc
 }
 
 struct pnp_fixup {
-	char id[7];
+	char id[PNP_ID_LEN];
 	void (*quirk_function) (struct pnp_dev * dev);	/* fixup function */
 };
 
Signature · 6 lines
NEU: FreePhone - 0ct/min Handyspartarif mit Geld-zurück-Garantie!		
Jetzt informieren: http://www.gmx.net/de/go/freephone
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html