Skip to contentSkip to conversation

Add MYMETA.yml to perl/.gitignore

PATCH In review Sebastian Morr 3 participants 5 messages Jun 15, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Add MYMETA.yml to perl/.gitignore

This file is auto-generated in the process of building the Perl extension.

---

Good day, fine Sirs and Madams,

I just built Git for the first time, issued "git status", and there was this untracked file. I guess you could call that an itch. This patch fixes that, however, I'm not sure whether this is a relevant issue.

Didn't know whom to Cc, as the perl directory doesn't seem to get much attention lately.

Kind regards,
Sebastian

 perl/.gitignore |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
perl/.gitignore +1 -0
index 98b2477..9235e73 100644
@@ -1,5 +1,6 @@
 perl.mak
 perl.mak.old
+MYMETA.yml
 blib
 blibdirs
 pm_to_blib
Signature · 1 line
1.7.8.rc4.dirty
#1 lore raw
Quoted 8 lines · Sebastian Morr

This file is auto-generated in the process of building the Perl extension.

[...]

I just built Git for the first time, issued "git status", and there was this untracked file. I guess you could call that an itch. This patch fixes that, however, I'm not sure whether this is a relevant issue.

Thanks, I wrote the same patch myself last week. I could swear I sent it to the list, but it appears that I forgot.

The only thing I would add is the reason this is suddenly coming up now:
generating MYMETA.yml is done only by new-ish versions of ExtUtils::MakeMaker (it started for me with perl 5.14, which just hit debian unstable recently). The file just contains extra information about the environment and arguments to the Makefile-building process, and can be safely deleted.

-Peff

#2 lore raw

PATCH v2 1/1 Add MYMETA.yml to perl/.gitignore

This file is auto-generated by newer versions of ExtUtils::MakeMaker (presumably starting with the version shipping with Perl 5.14). It just contains extra information about the environment and arguments to the Makefile-building process, and can be safely deleted.

---
 perl/.gitignore |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
perl/.gitignore +1 -0
index 98b2477..9235e73 100644
@@ -1,5 +1,6 @@
 perl.mak
 perl.mak.old
+MYMETA.yml
 blib
 blibdirs
 pm_to_blib
Signature · 1 line
1.7.8.rc4.dirty
#3 lore raw
Quoted 4 lines · Sebastian Morr

This file is auto-generated by newer versions of ExtUtils::MakeMaker (presumably starting with the version shipping with Perl 5.14). It just contains extra information about the environment and arguments to the Makefile-building process, and can be safely deleted.

"safely deleted" sounds as if you made "make clean" remove it. I do not mind doing s/and can be.*/and should be ignored./ myself, if you want.

Does running "make clean" actually remove it, by the way?

Quoted 16 lines
---
 perl/.gitignore |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
perl/.gitignore +1 -0
index 98b2477..9235e73 100644
@@ -1,5 +1,6 @@
 perl.mak
 perl.mak.old
+MYMETA.yml
 blib
 blibdirs
 pm_to_blib
#4 lore raw
Quoted 9 lines · Junio C Hamano
Quoted 4 lines · Sebastian Morr

This file is auto-generated by newer versions of ExtUtils::MakeMaker (presumably starting with the version shipping with Perl 5.14). It just contains extra information about the environment and arguments to the Makefile-building process, and can be safely deleted.

"safely deleted" sounds as if you made "make clean" remove it. I do not mind doing s/and can be.*/and should be ignored./ myself, if you want.

You're very welcome to do that.

Quoted 1 line

Does running "make clean" actually remove it, by the way?

Yes, it does. perl/perl.mak (which, in turn, is generated by MakeMaker via perl/Makefile) takes care of that file explicitly.