Skip to contentSkip to conversation

sparc: fix unknown escape sequence warnings

PATCH New Mike Frysinger 3 participants 4 messages Oct 13, 2011 – Dec 1, 2011

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sparc: fix unknown escape sequence warnings

I don't know what exactly the code was going for, but the object code is the same before/after my change, and in looking at the env strings, this seems to be OK.

Otherwise gcc warns:
cc1: warning: unknown escape sequence: '\$'
cc1: warning: unknown escape sequence: '\)'
cc1: warning: unknown escape sequence: '\040'
cc1: warning: unknown escape sequence: '\$'
cc1: warning: unknown escape sequence: '\)'

---
 include/configs/gr_cpci_ax2000.h |    2 +-
 include/configs/gr_ep2s60.h      |    2 +-
 include/configs/gr_xc3s_1500.h   |    2 +-
 include/configs/grsim.h          |    2 +-
 include/configs/grsim_leon2.h    |    2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)
include/configs/gr_cpci_ax2000.h +1 -1
index a127a2b..992aea5 100644
@@ -108,7 +108,7 @@
 		"bootm ${kernel_addr}\0"				\
 	"flash_self=run ramargs addip;"					\
 		"bootm ${kernel_addr} ${ramdisk_addr}\0"		\
-	"getkernel=tftpboot \$\(scratch\)\ \$\(bootfile\)\0" \
+	"getkernel=tftpboot $(scratch) $(bootfile)\0" \
 	"bootargs=console=ttyS0,38400 root=/dev/nfs rw nfsroot=192.168.0.20:/export/rootfs ip=192.168.0.206:192.168.0.20:192.168.0.1:255.255.255.0:ax2000:eth0\0"
 
 #if CONFIG_LEON_RAM_SELECT == CONFIG_LEON_RAM_SRAM
include/configs/gr_ep2s60.h +1 -1
index 643efc4..d1fcf3b 100644
@@ -115,7 +115,7 @@
 		"bootm ${kernel_addr} ${ramdisk_addr}\0"		\
 	"net_nfs=tftp 40000000 ${bootfile};run nfsargs addip;bootm\0"	\
 	"scratch=40800000\0"					\
-	"getkernel=tftpboot \$\(scratch\)\ \$\(bootfile\)\0" \
+	"getkernel=tftpboot $(scratch) $(bootfile)\0" \
 	"bootargs=console=ttyS0,38400 root=/dev/nfs rw nfsroot=192.168.0.20:/export/rootfs ip=192.168.0.207:192.168.0.20:192.168.0.1:255.255.255.0:ml401:eth0\0" \
 	""
 
include/configs/gr_xc3s_1500.h +1 -1
index e13299e..1d804f8 100644
@@ -91,7 +91,7 @@
 		"bootm ${kernel_addr} ${ramdisk_addr}\0"		\
 	"net_nfs=tftp 40000000 ${bootfile};run nfsargs addip;bootm\0"	\
 	"scratch=40200000\0"					\
-	"getkernel=tftpboot \$\(scratch\)\ \$\(bootfile\)\0" \
+	"getkernel=tftpboot $(scratch) $(bootfile)\0" \
 	"bootargs=console=ttyS0,38400 root=/dev/nfs rw nfsroot=192.168.0.20:/export/rootfs ip=192.168.0.206:192.168.0.20:192.168.0.1:255.255.255.0:grxc3s1500_daniel:eth0\0" \
 	""
 
include/configs/grsim.h +1 -1
index f868d96..73bd494 100644
@@ -113,7 +113,7 @@
 	"net_nfs=tftp 40000000 ${bootfile};run nfsargs addip;bootm\0"	\
 	"rootpath=/export/roofs\0"					\
 	"scratch=40000000\0"					\
-	"getkernel=tftpboot \$\(scratch\)\ \$\(bootfile\)\0" \
+	"getkernel=tftpboot $(scratch) $(bootfile)\0" \
 	"ethaddr=00:00:7A:CC:00:12\0" \
 	"bootargs=console=ttyS0,38400" \
 	""
include/configs/grsim_leon2.h +1 -1
index ed1008f..75e9605 100644
@@ -110,7 +110,7 @@
 	"net_nfs=tftp 40000000 ${bootfile};run nfsargs addip;bootm\0"	\
 	"rootpath=/export/roofs\0"					\
 	"scratch=40000000\0"					\
-	"getkernel=tftpboot \$\(scratch\)\ \$\(bootfile\)\0" \
+	"getkernel=tftpboot $(scratch) $(bootfile)\0" \
 	"ethaddr=00:00:7A:CC:00:12\0" \
 	"bootargs=console=ttyS0,38400" \
 	""
Signature · 1 line
1.7.6.1
#1 lore raw

PATCH 1/1 sparc: fix unknown escape sequence warnings

Quoted 10 lines · Mike Frysinger

I don't know what exactly the code was going for, but the object code is the same before/after my change, and in looking at the env strings, this seems to be OK.

Otherwise gcc warns:
cc1: warning: unknown escape sequence: '\$'
cc1: warning: unknown escape sequence: '\)'
cc1: warning: unknown escape sequence: '\040'
cc1: warning: unknown escape sequence: '\$'
cc1: warning: unknown escape sequence: '\)'

Thanks for fixing this. Do you want me to run it through the sparc repository or should Wolfgang take the two patches right away?

Daniel

Quoted 74 lines
---
  include/configs/gr_cpci_ax2000.h |    2 +-
  include/configs/gr_ep2s60.h      |    2 +-
  include/configs/gr_xc3s_1500.h   |    2 +-
  include/configs/grsim.h          |    2 +-
  include/configs/grsim_leon2.h    |    2 +-
  5 files changed, 5 insertions(+), 5 deletions(-)
include/configs/gr_cpci_ax2000.h +1 -1
index a127a2b..992aea5 100644
@@ -108,7 +108,7 @@
  		"bootm ${kernel_addr}\0"				\
  	"flash_self=run ramargs addip;"					\
  		"bootm ${kernel_addr} ${ramdisk_addr}\0"		\
-	"getkernel=tftpboot \$\(scratch\)\ \$\(bootfile\)\0" \
+	"getkernel=tftpboot $(scratch) $(bootfile)\0" \
  	"bootargs=console=ttyS0,38400 root=/dev/nfs rw nfsroot=192.168.0.20:/export/rootfs ip=192.168.0.206:192.168.0.20:192.168.0.1:255.255.255.0:ax2000:eth0\0"
 
  #if CONFIG_LEON_RAM_SELECT == CONFIG_LEON_RAM_SRAM
include/configs/gr_ep2s60.h +1 -1
index 643efc4..d1fcf3b 100644
@@ -115,7 +115,7 @@
  		"bootm ${kernel_addr} ${ramdisk_addr}\0"		\
  	"net_nfs=tftp 40000000 ${bootfile};run nfsargs addip;bootm\0"	\
  	"scratch=40800000\0"					\
-	"getkernel=tftpboot \$\(scratch\)\ \$\(bootfile\)\0" \
+	"getkernel=tftpboot $(scratch) $(bootfile)\0" \
  	"bootargs=console=ttyS0,38400 root=/dev/nfs rw nfsroot=192.168.0.20:/export/rootfs ip=192.168.0.207:192.168.0.20:192.168.0.1:255.255.255.0:ml401:eth0\0" \
  	""
 
include/configs/gr_xc3s_1500.h +1 -1
index e13299e..1d804f8 100644
@@ -91,7 +91,7 @@
  		"bootm ${kernel_addr} ${ramdisk_addr}\0"		\
  	"net_nfs=tftp 40000000 ${bootfile};run nfsargs addip;bootm\0"	\
  	"scratch=40200000\0"					\
-	"getkernel=tftpboot \$\(scratch\)\ \$\(bootfile\)\0" \
+	"getkernel=tftpboot $(scratch) $(bootfile)\0" \
  	"bootargs=console=ttyS0,38400 root=/dev/nfs rw nfsroot=192.168.0.20:/export/rootfs ip=192.168.0.206:192.168.0.20:192.168.0.1:255.255.255.0:grxc3s1500_daniel:eth0\0" \
  	""
 
include/configs/grsim.h +1 -1
index f868d96..73bd494 100644
@@ -113,7 +113,7 @@
  	"net_nfs=tftp 40000000 ${bootfile};run nfsargs addip;bootm\0"	\
  	"rootpath=/export/roofs\0"					\
  	"scratch=40000000\0"					\
-	"getkernel=tftpboot \$\(scratch\)\ \$\(bootfile\)\0" \
+	"getkernel=tftpboot $(scratch) $(bootfile)\0" \
  	"ethaddr=00:00:7A:CC:00:12\0" \
  	"bootargs=console=ttyS0,38400" \
  	""
include/configs/grsim_leon2.h +1 -1
index ed1008f..75e9605 100644
@@ -110,7 +110,7 @@
  	"net_nfs=tftp 40000000 ${bootfile};run nfsargs addip;bootm\0"	\
  	"rootpath=/export/roofs\0"					\
  	"scratch=40000000\0"					\
-	"getkernel=tftpboot \$\(scratch\)\ \$\(bootfile\)\0" \
+	"getkernel=tftpboot $(scratch) $(bootfile)\0" \
  	"ethaddr=00:00:7A:CC:00:12\0" \
  	"bootargs=console=ttyS0,38400" \
  	""
#2 lore raw

PATCH 1/1 sparc: fix unknown escape sequence warnings

Quoted 12 lines · On Thursday 13 October 2011 04:49:59 Daniel Hellstrom wrote:
Quoted 10 lines · Mike Frysinger

I don't know what exactly the code was going for, but the object code is the same before/after my change, and in looking at the env strings, this seems to be OK.

Otherwise gcc warns:
cc1: warning: unknown escape sequence: '\$'
cc1: warning: unknown escape sequence: '\)'
cc1: warning: unknown escape sequence: '\040'
cc1: warning: unknown escape sequence: '\$'
cc1: warning: unknown escape sequence: '\)'

Quoted 2 lines

Thanks for fixing this. Do you want me to run it through the sparc repository or should Wolfgang take the two patches right away?

they're not critical, so feel free to merge however you like
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111013/d24366af/attachment.pgp

#3 lore raw

PATCH 1/1 sparc: fix unknown escape sequence warnings

In reply to Mike Frysinger
Quoted 11 lines · On Thu, 13 Oct 2011 01:47:51 -0400 Mike Frysinger <[email protected]> wrote:

I don't know what exactly the code was going for, but the object code is the same before/after my change, and in looking at the env strings, this seems to be OK.

Otherwise gcc warns:
cc1: warning: unknown escape sequence: '\$'
cc1: warning: unknown escape sequence: '\)'
cc1: warning: unknown escape sequence: '\040'
cc1: warning: unknown escape sequence: '\$'
cc1: warning: unknown escape sequence: '\)'

Quoted 8 lines
---
 include/configs/gr_cpci_ax2000.h |    2 +-
 include/configs/gr_ep2s60.h      |    2 +-
 include/configs/gr_xc3s_1500.h   |    2 +-
 include/configs/grsim.h          |    2 +-
 include/configs/grsim_leon2.h    |    2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

Appied to u-boot-staging/agust at denx.de. Thanks!

Anatolij