Skip to contentSkip to conversation

stable-3.1: iwlwifi broken with nomsi

DISCUSSION Johan Hovold 3 participants 7 messages Nov 28, 2011 – Dec 3, 2011 Stable branch

lore
Share & tools
lore

Johan Hovold

author
#0 lore raw

Hi Greg,

I believe commit 63665158282dd3b5d70 (iwlwifi: allow pci_enable_msi fail) needs to be added to the 3.1 stable tree as the driver fails to probe with MSI disabled since commit 084dd79172cb3 (iwlagn: move PCI related operations from probe and remove to PCI layer) without it:

[    2.564901] iwlagn 0000:0e:00.0: PCI INT A -> GSI 18 (level, low) ->
IRQ 18
[    2.564962] iwlagn 0000:0e:00.0: setting latency timer to 64
[    2.564977] iwlagn 0000:0e:00.0: pci_resource_len = 0x00002000
[    2.567136] iwlagn 0000:0e:00.0: pci_resource_base = f8038000
[    2.569274] iwlagn 0000:0e:00.0: HW Revision ID = 0x0
[    2.571375] iwlagn 0000:0e:00.0: pci_enable_msi failed
[    2.571431] iwlagn 0000:0e:00.0: PCI INT A disabled
[    2.575598] iwlagn: probe of 0000:0e:00.0 failed with error -1

The problem was initially reported here:

	https://lkml.org/lkml/2011/10/26/314

but the fix was never marked for stable.

Thanks,
Johan

#1 lore raw
Quoted 6 lines · Johan Hovold

Hi Greg,

I believe commit 63665158282dd3b5d70 (iwlwifi: allow pci_enable_msi fail) needs to be added to the 3.1 stable tree as the driver fails to probe with MSI disabled since commit 084dd79172cb3 (iwlagn: move PCI related operations from probe and remove to PCI layer) without it:

I do not see commit 63665158282dd3b5d70 in Linus's tree, did you get it incorrect?

confused,

greg k-h

#2 lore raw
Quoted 8 lines · Greg KH
Quoted 6 lines · Johan Hovold

Hi Greg,

I believe commit 63665158282dd3b5d70 (iwlwifi: allow pci_enable_msi fail) needs to be added to the 3.1 stable tree as the driver fails to probe with MSI disabled since commit 084dd79172cb3 (iwlagn: move PCI related operations from probe and remove to PCI layer) without it:

Quoted 5 lines

I do not see commit 63665158282dd3b5d70 in Linus's tree, did you get it incorrect?

confused,

it is commit#8a39ef8ba0fa0410d71db8e981e887fe4fdeca88 in Linville's wireless tree

Thanks
Wey

#3 lore raw
Quoted 9 lines · Wey-Yi
Quoted 8 lines · Greg KH
Quoted 6 lines · Johan Hovold

Hi Greg,

I believe commit 63665158282dd3b5d70 (iwlwifi: allow pci_enable_msi fail) needs to be added to the 3.1 stable tree as the driver fails to probe with MSI disabled since commit 084dd79172cb3 (iwlagn: move PCI related operations from probe and remove to PCI layer) without it:

Quoted 7 lines
Quoted 5 lines

I do not see commit 63665158282dd3b5d70 in Linus's tree, did you get it incorrect?

confused,

it is commit#8a39ef8ba0fa0410d71db8e981e887fe4fdeca88 in Linville's wireless tree

How nice, and what exactly can I do with that at this point in time?

{sigh}

Come on, please go read Documentation/stable_kernel_rules.txt again for how to do this properly...

greg k-h

#4 lore raw

Hi Greg,

Quoted 13 lines · Greg KH
Quoted 12 lines · Wey-Yi
Quoted 11 lines · Greg KH
Quoted 6 lines · Johan Hovold

Hi Greg,

I believe commit 63665158282dd3b5d70 (iwlwifi: allow pci_enable_msi fail) needs to be added to the 3.1 stable tree as the driver fails to probe with MSI disabled since commit 084dd79172cb3 (iwlagn: move PCI related operations from probe and remove to PCI layer) without it:

I do not see commit 63665158282dd3b5d70 in Linus's tree, did you get it incorrect?

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

confused,

it is commit#8a39ef8ba0fa0410d71db8e981e887fe4fdeca88 in Linville's wireless tree

How nice, and what exactly can I do with that at this point in time?

Can I send the patch to you for stable 3.1?

Quoted 4 lines

Come on, please go read Documentation/stable_kernel_rules.txt again for how to do this properly...

Sorry, my mistake and did not realize the offending patch is in 3.1 already.

Wey

#5 lore raw
Quoted 16 lines · Wey-Yi

Hi Greg,

Quoted 13 lines · Greg KH
Quoted 12 lines · Wey-Yi
Quoted 11 lines · Greg KH
Quoted 6 lines · Johan Hovold

Hi Greg,

I believe commit 63665158282dd3b5d70 (iwlwifi: allow pci_enable_msi fail) needs to be added to the 3.1 stable tree as the driver fails to probe with MSI disabled since commit 084dd79172cb3 (iwlagn: move PCI related operations from probe and remove to PCI layer) without it:

I do not see commit 63665158282dd3b5d70 in Linus's tree, did you get it incorrect?

Quoted 8 lines
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

confused,

it is commit#8a39ef8ba0fa0410d71db8e981e887fe4fdeca88 in Linville's wireless tree

How nice, and what exactly can I do with that at this point in time?

Can I send the patch to you for stable 3.1?

Again:

Quoted 2 lines
Quoted 2 lines

Come on, please go read Documentation/stable_kernel_rules.txt again for how to do this properly...

Please read that and see _HOW_ to do this, and what the requirements are.

greg k-h

author
#6 lore raw
In reply to Greg KH
Quoted 10 lines · Greg KH
Quoted 6 lines · Johan Hovold

Hi Greg,

I believe commit 63665158282dd3b5d70 (iwlwifi: allow pci_enable_msi fail) needs to be added to the 3.1 stable tree as the driver fails to probe with MSI disabled since commit 084dd79172cb3 (iwlagn: move PCI related operations from probe and remove to PCI layer) without it:

I do not see commit 63665158282dd3b5d70 in Linus's tree, did you get it incorrect?

Yes, that should have been 8a39ef8ba0fa0410d71db8e981e887fe4fdeca88 in Linus' tree.

Sorry about the confusion,
Johan