Skip to contentSkip to conversation

asoc: sst_platform: fix the dsp driver interface

PATCH Superseded Vinod Koul 2 participants 5 messages Dec 5, 2011

Subsystems (2)
lore
Share & tools
lore

Vinod Koul

author
#0 lore raw

PATCH 1/1 asoc: sst_platform: fix the dsp driver interface

lower level drivers typically register with upper layers. So fix by exporting symbols from sst_platform driver for dsp driver to register to sst platform driver

Now this driver doesnt depend on sst driver, so remove the dependency and the header files

---
 sound/soc/mid-x86/Kconfig        |    1 -
 sound/soc/mid-x86/sst_platform.c |  130 ++++++++++++++++++++++++--------------
 sound/soc/mid-x86/sst_platform.h |   82 ++++++++++++++++++++++--
 3 files changed, 158 insertions(+), 55 deletions(-)
sound/soc/mid-x86/Kconfig +0 -1
index 2935042..61c10bf 100644
@@ -1,7 +1,6 @@
 config SND_MFLD_MACHINE
 	tristate "SOC Machine Audio driver for Intel Medfield MID platform"
 	depends on INTEL_SCU_IPC
-	depends on SND_INTEL_SST
 	select SND_SOC_SN95031
 	select SND_SST_PLATFORM
 	help
sound/soc/mid-x86/sst_platform.c +83 -47

216 lines not on this page · raw message

sound/soc/mid-x86/sst_platform.h +75 -7

93 lines not on this page · raw message

Signature · 1 line
1.7.0.4
#1 lore raw
Quoted 6 lines · Vinod Koul

lower level drivers typically register with upper layers. So fix by exporting symbols from sst_platform driver for dsp driver to register to sst platform driver

Now this driver doesnt depend on sst driver, so remove the dependency and the header files

The doesn't apply to 3.3 due to a conflict with the conversion to module_platform_driver - you could please respin against current -next?

author
#2 lore raw
Quoted 10 lines · Mark Brown
Quoted 6 lines · Vinod Koul

lower level drivers typically register with upper layers. So fix by exporting symbols from sst_platform driver for dsp driver to register to sst platform driver

Now this driver doesnt depend on sst driver, so remove the dependency and the header files

The doesn't apply to 3.3 due to a conflict with the conversion to module_platform_driver - you could please respin against current -next?

Ah my bad. I had done sync sometime back and didn't pull as I was thinking nothig else changed in this. Obvisly I missed the platform driver patch.
I will send updated one...

Signature · 1 line
~Vinod
author
#3 lore raw

PATCH v2 1/1 asoc: sst_platform: fix the dsp driver interface

In reply to Vinod Koul

lower level drivers typically register with upper layers. So fix by exporting symbols from sst_platform driver for dsp driver to register to sst platform driver

Now this driver doesnt depend on sst driver, so remove the dependency and the header files

---
 sound/soc/mid-x86/Kconfig        |    1 -
 sound/soc/mid-x86/sst_platform.c |  130 ++++++++++++++++++++++++--------------
 sound/soc/mid-x86/sst_platform.h |   82 ++++++++++++++++++++++--
 3 files changed, 158 insertions(+), 55 deletions(-)
sound/soc/mid-x86/Kconfig +0 -1
index 2935042..61c10bf 100644
@@ -1,7 +1,6 @@
 config SND_MFLD_MACHINE
 	tristate "SOC Machine Audio driver for Intel Medfield MID platform"
 	depends on INTEL_SCU_IPC
-	depends on SND_INTEL_SST
 	select SND_SOC_SN95031
 	select SND_SST_PLATFORM
 	help
sound/soc/mid-x86/sst_platform.c +83 -47

216 lines not on this page · raw message

sound/soc/mid-x86/sst_platform.h +75 -7

93 lines not on this page · raw message

Signature · 1 line
1.7.0.4
Applied
#4 lore raw
Quoted 3 lines · Vinod Koul

lower level drivers typically register with upper layers. So fix by exporting symbols from sst_platform driver for dsp driver to register to sst platform driver

Applied, thanks.