Skip to contentSkip to conversation

UAS Gadget Driver.

PATCH In review Shimrit Malichi 6 participants 9 messages Dec 4, 2011 – Dec 21, 2011 2 messages not in the archive Arm Qualcomm mailing list

lore
Share & tools
lore
#0 lore raw

v4 cover UAS Gadget Driver.

This patch series implements the UAS gadget driver.

It has been tested using the following:
1. Linux UAS host driver
2. Internaly developed unittests framework

The device is functional. More stress tests are needed.

TODO: Further testing
De-register the gadget if the main thread dies.

Shimrit Malichi (3):
uas: MS UAS Gadget driver - Infrastructure
uas: MS UAS Gadget driver - Implementation
uas: Supporting UAS and BOT configuration.

 drivers/usb/gadget/f_mass_storage.c |   66 +-
 drivers/usb/gadget/f_uasp.c         | 2583 +++++++++++++++++++++++++++++++++++
 drivers/usb/gadget/f_uasp.h         |  524 +++++++
 drivers/usb/gadget/mass_storage.c   |   75 +-
 drivers/usb/gadget/storage_common.c |   90 ++-
 drivers/usb/gadget/uasp_cmdiu.c     | 1898 +++++++++++++++++++++++++
 drivers/usb/gadget/uasp_tmiu.c      |  528 +++++++
 7 files changed, 5687 insertions(+), 77 deletions(-)
 create mode 100644 drivers/usb/gadget/f_uasp.c
 create mode 100644 drivers/usb/gadget/f_uasp.h
 create mode 100644 drivers/usb/gadget/uasp_cmdiu.c
 create mode 100644 drivers/usb/gadget/uasp_tmiu.c
Signature · 8 lines
1.7.6
--
Sent by a Consultant for Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 1323029894-16106-1-git-send-email-smalichi-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org

#2 lore raw
Quoted 10 lines · Shimrit Malichi

This patch series implements the UAS gadget driver.

It has been tested using the following:
1. Linux UAS host driver
2. Internaly developed unittests framework

The device is functional. More stress tests are needed.

TODO: Further testing
De-register the gadget if the main thread dies.

What about all of the review comments you seem to be ignoring that have been made for this driver in the past?

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#3 lore raw
Quoted 10 lines · Shimrit Malichi
Quoted 8 lines

This patch series implements the UAS gadget driver.

It has been tested using the following:
1. Linux UAS host driver
2. Internaly developed unittests framework

The device is functional. More stress tests are needed.

Quoted 8 lines
Quoted 2 lines

TODO: Further testing
De-register the gadget if the main thread dies.

What about all of the review comments you seem to be ignoring that have been made for this driver in the past?

greg k-h

We addressed most of the comments. One of them was indeed to use the target framework, however when we asked an additional information about how to use this framework we didn't get a detailed reply. Sebastian gave an answer on how to use it yesterday. We will study his answer, and come up with a new code.

Thanks,
Shimrit

Signature · 2 lines
Consultant for Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum
#4 lore raw
Quoted 16 lines · Shimrit Malichi
Quoted 16 lines · Shimrit Malichi
Quoted 10 lines

This patch series implements the UAS gadget driver.

It has been tested using the following:
1. Linux UAS host driver
2. Internaly developed unittests framework

The device is functional. More stress tests are needed.

TODO: Further testing
De-register the gadget if the main thread dies.

What about all of the review comments you seem to be ignoring that have been made for this driver in the past?

Quoted 7 lines
Quoted 2 lines

greg k-h

We addressed most of the comments. One of them was indeed to use the target framework, however when we asked an additional information about how to use this framework we didn't get a detailed reply. Sebastian gave an answer on how to use it yesterday. We will study his answer, and come up with a new code.

No one is going to normally give you such a detailed answer as he did. You were told to go use that interface, and Sebastian did just that, why couldn't you have done that in the first place, saving you, and everyone else here, time and effort of telling you to go do that again?

greg k-h

#5 lore raw
Quoted 25 lines · Greg KH
Quoted 16 lines · Shimrit Malichi
Quoted 16 lines · Shimrit Malichi
Quoted 10 lines

This patch series implements the UAS gadget driver.

It has been tested using the following:
1. Linux UAS host driver
2. Internaly developed unittests framework

The device is functional. More stress tests are needed.

TODO: Further testing
De-register the gadget if the main thread dies.

What about all of the review comments you seem to be ignoring that have been made for this driver in the past?

Quoted 7 lines
Quoted 2 lines

greg k-h

We addressed most of the comments. One of them was indeed to use the target framework, however when we asked an additional information about how to use this framework we didn't get a detailed reply. Sebastian gave an answer on how to use it yesterday. We will study his answer, and come up with a new code.

Quoted 4 lines

No one is going to normally give you such a detailed answer as he did. You were told to go use that interface, and Sebastian did just that, why couldn't you have done that in the first place, saving you, and everyone else here, time and effort of telling you to go do that again?

other than that, it's just waste of time if you go write new code, now that Sebastian already has that almost ready. Save yourself sometime and just help Sebastian finishing what he's already done. Even testing is welcome at this stage.

Signature · 1 line
balbi
#6 lore raw
Quoted 36 lines · Greg KH
Quoted 25 lines · Shimrit Malichi
Quoted 8 lines
Quoted 8 lines · Shimrit Malichi
Quoted 6 lines

This patch series implements the UAS gadget driver.

It has been tested using the following:
1. Linux UAS host driver
2. Internaly developed unittests framework

Quoted 6 lines
Quoted 6 lines
Quoted 4 lines

The device is functional. More stress tests are needed.

TODO: Further testing
De-register the gadget if the main thread dies.

What about all of the review comments you seem to be ignoring that

have

Quoted 6 lines
Quoted 4 lines

been made for this driver in the past?

greg k-h

We addressed most of the comments. One of them was indeed to use the target framework, however when we asked an additional information

about

Quoted 1 line

how to use this framework we didn't get a detailed reply. Sebastian

gave

Quoted 8 lines
Quoted 1 line

an answer on how to use it yesterday. We will study his answer, and

come

Quoted 1 line

up with a new code.

No one is going to normally give you such a detailed answer as he did. You were told to go use that interface, and Sebastian did just that, why couldn't you have done that in the first place, saving you, and everyone else here, time and effort of telling you to go do that again?

Quoted 8 lines

other than that, it's just waste of time if you go write new code, now that Sebastian already has that almost ready. Save yourself sometime and just help Sebastian finishing what he's already done. Even testing is welcome at this stage.

--
balbi

Hi guys,

Thanks for all your inputs. The good thing is that we now have a better understanding of the UASP implementation that was done offline, and as balbi mentioned, probably avoid duplicate work.
We will coordinate with Sebastian regarding the next phases.

Shimrit

Signature · 2 lines
Consultant for Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum

A message that is not in the archive (sent off-list or not yet received): dbceef1c27984ec023a409618d25504c.squirrel-mMfbam+mt9083fI46fginR2eb7JE58TQ@public.gmane.org

#8 lore raw
Quoted 2 lines · * Shimrit Malichi | 2011-12-07 09:34:33 [-0800]:

Hi guys,

Hi,

Quoted 4 lines

Thanks for all your inputs. The good thing is that we now have a better understanding of the UASP implementation that was done offline, and as balbi mentioned, probably avoid duplicate work.
We will coordinate with Sebastian regarding the next phases.

Just posted RFC of something that works at HS. It was tested against dummy_hcd so nobody is required to use real hardware :)

Quoted 1 line

Shimrit

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#9 lore raw
Quoted 14 lines · * Shimrit Malichi | 2011-12-07 09:34:33 [-0800]:
Quoted 3 lines

Hi guys,

Hi,

Quoted 4 lines

Thanks for all your inputs. The good thing is that we now have a better understanding of the UASP implementation that was done offline, and as balbi mentioned, probably avoid duplicate work.
We will coordinate with Sebastian regarding the next phases.

Just posted RFC of something that works at HS. It was tested against dummy_hcd so nobody is required to use real hardware :)

Quoted 8 lines
Quoted 1 line

Shimrit

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Hi Sebastian,

Thanks for the update. A big effort was indeed invested. Can you please share your future plans regarding UASP? are you planning to add super speed support as well?

Shimrit

Signature · 2 lines
Consultant for Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum
#10 lore raw

Hi,

Quoted 22 lines · Shimrit Malichi
Quoted 14 lines · * Shimrit Malichi | 2011-12-07 09:34:33 [-0800]:
Quoted 3 lines

Hi guys,

Hi,

Quoted 4 lines

Thanks for all your inputs. The good thing is that we now have a better understanding of the UASP implementation that was done offline, and as balbi mentioned, probably avoid duplicate work.
We will coordinate with Sebastian regarding the next phases.

Just posted RFC of something that works at HS. It was tested against dummy_hcd so nobody is required to use real hardware :)

Quoted 8 lines
Quoted 1 line

Shimrit

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Quoted 5 lines

Hi Sebastian,

Thanks for the update. A big effort was indeed invested. Can you please share your future plans regarding UASP? are you planning to add super speed support as well?

I can answer that. We are already working on adding superspeed support for target and together with it, proper streams support too.

It unlikely to make it for 3.3 though, but on 3.4 we might get it merged.

Signature · 1 line
balbi