PPC4xx: usbdev.c used at all?

U-Boot Stefan Roese 5 participants 9 messages Nov 17, 2011 – Dec 7, 2011

Share & tools

Stefan Roese

author

2011-11-17 14:04 UTC #0 lore raw

Hi Marri,

I just "touched" the file "arch/powerpc/cpu/ppc4xx/usbdev.c" again to remove some GCC 4.6 compiler warnings. While doing this I wondered (again) if anybody is using this "driver" at all. I definitely never did. And I'm wondering if this code is useful at all.

So Marri (or anybody else): Do you need this driver in U-Boot?

If not, I'll just remove it in a short while.

Thanks.

Best regards,
Stefan

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de

Matthias Fuchs

2011-11-17 14:34 UTC #1 lore raw

We do not use it or plan to use it.

Matthias

Quoted 16 lines · Stefan Roese

Hi Marri,
I just "touched" the file "arch/powerpc/cpu/ppc4xx/usbdev.c" again to remove some GCC 4.6 compiler warnings. While doing this I wondered (again) if anybody is using this "driver" at all. I definitely never did. And I'm wondering if this code is useful at all.
So Marri (or anybody else): Do you need this driver in U-Boot?
If not, I'll just remove it in a short while.
Thanks.
Best regards,
Stefan

Tirumala Marri

2011-11-21 22:15 UTC #2 lore raw

In reply to Stefan Roese

Hi Stefan,

Quoted 9 lines

I just "touched" the file "arch/powerpc/cpu/ppc4xx/usbdev.c" again to remove
some GCC 4.6 compiler warnings. While doing this I wondered (again) if anybody
is using this "driver" at all. I definitely never did. And I'm wondering if
this code is useful at all.

Quoted 3 lines

So Marri (or anybody else): Do you need this driver in U-Boot?
If not, I'll just remove it in a short while.

This code is used when usb device is used as boot medium for Linux. Let me check what are the errors you are seeing.
Thanks,
Marri

Wolfgang Denk

2011-11-21 22:31 UTC #3 lore raw

Dear Tirumala Marri,

Quoted 2 lines · In message <[email protected]> you wrote:

This code is used when usb device is used as boot medium for Linux.

Which exact usage mode would that be, i. e. which hardware setup would you use in coimbination with which exact commands?

Quoted 1 line

Let me check what are the errors you are seeing.

Thanks.

Wolfgang Denk

Signature · 6 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Am I your nanny? The kernel is there to support  user  programs,  but
it's a _resource_ handler, not a baby feeder.     - Linus Torvalds in
      <[email protected]>

Stefan Roese

author

2011-11-22 05:49 UTC #4 lore raw

Hi Marri,

Quoted 4 lines · On Monday 21 November 2011 23:31:45 Wolfgang Denk wrote:

Quoted 1 line
This code is used when usb device is used as boot medium for Linux.
Which exact usage mode would that be, i. e. which hardware setup would you use in coimbination with which exact commands?

Yes, please explain in more detail what exactly you mean with "boot medium for Linux". How does this work?

Best regards,
Stefan

Rupjyoti Sarmah

2011-11-23 06:10 UTC #5 lore raw

In reply to Stefan Roese

Quoted 1 line

Quoted 1 line
I just "touched" the file "arch/powerpc/cpu/ppc4xx/usbdev.c" again to

remove

Quoted 1 line

Quoted 1 line
some GCC 4.6 compiler warnings. While doing this I wondered (again) if

anybody

Quoted 1 line

Quoted 1 line
is using this "driver" at all. I definitely never did. And I'm

wondering if

Quoted 1 line

Quoted 1 line
this code is useful at all.

Hi Stefan,

This driver is used by PPC440EP for usb 1.1.

Regards,
Rup

Stefan Roese

author

2011-11-23 07:09 UTC #6 lore raw

Hi Rup,

Quoted 1 line · On Wednesday 23 November 2011 07:10:37 Rupjyoti Sarmah wrote:

This driver is used by PPC440EP for usb 1.1.

Please explain this in more detail. I fail to see, how this driver could be of any used. I definitely never used it. So please explain how exactly you make use of this driver, or why it is needed?

Best regards,
Stefan

Stefan Roese

author

2011-12-01 08:15 UTC #7 lore raw

Hi Rup,

Quoted 6 lines · On Wednesday 23 November 2011 08:09:07 Stefan Roese wrote:

Quoted 1 line · On Wednesday 23 November 2011 07:10:37 Rupjyoti Sarmah wrote:
This driver is used by PPC440EP for usb 1.1.
Please explain this in more detail. I fail to see, how this driver could be of any used. I definitely never used it. So please explain how exactly you make use of this driver, or why it is needed?

Ping! This removal patch is still on my list. So please explain, or I will remove this "driver".

Thanks.

Best regards,
Stefan

Wolfgang Denk

2011-12-07 20:08 UTC #8 lore raw

Dear Stefan Roese,

Quoted 10 lines · In message <[email protected]> you wrote:

Quoted 7 lines · On Wednesday 23 November 2011 07:10:37 Rupjyoti Sarmah wrote:
Quoted 1 line
This driver is used by PPC440EP for usb 1.1.
Please explain this in more detail. I fail to see, how this driver could be of any used. I definitely never used it. So please explain how exactly you make use of this driver, or why it is needed?
Ping! This removal patch is still on my list. So please explain, or I will remove this "driver".

I'm not willing to wait any longer. I want to see these warnigns fixed.

I'll pull your patch directly.

Rup, if you can explain that this driver is needed,, then please feel free to submit a patch to re-add it - after cleaningup the warnings it cuases, that is.

Thanks.

Best regards,

Wolfgang Denk

Signature · 5 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I mean, I . . . think to understand you, I just don't know  what  you
are saying ...                        - Terry Pratchett, _Soul Music_