apparmor: add missing rcu_dereference()
Subsystems (2)
PATCH 1/1 apparmor: add missing rcu_dereference()
Adds a missed rcu_dereference() around real_parent.
Signed-off-by Kees Cook <[email protected]>
--- security/apparmor/audit.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
security/apparmor/audit.c +1 -1
@@ -133,7 +133,7 @@ static void audit_pre(struct audit_buffer *ab, void *ca)struct aa_profile *profile = sa->aad.profile;pid_t pid;rcu_read_lock (); - pid = tsk->real_parent->pid; + pid =rcu_dereference (tsk->real_parent)->pid;rcu_read_unlock ();audit_log_format (ab," parent=%d" , pid);if (profile->ns != root_ns) {
Signature · 1 line
1.7.0.4
Quoted 12 lines · Kees Cook
Adds a missed
rcu_dereference()aroundreal_parent.Signed-off-by Kees Cook <[email protected]>--- security/apparmor/audit.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)security/apparmor/audit.c +0
-0
security/apparmor/audit.c static void audit_pre(struct audit_buffer *ab, void *ca) · line 139
Quoted 8 lines
security/apparmor/audit.c +1
-1@@ -133,7 +133,7 @@ static void audit_pre(struct audit_buffer *ab, void *ca)struct aa_profile *profile = sa->aad.profile;pid_t pid;rcu_read_lock (); - pid = tsk->real_parent->pid; + pid =rcu_dereference (tsk->real_parent)->pid;rcu_read_unlock ();audit_log_format (ab," parent=%d" , pid);if (profile->ns != root_ns) {
yep.
Acked-by John Johansen <[email protected]>
James Morris
maintainerQuoted 2 lines · John Johansen
Quoted 1 line · Kees Cook
Adds a missed
rcu_dereference()aroundreal_parent.
Applied togit://selinuxproject.org/~jmorris/linux-security next
Signature · 2 lines
James Morris <[email protected]>