Skip to contentSkip to conversation

apparmor: add missing rcu_dereference()

PATCH In review Kees Cook 3 participants 3 messages Dec 9, 2011

Subsystems (2)
lore
Share & tools
lore

Kees Cook

author
#0 lore raw

PATCH 1/1 apparmor: add missing rcu_dereference()

Adds a missed rcu_dereference() around real_parent.

---
 security/apparmor/audit.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
security/apparmor/audit.c +1 -1
index 96502b2..f3fafed 100644
@@ -133,7 +133,7 @@ static void audit_pre(struct audit_buffer *ab, void *ca)
 		struct aa_profile *profile = sa->aad.profile;
 		pid_t pid;
 		rcu_read_lock();
-		pid = tsk->real_parent->pid;
+		pid = rcu_dereference(tsk->real_parent)->pid;
 		rcu_read_unlock();
 		audit_log_format(ab, " parent=%d", pid);
 		if (profile->ns != root_ns) {
Signature · 1 line
1.7.0.4
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 12 lines · Kees Cook

Adds a missed rcu_dereference() around real_parent.

---
 security/apparmor/audit.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
security/apparmor/audit.c +0 -0
index 96502b2..f3fafed 100644

security/apparmor/audit.c static void audit_pre(struct audit_buffer *ab, void *ca) · line 139

Quoted 8 lines
security/apparmor/audit.c +1 -1
@@ -133,7 +133,7 @@ static void audit_pre(struct audit_buffer *ab, void *ca)
 		struct aa_profile *profile = sa->aad.profile;
 		pid_t pid;
 		rcu_read_lock();
-		pid = tsk->real_parent->pid;
+		pid = rcu_dereference(tsk->real_parent)->pid;
 		rcu_read_unlock();
 		audit_log_format(ab, " parent=%d", pid);
 		if (profile->ns != root_ns) {

yep.

maintainer
#2 lore raw
Quoted 2 lines · John Johansen
Quoted 1 line · Kees Cook

Adds a missed rcu_dereference() around real_parent.

Applied to
git://selinuxproject.org/~jmorris/linux-security next

Signature · 2 lines
James Morris
<[email protected]>