Skip to contentSkip to conversation

OMAP2, 3: DSS2: Include linux/delay.h and common.h to fix build errors

PATCH In review Axel Lin 2 participants 2 messages Nov 30, 2011 – Dec 9, 2011

Subsystems (3)
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 OMAP2, 3: DSS2: Include linux/delay.h and common.h to fix build errors

Include linux/delay.h to fix below build error:

CC arch/arm/mach-omap2/display.o
arch/arm/mach-omap2/display.c: In function 'dispc_disable_outputs':
arch/arm/mach-omap2/display.c:283: error: implicit declaration of function 'mdelay' arch/arm/mach-omap2/display.c: In function 'omap_dss_reset':
arch/arm/mach-omap2/display.c:317: error: implicit declaration of function 'omap_test_timeout' make[1]: *** [arch/arm/mach-omap2/display.o] Error 1
make: *** [arch/arm/mach-omap2] Error 2

Include common.h to fix below build error:

CC arch/arm/mach-omap2/display.o
arch/arm/mach-omap2/display.c: In function 'omap_dss_reset':
arch/arm/mach-omap2/display.c:318: error: implicit declaration of function 'omap_test_timeout' make[1]: *** [arch/arm/mach-omap2/display.o] Error 1
make: *** [arch/arm/mach-omap2] Error 2

---
I got the build error on linux-next 20111130.
This patch is against linux-next 20111130.
Axel

 arch/arm/mach-omap2/display.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
arch/arm/mach-omap2/display.c +2 -0
index dce9905..fe44cc2 100644
@@ -21,6 +21,7 @@
 #include <linux/platform_device.h>
 #include <linux/io.h>
 #include <linux/clk.h>
+#include <linux/delay.h>
 #include <linux/err.h>
 
 #include <video/omapdss.h>
@@ -30,6 +31,7 @@
 #include <plat/common.h>
 
 #include "control.h"
+#include "common.h"
 #include "display.h"
 
 #define DISPC_CONTROL		0x0040
Signature · 1 line
1.7.5.4
maintainer
#1 lore raw
Quoted 18 lines · Axel Lin

Include linux/delay.h to fix below build error:

CC arch/arm/mach-omap2/display.o
arch/arm/mach-omap2/display.c: In function 'dispc_disable_outputs':
arch/arm/mach-omap2/display.c:283: error: implicit declaration of function 'mdelay' arch/arm/mach-omap2/display.c: In function 'omap_dss_reset':
arch/arm/mach-omap2/display.c:317: error: implicit declaration of function 'omap_test_timeout' make[1]: *** [arch/arm/mach-omap2/display.o] Error 1
make: *** [arch/arm/mach-omap2] Error 2

Include common.h to fix below build error:

CC arch/arm/mach-omap2/display.o
arch/arm/mach-omap2/display.c: In function 'omap_dss_reset':
arch/arm/mach-omap2/display.c:318: error: implicit declaration of function 'omap_test_timeout' make[1]: *** [arch/arm/mach-omap2/display.o] Error 1
make: *** [arch/arm/mach-omap2] Error 2

Quoted 5 lines

---
I got the build error on linux-next 20111130.
This patch is against linux-next 20111130.
Axel

Thanks we already have commit deee6d5359969a0ce4e2760cfd7b9f379bd5698a in Russell's devel-stable branch doing the same thing.

Regards,

Tony