Skip to contentSkip to conversation

Add new package libmbus Library for communicating with energy metering devices

PATCH New Sagaert Johan 3 participants 4 messages Dec 9, 2011

lore
Share & tools
lore

Sagaert Johan

author
#0 lore raw

PATCH 1/1 Add new package libmbus Library for communicating with energy metering devices

Signed-off-by Sagaert Johan <[email protected]>
---
 package/Config.in          |    1 +
 package/libmbus/Config.in  |    7 +++++++
 package/libmbus/libmbus.mk |   12 ++++++++++++
 3 files changed, 20 insertions(+), 0 deletions(-)
 create mode 100644 package/libmbus/Config.in
 create mode 100644 package/libmbus/libmbus.mk
package/Config.in +1 -0
index e949649..8f0b5ba 100644
@@ -330,6 +330,7 @@ source "package/libmicrohttpd/Config.in"
 source "package/neon/Config.in"
 source "package/libmnl/Config.in"
 source "package/libmodbus/Config.in"
+source "package/libmbus/Config.in"
 source "package/libnl/Config.in"
 source "package/libpcap/Config.in"
 source "package/libosip2/Config.in"
package/libmbus/Config.in new file +7 -0
new file mode 100644
index 0000000..93666ed
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_LIBMBUS
+	bool "libmbus"
+	help
+	  libmbus is a library for communicating with energie metering devices
+	  supports TCP and RS232 M-bus gateways.
+	  
+	  http://www.freescada.com/libmbus
package/libmbus/libmbus.mk new file +12 -0
new file mode 100644
index 0000000..a57595e
@@ -0,0 +1,12 @@
+#############################################################
+#
+# libmbus
+#
+#############################################################
+LIBMBUS_VERSION:=0.6.1
+LIBMBUS_SOURCE:=libmbus-$(LIBMBUS_VERSION).tar.gz
+LIBMBUS_SITE:=http://www.freescada.com/public-dist/
+LIBMBUS_INSTALL_STAGING=YES
+LIBMBUS_AUTORECONF=YES
+
+$(eval $(call AUTOTARGETS))
Signature · 1 line
1.7.8-rc3
#1 lore raw

PATCH 1/1 Add new package libmbus Library for communicating with energy metering devices

Quoted 28 lines · Sagaert Johan
Signed-off-by Sagaert Johan<[email protected]>
---
  package/Config.in          |    1 +
  package/libmbus/Config.in  |    7 +++++++
  package/libmbus/libmbus.mk |   12 ++++++++++++
  3 files changed, 20 insertions(+), 0 deletions(-)

create mode 100644 package/libmbus/Config.in
create mode 100644 package/libmbus/libmbus.mk

package/Config.in +1 -0
index e949649..8f0b5ba 100644
@@ -330,6 +330,7 @@ source "package/libmicrohttpd/Config.in"
  source "package/neon/Config.in"
  source "package/libmnl/Config.in"
  source "package/libmodbus/Config.in"
+source "package/libmbus/Config.in"
  source "package/libnl/Config.in"
  source "package/libpcap/Config.in"
  source "package/libosip2/Config.in"
package/libmbus/Config.in new file +0 -0
new file mode 100644
index 0000000..93666ed

package/libmbus/Config.in line 5

Quoted 5 lines
package/libmbus/Config.in new file +5 -0
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_LIBMBUS
+	bool "libmbus"
+	help
+	  libmbus is a library for communicating with energie metering devices
+	  supports TCP and RS232 M-bus gateways.

s/energie/energy/

I'd also reword this way:
libmbus is a library for communicating with energy metering devices. It supports TCP and RS232 M-bus gateways.

Quoted 8 lines
package/libmbus/Config.in new file +2 -0
+	
+	  http://www.freescada.com/libmbus
package/libmbus/libmbus.mk new file +0 -0
new file mode 100644
index 0000000..a57595e

package/libmbus/libmbus.mk line 7

Quoted 7 lines
package/libmbus/libmbus.mk new file +7 -0
@@ -0,0 +1,12 @@
+#############################################################
+#
+# libmbus
+#
+#############################################################
+LIBMBUS_VERSION:=0.6.1
+LIBMBUS_SOURCE:=libmbus-$(LIBMBUS_VERSION).tar.gz

This should be removed, as it's equal to Buildroot's default. Search
for LIBFOO_SOURCE in the docs and you'll read:
If none are specified, then the value is assumed to be packagename-$(LIBFOO_VERSION).tar.gz

package/libmbus/libmbus.mk line 10

Quoted 3 lines
package/libmbus/libmbus.mk new file +3 -0
+LIBMBUS_SITE:=http://www.freescada.com/public-dist/
+LIBMBUS_INSTALL_STAGING=YES
+LIBMBUS_AUTORECONF=YES

Why is this line needed? The downloaded tarball already contains a configure script. If there's a specific reason that is not obvious, then you should add a line of comment.

Luca

author
#2 lore raw

PATCH 1/1 Add new package libmbus Library for communicating with energy metering devices

Hi

LIBMBUS_AUTORECONF=YES is needed because without it the build yields an error : 'test/Makefile.in' not found .

-----Oorspronkelijk bericht-----
Van: Luca Ceresoli [mailto:luca at lucaceresoli.net]
Verzonden: vrijdag 9 december 2011 15:32
Aan: Sagaert Johan
CC: buildroot at busybox.net
Onderwerp: Re: [Buildroot] [PATCH] Add new package libmbus Library for communicating with energy metering devices

Quoted 28 lines · Sagaert Johan
Signed-off-by Sagaert Johan<[email protected]>
---
  package/Config.in          |    1 +
  package/libmbus/Config.in  |    7 +++++++
  package/libmbus/libmbus.mk |   12 ++++++++++++
  3 files changed, 20 insertions(+), 0 deletions(-)

create mode 100644 package/libmbus/Config.in
create mode 100644 package/libmbus/libmbus.mk

package/Config.in +1 -0
index e949649..8f0b5ba 100644
@@ -330,6 +330,7 @@ source "package/libmicrohttpd/Config.in"
  source "package/neon/Config.in"
  source "package/libmnl/Config.in"
  source "package/libmodbus/Config.in"
+source "package/libmbus/Config.in"
  source "package/libnl/Config.in"
  source "package/libpcap/Config.in"
  source "package/libosip2/Config.in"
package/libmbus/Config.in new file +0 -0
new file mode 100644
index 0000000..93666ed

package/libmbus/Config.in line 4

Quoted 4 lines
package/libmbus/Config.in new file +4 -0
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_LIBMBUS
+	bool "libmbus"
+	help
+	  libmbus is a library for communicating with energie metering

devices

package/libmbus/Config.in line 5

Quoted 1 line
package/libmbus/Config.in new file +1 -0
+	  supports TCP and RS232 M-bus gateways.

s/energie/energy/

I'd also reword this way:
libmbus is a library for communicating with energy metering devices. It supports TCP and RS232 M-bus gateways.

Quoted 8 lines
package/libmbus/Config.in new file +2 -0
+	
+	  http://www.freescada.com/libmbus
package/libmbus/libmbus.mk new file +0 -0
new file mode 100644
index 0000000..a57595e

package/libmbus/libmbus.mk line 7

Quoted 7 lines
package/libmbus/libmbus.mk new file +7 -0
@@ -0,0 +1,12 @@
+#############################################################
+#
+# libmbus
+#
+#############################################################
+LIBMBUS_VERSION:=0.6.1
+LIBMBUS_SOURCE:=libmbus-$(LIBMBUS_VERSION).tar.gz

This should be removed, as it's equal to Buildroot's default. Search
for LIBFOO_SOURCE in the docs and you'll read:
If none are specified, then the value is assumed to be packagename-$(LIBFOO_VERSION).tar.gz

package/libmbus/libmbus.mk line 10

Quoted 3 lines
package/libmbus/libmbus.mk new file +3 -0
+LIBMBUS_SITE:=http://www.freescada.com/public-dist/
+LIBMBUS_INSTALL_STAGING=YES
+LIBMBUS_AUTORECONF=YES

Why is this line needed? The downloaded tarball already contains a configure script. If there's a specific reason that is not obvious, then you should add a line of comment.

Luca

#3 lore raw

PATCH 1/1 Add new package libmbus Library for communicating with energy metering devices

In reply to Sagaert Johan

Le Fri, 9 Dec 2011 13:39:36 +0100,
Sagaert Johan <[email protected]> a ?crit :

package/libmbus/libmbus.mk line 8

Quoted 3 lines
package/libmbus/libmbus.mk new file +3 -0
+LIBMBUS_VERSION:=0.6.1
+LIBMBUS_SOURCE:=libmbus-$(LIBMBUS_VERSION).tar.gz
+LIBMBUS_SITE:=http://www.freescada.com/public-dist/

'=' signs should be used instead of ':=' signs.

Regards,

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com