ARM: provide XIP_VIRT_ADDR for no-MMU builds
PATCH 1/1 ARM: provide XIP_VIRT_ADDR for no-MMU builds
--- arch/arm/include/asm/memory.h | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
arch/arm/include/asm/memory.h +2 -0
@@ -116,6 +116,8 @@#define MODULES_END (END_MEM)#define MODULES_VADDR (PHYS_OFFSET) +#define XIP_VIRT_ADDR (physaddr) (physaddr) +#endif /* !CONFIG_MMU */ /*
Signature · 1 line
1.7.7.3
PATCH 1/1 ARM: provide XIP_VIRT_ADDR for no-MMU builds
Quoted 1 line · Uwe Kleine-K?nig
Signed-off-by Uwe Kleine-K?nig <[email protected]>
Quoted 26 lines
--- arch/arm/include/asm/memory.h | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)arch/arm/include/asm/memory.h +2
-0@@ -116,6 +116,8 @@#define MODULES_END (END_MEM)#define MODULES_VADDR (PHYS_OFFSET) +#define XIP_VIRT_ADDR (physaddr) (physaddr) +#endif /* !CONFIG_MMU */ /* Signature · 7 lines
1.7.7.3 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel at lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
PATCH 1/1 ARM: provide XIP_VIRT_ADDR for no-MMU builds
In reply to Uwe Kleine-KönigQuoted 1 line · Uwe Kleine-K?nig
Signed-off-by Uwe Kleine-K?nig <[email protected]>
Lack of changelog. Say why this change is required.
Quoted 25 lines
--- arch/arm/include/asm/memory.h | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)arch/arm/include/asm/memory.h +2
-0@@ -116,6 +116,8 @@#define MODULES_END (END_MEM)#define MODULES_VADDR (PHYS_OFFSET) +#define XIP_VIRT_ADDR (physaddr) (physaddr) +#endif /* !CONFIG_MMU */ /* Signature · 7 lines
1.7.7.3 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel at lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
PATCH 1/1 ARM: provide XIP_VIRT_ADDR for no-MMU builds
Quoted 4 lines · Russell King - ARM Linux
Quoted 1 line · Uwe Kleine-K?nig
Signed-off-by Uwe Kleine-K?nig <[email protected]>Lack of changelog. Say why this change is required.
Something like:
XIP_VIRT_ADDR is needed for XIP builds and currently only defined for builds with CONFIG_MMU.
Also provide it for no-MMU builds to make it possible to build an XIP kernel for MMU-less machines. As these lack an MMU it has to be an identity mapping.
?
Best regards
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |
PATCH 1/1 ARM: provide XIP_VIRT_ADDR for no-MMU builds
Quoted 5 lines · Uwe Kleine-K?nig
Quoted 4 lines · Russell King - ARM Linux
Quoted 1 line · Uwe Kleine-K?nig
Signed-off-by Uwe Kleine-K?nig <[email protected]>Lack of changelog. Say why this change is required.
Quoted 8 lines
Something like:
XIP_VIRT_ADDRis needed for XIP builds and currently only defined for builds withCONFIG_MMU.Also provide it for no-MMU builds to make it possible to build an XIP kernel for MMU-less machines. As these lack an MMU it has to be an identity mapping.
You seem to be saying from the above that this is required also for non-XIP kernel builds as well as XIP kernel builds. That sounds wrong - XIP_VIRT_ADDR is only required for XIP kernel builds. Use outside of that would be a bug.
Please clarify.
(And this illustrates why it is very important to give an explanation of changes.)
PATCH 1/1 ARM: provide XIP_VIRT_ADDR for no-MMU builds
Hi Russell,
Quoted 15 lines · Russell King - ARM Linux
Quoted 5 lines · Uwe Kleine-K?nig
Quoted 4 lines · Russell King - ARM Linux
Quoted 1 line · Uwe Kleine-K?nig
Signed-off-by Uwe Kleine-K?nig <[email protected]>Lack of changelog. Say why this change is required.
Quoted 8 lines
Something like:
XIP_VIRT_ADDRis needed for XIP builds and currently only defined for builds withCONFIG_MMU.Also provide it for no-MMU builds to make it possible to build an XIP kernel for MMU-less machines. As these lack an MMU it has to be an identity mapping.
Quoted 6 lines
You seem to be saying from the above that this is required also for non-XIP kernel builds as well as XIP kernel builds. That sounds wrong -
XIP_VIRT_ADDRis only required for XIP kernel builds. Use outside of that would be a bug.Please clarify.
After rereading my changelog a few times I don't see where I suggest that XIP_VIRT_ADDR is needed for non-XIP builds. Can you please be a bit more concrete?
Thanks
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |