New Package libmbus library for communicating with M-bus devices.(rework)
PATCH 1/1 New Package libmbus library for communicating with M-bus devices.(rework)
--- package/Config.in | 1 + package/libmbus/Config.in | 8 ++++++++ package/libmbus/libmbus.mk | 15 +++++++++++++++ 3 files changed, 24 insertions(+), 0 deletions(-) create mode 100644 package/libmbus/Config.in create mode 100644 package/libmbus/libmbus.mk
package/Config.in +1 -0
@@ -330,6 +330,7 @@ source "package/libmicrohttpd/Config.in" source "package/neon/Config.in" source "package/libmnl/Config.in" source "package/libmodbus/Config.in" +source "package/libmbus/Config.in" source "package/libnl/Config.in" source "package/libpcap/Config.in" source "package/libosip2/Config.in"
package/libmbus/Config.in new file +8 -0
@@ -0,0 +1,8 @@ +config BR2_PACKAGE_LIBMBUS + bool "libmbus" + help + libmbus is a library for communicating with energy metering devices. + It supports TCP and RS232 M-bus gateways. + ( M-bus standard : http://www.m-bus.com/ ) + + http://www.freescada.com/libmbus
package/libmbus/libmbus.mk new file +15 -0
@@ -0,0 +1,15 @@ +############################################################# +# +# libmbus +# +############################################################# +LIBMBUS_VERSION:=0.6.1 +LIBMBUS_SOURCE:=libmbus-$(LIBMBUS_VERSION).tar.gz +LIBMBUS_SITE:=http://www.freescada.com/public-dist/ +LIBMBUS_INSTALL_STAGING=YES + +# Without this the build yields an error: +# cannot find input file: `test/Makefile.in' +LIBMBUS_AUTORECONF=YES + +$(eval $(call AUTOTARGETS))
Signature · 1 line
1.7.8
PATCH 1/1 New Package libmbus library for communicating with M-bus devices.(rework)
Hello,
You forgot your Signed-off-by line, which is mandatory.
Le Sat, 10 Dec 2011 01:48:00 +0100,
Sagaert Johan <[email protected]> a ?crit :
package/libmbus/Config.in line 6
Quoted 8 lines
+++ b/package/libmbus/Config.in
package/libmbus/Config.in new file +6
-0@@ -0,0 +1,8 @@ +config BR2_PACKAGE_LIBMBUS + bool "libmbus" + help + libmbus is a library for communicating with energy metering devices. + It supports TCP and RS232 M-bus gateways. + ( M-bus standard : http://www.m-bus.com/ )
Remove space after ( and before ).
package/libmbus/libmbus.mk line 6
Quoted 1 line
package/libmbus/libmbus.mk new file +1
-0+LIBMBUS_VERSION:=0.6.1
= instead of :=
package/libmbus/libmbus.mk line 7
Quoted 1 line
package/libmbus/libmbus.mk new file +1
-0+LIBMBUS_SOURCE:=libmbus-$(LIBMBUS_VERSION).tar.gz
Not needed, that's the default.
Quoted 1 line
+LIBMBUS_SITE:=http://www.freescada.com/public-dist/
= instead of :=
Thomas
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
A message that is not in the archive (sent off-list or not yet received): 8C82EF97265D4A6DA5ED238B24FD8DC0@JohanW7
PATCH 1/1 New Package libmbus library for communicating with M-bus devices.(rework)
Hello Johan,
Please keep the Buildroot list Cc'ed.
Le Sat, 10 Dec 2011 18:26:31 +0100, "Sagaert Johan" <[email protected]> a ?crit :
Quoted 4 lines
Yes, i just saw it, I started using git only since last week, and I used
--signed-off instead of --signoff. Still need to learn a lot and do some
tuning in the .gitconfig file. Will create some script so I don't forget any mandatory options.
No problem. Don't worry if everything is not perfect the first time:
that's why we have code review. Even experienced developers don't always get everything right.
Quoted 3 lines
One more question: is it OK to comment in the xxx.mk files ? (I have a libcgi patch and i included a comment line why I added the AUTORECONF option.)
Yes, it is perfectly ok, and even better, in your case, I think it was a very good idea. Having _AUTORECONF=YES is strange when no patch is changing the configure.ac or Makefile.in files, so having a short comment justifying the usage of _AUTORECONF=YES is welcome.
Quoted 1 line
I use qgit and smartgit gui-clients, do you suggest something better ?)
I do all my git stuff using the git command line utility, and I've never tried any of the graphical stuff for git (except gitk for pure visualization of git history).
Best regards,
Thomas
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com