Skip to contentSkip to conversation

Add PCI IDs for Motorola H24 HSPA USB module.

PATCH In review Krzysztof Hałasa 3 participants 4 messages Dec 12, 2011 – Dec 13, 2011

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Add PCI IDs for Motorola H24 HSPA USB module.

Add PCI IDs for Motorola H24 HSPA USB module.

drivers/usb/class/cdc-acm.c +10 -0
@@ -1458,6 +1458,16 @@ static const struct usb_device_id acm_ids[] = {
 	},
 	{ USB_DEVICE(0x22b8, 0x6425), /* Motorola MOTOMAGX phones */
 	},
+	/* Motorola H24 HSPA module: */
+	{ USB_DEVICE(0x22b8, 0x2d91) }, /* modem                                */
+	{ USB_DEVICE(0x22b8, 0x2d92) }, /* modem           + diagnostics        */
+	{ USB_DEVICE(0x22b8, 0x2d93) }, /* modem + AT port                      */
+	{ USB_DEVICE(0x22b8, 0x2d95) }, /* modem + AT port + diagnostics        */
+	{ USB_DEVICE(0x22b8, 0x2d96) }, /* modem                         + NMEA */
+	{ USB_DEVICE(0x22b8, 0x2d97) }, /* modem           + diagnostics + NMEA */
+	{ USB_DEVICE(0x22b8, 0x2d99) }, /* modem + AT port               + NMEA */
+	{ USB_DEVICE(0x22b8, 0x2d9a) }, /* modem + AT port + diagnostics + NMEA */
+
 	{ USB_DEVICE(0x0572, 0x1329), /* Hummingbird huc56s (Conexant) */
 	.driver_info = NO_UNION_NORMAL, /* union descriptor misplaced on
 					   data interface instead of
Signature · 4 lines
Krzysztof Halasa

Research Institute for Automation and Measurements
Al. Jerozolimskie 202, 02-486 Warsaw, Poland
#1 lore raw

Am Montag, 12. Dezember 2011, 14:10:23 schrieb Krzysztof Hałasa:

Quoted 3 lines

Add PCI IDs for Motorola H24 HSPA USB module.

Why does it need so many IDs?
Also please send to linux-usb, not lkml.

Regards
Oliver

#2 lore raw
Quoted 3 lines · Oliver Neukum
Quoted 1 line

Add PCI IDs for Motorola H24 HSPA USB module.

Why does it need so many IDs?

It has several configurations, each with a different ID.

Quoted 1 line

Also please send to linux-usb, not lkml.

Will send a copy.

Signature · 4 lines
Krzysztof Halasa

Research Institute for Automation and Measurements
Al. Jerozolimskie 202, 02-486 Warsaw, Poland
#3 lore raw
In reply to Krzysztof Hałasa

drivers/usb/class/cdc-acm.c static const struct usb_device_id acm_ids[] = { · line 1461

Quoted 11 lines · Krzysztof Hałasa

Add PCI IDs for Motorola H24 HSPA USB module.

drivers/usb/class/cdc-acm.c +1 -0
@@ -1458,6 +1458,16 @@ static const struct usb_device_id acm_ids[] = {
 	},
 	{ USB_DEVICE(0x22b8, 0x6425), /* Motorola MOTOMAGX phones */
 	},
+	/* Motorola H24 HSPA module: */

AFAIK, Motorola's M2M division was acquired by Telit in March 2011, so now those devices are called Telit H24. Can you please add note about that so readers can understand that this code applies or Telit H24 too?

Signature · 1 line
Best regards, Denis Kuzmenko.