Skip to contentSkip to conversation

tm6000: rewrite IR support

media Dan Carpenter 1 participant 1 message Dec 13, 2011 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

Hello Mauro Carvalho Chehab,

This is a semi-automatic email about new static checker warnings.

The patch 4a83b0115066: "[media] tm6000: rewrite IR support" from Nov 29, 2011, leads to the following Smatch complaint:

drivers/media/video/tm6000/tm6000-input.c +327 __tm6000_ir_int_start()
warn: variable dereferenced before check 'ir' (see line 323)

drivers/media/video/tm6000/tm6000-input.c
322 struct tm6000_IR *ir = rc->priv;

   323		struct tm6000_core *dev = ir->dev;
                                          ^^^^^^^

New dereference.

324 int pipe, size;
325 int err = -ENOMEM;
326
327 if (!ir)

                ^^^^^^^^

Old check.

328 return -ENODEV;
329

regards,
dan carpenter