Skip to contentSkip to conversation

ARM: OMAP2+: kconfig: Enable devicetree by default for OMAP2+ systems

PATCH New Benoit Cousson 4 participants 9 messages Dec 6, 2011 – Jan 6, 2012

Subsystems (3)
Arm (32-bit) Arm sub-architectures OMAP2+ support
lore
Share & tools
lore

Benoit Cousson

author
#0 lore raw

PATCH 1/3 ARM: OMAP2+: kconfig: Enable devicetree by default for OMAP2+ systems

devicetree will become the mandatory boot method for OMAP2+. In order to avoid cluttering the OMAP code with #ifdef CONFIG_OF, select USE_OF by default for every OMAP2+ systems. Select as well the APPENDED_DTB and ATAG_DTB_COMPAT to allow legacy boot loader to keep working properly.

Enable PROC_DEVICETREE as well.

Signed-off-by Benoit Cousson <[email protected]>
Cc Tony Lindgren <[email protected]>
---
 arch/arm/mach-omap2/Kconfig |    1 -
 arch/arm/plat-omap/Kconfig  |    4 ++++
 2 files changed, 4 insertions(+), 1 deletions(-)
arch/arm/mach-omap2/Kconfig +0 -1
index e1293aa..056a812 100644
@@ -109,7 +109,6 @@ comment "OMAP Board Type"
 config MACH_OMAP_GENERIC
 	bool "Generic OMAP2+ board"
 	depends on ARCH_OMAP2PLUS
-	select USE_OF
 	default y
 	help
 	  Support for generic TI OMAP2+ boards using Flattened Device Tree.
arch/arm/plat-omap/Kconfig +4 -0
index aa59f42..74f41dc 100644
@@ -24,6 +24,10 @@ config ARCH_OMAP2PLUS
 	select CLKDEV_LOOKUP
 	select GENERIC_IRQ_CHIP
 	select OMAP_DM_TIMER
+	select USE_OF
+	select ARM_APPENDED_DTB
+	select ARM_ATAG_DTB_COMPAT
+	select PROC_DEVICETREE
 	help
 	  "Systems based on OMAP2, OMAP3 or OMAP4"
Signature · 1 line
1.7.0.4
#1 lore raw

PATCH 1/3 ARM: OMAP2+: kconfig: Enable devicetree by default for OMAP2+ systems

Hi,

Quoted 5 lines · Benoit Cousson

devicetree will become the mandatory boot method for OMAP2+. In order to avoid cluttering the OMAP code with #ifdef CONFIG_OF, select USE_OF by default for every OMAP2+ systems. Select as well the APPENDED_DTB and ATAG_DTB_COMPAT to allow legacy boot loader to keep working properly.

APPENDED_DTB sounds a bit dangerous to be enabled by default according to the config help text.

Tomi

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20111213/4fa39ab4/attachment.sig>

author
#2 lore raw

PATCH 1/3 ARM: OMAP2+: kconfig: Enable devicetree by default for OMAP2+ systems

Quoted 11 lines · Tomi Valkeinen

Hi,

Quoted 5 lines · Benoit Cousson

devicetree will become the mandatory boot method for OMAP2+. In order to avoid cluttering the OMAP code with #ifdef CONFIG_OF, select USE_OF by default for every OMAP2+ systems. Select as well the APPENDED_DTB and ATAG_DTB_COMPAT to allow legacy boot loader to keep working properly.

APPENDED_DTB sounds a bit dangerous to be enabled by default according to the config help text.

The help is indeed really scary :-)

Tony,
Do we want to keep it by default? Or should we fix the kconfig help?

Regards
Benoit

maintainer
#3 lore raw

PATCH 1/3 ARM: OMAP2+: kconfig: Enable devicetree by default for OMAP2+ systems

Quoted 10 lines · Cousson, Benoit
Quoted 9 lines · Tomi Valkeinen

Hi,

Quoted 5 lines · Benoit Cousson

devicetree will become the mandatory boot method for OMAP2+. In order to avoid cluttering the OMAP code with #ifdef CONFIG_OF, select USE_OF by default for every OMAP2+ systems. Select as well the APPENDED_DTB and ATAG_DTB_COMPAT to allow legacy boot loader to keep working properly.

Quoted 4 lines
Quoted 2 lines

APPENDED_DTB sounds a bit dangerous to be enabled by default according to the config help text.

The help is indeed really scary :-)

Heh, but it's also true.

Quoted 2 lines

Tony,
Do we want to keep it by default? Or should we fix the kconfig help?

Let's just leave out those two from omap2plus_defconfig then.

Regards,

Tony

author
#4 lore raw

PATCH 1/3 ARM: OMAP2+: kconfig: Enable devicetree by default for OMAP2+ systems

Quoted 14 lines · Tony Lindgren
Quoted 13 lines · Cousson, Benoit
Quoted 11 lines · Tomi Valkeinen

Hi,

Quoted 5 lines · Benoit Cousson

devicetree will become the mandatory boot method for OMAP2+. In order to avoid cluttering the OMAP code with #ifdef CONFIG_OF, select USE_OF by default for every OMAP2+ systems. Select as well the APPENDED_DTB and ATAG_DTB_COMPAT to allow legacy boot loader to keep working properly.

APPENDED_DTB sounds a bit dangerous to be enabled by default according to the config help text.

Quoted 8 lines
Quoted 1 line

The help is indeed really scary :-)

Heh, but it's also true.

Quoted 2 lines

Tony,
Do we want to keep it by default? Or should we fix the kconfig help?

Let's just leave out those two from omap2plus_defconfig then.

OK. I'll do that.

Benoit

author
#5 lore raw

PATCH 1/3 ARM: OMAP2+: kconfig: Enable devicetree by default for OMAP2+ systems

In reply to Tony Lindgren

Hi Tony,

Quoted 14 lines · Tony Lindgren
Quoted 13 lines · Cousson, Benoit
Quoted 11 lines · Tomi Valkeinen

Hi,

Quoted 5 lines · Benoit Cousson

devicetree will become the mandatory boot method for OMAP2+. In order to avoid cluttering the OMAP code with #ifdef CONFIG_OF, select USE_OF by default for every OMAP2+ systems. Select as well the APPENDED_DTB and ATAG_DTB_COMPAT to allow legacy boot loader to keep working properly.

APPENDED_DTB sounds a bit dangerous to be enabled by default according to the config help text.

Quoted 8 lines
Quoted 1 line

The help is indeed really scary :-)

Heh, but it's also true.

Quoted 2 lines

Tony,
Do we want to keep it by default? Or should we fix the kconfig help?

Let's just leave out those two from omap2plus_defconfig then.

Here is the updated version.
Just let me know if you'd like to get the full series re-posted.

Thanks,
Benoit

---

Quoted 1 line

From b33d4be0213ab0c630b87bd3df77035cbb109cd0 Mon Sep 17 00:00:00 2001

From: Benoit Cousson <[email protected]>
Date: Thu, 1 Dec 2011 10:21:16 +0100
Subject: [PATCH] ARM: OMAP2+: kconfig: Enable devicetree by default for OMAP2+ systems

devicetree will become the mandatory boot method for OMAP2+. In order to avoid cluttering the OMAP code with #ifdef CONFIG_OF, select USE_OF by default for every OMAP2+ systems.

Enable PROC_DEVICETREE as well.

Signed-off-by Benoit Cousson <[email protected]>
Cc Tony Lindgren <[email protected]>
---
 arch/arm/mach-omap2/Kconfig |    1 -
 arch/arm/plat-omap/Kconfig  |    2 ++
 2 files changed, 2 insertions(+), 1 deletions(-)
arch/arm/mach-omap2/Kconfig +0 -1
index b662513..bdd5b68 100644
@@ -111,7 +111,6 @@ comment "OMAP Board Type"
 config MACH_OMAP_GENERIC
 	bool "Generic OMAP2+ board"
 	depends on ARCH_OMAP2PLUS
-	select USE_OF
 	default y
 	help
 	  Support for generic TI OMAP2+ boards using Flattened Device Tree.
arch/arm/plat-omap/Kconfig +2 -0
index aa59f42..734009a 100644
@@ -24,6 +24,8 @@ config ARCH_OMAP2PLUS
 	select CLKDEV_LOOKUP
 	select GENERIC_IRQ_CHIP
 	select OMAP_DM_TIMER
+	select USE_OF
+	select PROC_DEVICETREE
 	help
 	  "Systems based on OMAP2, OMAP3 or OMAP4"
Signature · 1 line
1.7.0.4
maintainer
#6 lore raw

PATCH 1/3 ARM: OMAP2+: kconfig: Enable devicetree by default for OMAP2+ systems

Quoted 21 lines · Cousson, Benoit

Hi Tony,

Quoted 18 lines · Tony Lindgren
Quoted 10 lines · Cousson, Benoit
Quoted 9 lines · Tomi Valkeinen

Hi,

Quoted 5 lines · Benoit Cousson

devicetree will become the mandatory boot method for OMAP2+. In order to avoid cluttering the OMAP code with #ifdef CONFIG_OF, select USE_OF by default for every OMAP2+ systems. Select as well the APPENDED_DTB and ATAG_DTB_COMPAT to allow legacy boot loader to keep working properly.

Quoted 4 lines
Quoted 2 lines

APPENDED_DTB sounds a bit dangerous to be enabled by default according to the config help text.

The help is indeed really scary :-)

Heh, but it's also true.

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

Tony,
Do we want to keep it by default? Or should we fix the kconfig help?

Let's just leave out those two from omap2plus_defconfig then.

Here is the updated version.
Just let me know if you'd like to get the full series re-posted.

Thanks applying into dt branch. No need to repost this series.

Regards,

Tony

#7 lore raw

PATCH 1/3 ARM: OMAP2+: kconfig: Enable devicetree by default for OMAP2+ systems

In reply to Benoit Cousson
Quoted 10 lines · Benoit Cousson

devicetree will become the mandatory boot method for OMAP2+. In order to avoid cluttering the OMAP code with #ifdef CONFIG_OF, select USE_OF by default for every OMAP2+ systems. Select as well the APPENDED_DTB and ATAG_DTB_COMPAT to allow legacy boot loader to keep working properly.

Enable PROC_DEVICETREE as well.

Signed-off-by Benoit Cousson <[email protected]>
Cc Tony Lindgren <[email protected]>
Acked-by Grant Likely <[email protected]>
Quoted 40 lines

---
?arch/arm/mach-omap2/Kconfig | ? ?1 -
?arch/arm/plat-omap/Kconfig ?| ? ?4 ++++
?2 files changed, 4 insertions(+), 1 deletions(-)

arch/arm/mach-omap2/Kconfig +0 -0
index e1293aa..056a812 100644
@@ -109,7 +109,6 @@ comment "OMAP Board Type"

?config MACH_OMAP_GENERIC
? ? ? ?bool "Generic OMAP2+ board"
? ? ? ?depends on ARCH_OMAP2PLUS
- ? ? ? select USE_OF
? ? ? ?default y
? ? ? ?help
? ? ? ? ?Support for generic TI OMAP2+ boards using Flattened Device Tree.

arch/arm/plat-omap/Kconfig +0 -0
index aa59f42..74f41dc 100644
@@ -24,6 +24,10 @@ config ARCH_OMAP2PLUS

? ? ? ?select CLKDEV_LOOKUP
? ? ? ?select GENERIC_IRQ_CHIP
? ? ? ?select OMAP_DM_TIMER
+ ? ? ? select USE_OF
+ ? ? ? select ARM_APPENDED_DTB
+ ? ? ? select ARM_ATAG_DTB_COMPAT
+ ? ? ? select PROC_DEVICETREE
? ? ? ?help
? ? ? ? ?"Systems based on OMAP2, OMAP3 or OMAP4"

--
1.7.0.4

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Signature · 2 lines
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
author
#8 lore raw

PATCH 1/3 ARM: OMAP2+: kconfig: Enable devicetree by default for OMAP2+ systems

Quoted 7 lines · Grant Likely
Quoted 6 lines · Benoit Cousson

devicetree will become the mandatory boot method for OMAP2+. In order to avoid cluttering the OMAP code with #ifdef CONFIG_OF, select USE_OF by default for every OMAP2+ systems. Select as well the APPENDED_DTB and ATAG_DTB_COMPAT to allow legacy boot loader to keep working properly.

Quoted 6 lines
Quoted 4 lines

Enable PROC_DEVICETREE as well.

Signed-off-by Benoit Cousson<[email protected]>
Cc Tony Lindgren<[email protected]>
Acked-by Grant Likely<[email protected]>

Thanks for the reviews.

Benoit