tm6000: using an uninitialized variable in debug code

PATCH New Dan Carpenter 1 participant 1 message Dec 14, 2011

Subsystems (2)

Media (V4L/DVB) Kernel janitors

lore

Share & tools

lore

Dan Carpenter

author

2011-12-14 06:17 UTC #0 lore raw

PATCH 1/1 tm6000: using an uninitialized variable in debug code

dprintk() dereferences "ir". I'm not sure why gcc doesn't complain about this.

Signed-off-by Dan Carpenter <[email protected]>

drivers/media/video/tm6000/tm6000-input.c +2 -2

index 8d92527..7844607 100644
@@ -408,13 +408,13 @@ int tm6000_ir_init(struct tm6000_core *dev)
 	if (!dev->ir_codes)
 		return 0;
 
-	dprintk(2, "%s\n",__func__);
-
 	ir = kzalloc(sizeof(*ir), GFP_ATOMIC);
 	rc = rc_allocate_device();
 	if (!ir || !rc)
 		goto out;
 
+	dprintk(2, "%s\n", __func__);
+
 	/* record handles to ourself */
 	ir->dev = dev;
 	dev->ir = ir;