brcm80211: smac: precendence bug in wlc_phy_attach()

PATCH In review Dan Carpenter 2 participants 2 messages Dec 15, 2011

Subsystems (2)

Kernel janitors Networking drivers (wireless)

lore

Share & tools

lore

Dan Carpenter

author

2011-12-15 11:23 UTC #0 lore raw

PATCH 1/1 brcm80211: smac: precendence bug in wlc_phy_attach()

Negate has higher precendence than compare and since neither zero nor one are equal to four or eight the original condition is always false.

Signed-off-by Dan Carpenter <[email protected]>

drivers/net/wireless/brcm80211/brcmsmac/phy/phy_cmn.c +2 -2

index 5b57caa..264f8c4 100644
@@ -482,8 +482,8 @@ wlc_phy_attach(struct shared_phy *sh, struct bcma_device *d11core,
 	pi->pubpi.phy_corenum = PHY_CORE_NUM_2;
 	pi->pubpi.ana_rev = (phyversion & PV_AV_MASK) >> PV_AV_SHIFT;
 
-	if (!pi->pubpi.phy_type = PHY_TYPE_N &&
-	    !pi->pubpi.phy_type = PHY_TYPE_LCN)
+	if (pi->pubpi.phy_type != PHY_TYPE_N &&
+	    pi->pubpi.phy_type != PHY_TYPE_LCN)
 		goto err;
 
 	if (bandtype = BRCM_BAND_5G) {

Arend van Spriel

Acked-by on v1 1/1

2011-12-15 11:49 UTC #1 lore raw

Re: [patch] brcm80211: smac: precendence bug in

Quoted 3 lines · Dan Carpenter

Negate has higher precendence than compare and since neither zero nor one are equal to four or eight the original condition is always false.

Acked-by Arend van Spriel <[email protected]>

Quoted 1 line

Signed-off-by Dan Carpenter <[email protected]>

Gr. AvS