Fix compile error in sound/soc/mid-x86/sst_platform.c
PATCH 1/1 Fix compile error in sound/soc/mid-x86/sst_platform.c
(again with mailing lists on Cc, sorry)
Hi,
I tested current linux-next against my iommu-configs and found a compile error in sound/soc/mid-x86/sst_platform.c. The variable ret_val in the sst_platform_open() function is used but not declared. Attached patch fixes this.
Quoted 1 line
From
d4e6d3b9ff8084c02eaf50e8212f77bcde5dec9dMon Sep 17 00:00:00 2001
From: Joerg Roedel <[email protected]>
Date: Thu, 15 Dec 2011 17:39:31 +0100
Subject: [PATCH] Fix compile error in sound/soc/mid-x86/sst_platform.c
The variable ret_val is used but not declared. Fix this.
--- sound/soc/mid-x86/sst_platform.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
sound/soc/mid-x86/sst_platform.c +1 -0
@@ -267,6 +267,7 @@ static int sst_platform_open(struct snd_pcm_substream *substream) {struct snd_pcm_runtime *runtime = substream->runtime;struct sst_runtime_stream *stream; +int ret_val;pr_debug ("sst_platform_open called\n" );
Signature · 8 lines
1.7.5.4 -- AMD Operating System Research Center Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach General Managers: Alberto Bozzo, Andrew Bowd Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
Quoted 9 lines · Joerg Roedel
(again with mailing lists on Cc, sorry)
Hi,
I tested current linux-next against my iommu-configs and found a compile error in
sound/soc/mid-x86/sst_platform.c. The variableret_valin thesst_platform_open()function is used but not declared. Attached patch fixes this.
While fixing any kind of error/warning, it's nice to have error/warning message in changelog.
Thanks,
Rakib
Quoted 39 lines
From
d4e6d3b9ff8084c02eaf50e8212f77bcde5dec9dMon Sep 17 00:00:00 2001
From: Joerg Roedel <[email protected]>
Date: Thu, 15 Dec 2011 17:39:31 +0100
Subject: [PATCH] Fix compile error insound/soc/mid-x86/sst_platform.cThe variable
ret_valis used but not declared. Fix this.Signed-off-by Joerg Roedel <[email protected]>---
sound/soc/mid-x86/sst_platform.c | 1 +1 files changed, 1 insertions(+), 0 deletions(-)sound/soc/mid-x86/sst_platform.c +1
-1@@ -267,6 +267,7 @@ static int sst_platform_open(struct snd_pcm_substream *substream) { struct snd_pcm_runtime *runtime = substream->runtime; struct sst_runtime_stream *stream; + int ret_val; pr_debug("sst_platform_open called\n"); --1.7.5.4
--
AMD Operating System Research CenterAdvanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Quoted 5 lines · Rakib Mullick
Quoted 4 lines · Joerg Roedel
(again with mailing lists on Cc, sorry)
Hi,
Quoted 8 lines
Quoted 5 lines
I tested current linux-next against my iommu-configs and found a compile error in
sound/soc/mid-x86/sst_platform.c. The variableret_valin thesst_platform_open()function is used but not declared. Attached patch fixes this.While fixing any kind of error/warning, it's nice to have error/warning message in changelog.
Okay, here it is:
From 9d0876632c4fc07254eafbe5018e68963bdcfe17 Mon Sep 17 00:00:00 2001
From: Joerg Roedel <[email protected]>
Date: Thu, 15 Dec 2011 17:39:31 +0100
Subject: [PATCH] Fix compile error in sound/soc/mid-x86/sst_platform.c
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The variable ret_val is used but not declared. This causes the following compile error:
sound/soc/mid-x86/sst_platform.c: In function ‘sst_platform_open’:sound/soc/mid-x86/sst_platform.c:274:2: error: ‘ret_val’ undeclared (first use in this function) sound/soc/mid-x86/sst_platform.c:274:2: note: each undeclared identifier is reported only once for each function it appears in make[1]: *** [sound/soc/mid-x86/sst_platform.o] Error 1
Fix this.
--- sound/soc/mid-x86/sst_platform.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
sound/soc/mid-x86/sst_platform.c +1 -0
@@ -267,6 +267,7 @@ static int sst_platform_open(struct snd_pcm_substream *substream) {struct snd_pcm_runtime *runtime = substream->runtime;struct sst_runtime_stream *stream; +int ret_val;pr_debug ("sst_platform_open called\n" );
Signature · 9 lines
1.7.5.4 -- AMD Operating System Research Center Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach General Managers: Alberto Bozzo, Andrew Bowd Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
At Thu, 15 Dec 2011 18:24:54 +0100,
Quoted 29 lines · Joerg Roedel
Quoted 5 lines · Rakib Mullick
Quoted 4 lines · Joerg Roedel
(again with mailing lists on Cc, sorry)
Hi,
Quoted 8 lines
Quoted 5 lines
I tested current linux-next against my iommu-configs and found a compile error in
sound/soc/mid-x86/sst_platform.c. The variableret_valin thesst_platform_open()function is used but not declared. Attached patch fixes this.While fixing any kind of error/warning, it's nice to have error/warning message in changelog.
Okay, here it is:
Quoted 1 line
From
9d0876632c4fc07254eafbe5018e68963bdcfe17Mon Sep 17 00:00:00 2001From: Joerg Roedel <[email protected]>
Date: Thu, 15 Dec 2011 17:39:31 +0100
Subject: [PATCH] Fix compile error insound/soc/mid-x86/sst_platform.c
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bitThe variable
ret_valis used but not declared. This causes the following compile error:
Quoted 8 lines
sound/soc/mid-x86/sst_platform.c: In function ‘sst_platform_open’:sound/soc/mid-x86/sst_platform.c:274:2: error: ‘ret_val’ undeclared (first use in this function)sound/soc/mid-x86/sst_platform.c:274:2: note: each undeclared identifier is reported only once for each function it appears in make[1]: *** [sound/soc/mid-x86/sst_platform.o] Error 1Fix this.
Signed-off-by Joerg Roedel <[email protected]>
Thanks, I applied the patch now to sound git tree.
Mark, could you merge back topic/asoc branch into your tree later?
Takashi
Quoted 27 lines
--- sound/soc/mid-x86/sst_platform.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)sound/soc/mid-x86/sst_platform.c +1
-0@@ -267,6 +267,7 @@ static int sst_platform_open(struct snd_pcm_substream *substream) {struct snd_pcm_runtime *runtime = substream->runtime;struct sst_runtime_stream *stream; +int ret_val;pr_debug ("sst_platform_open called\n" );Signature · 9 lines
1.7.5.4 -- AMD Operating System Research Center Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach General Managers: Alberto Bozzo, Andrew Bowd Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Quoted 1 line · Takashi Iwai
Mark, could you merge back topic/asoc branch into your tree later?
Sure... that was a bit fast waiting for my response.