Skip to contentSkip to conversation

Added some addition debug prints for pb_keys

PATCH In review Alan Cox 3 participants 3 messages Dec 15, 2011 – Dec 18, 2011 x86

lore
Share & tools
lore

Alan Cox

author
#0 lore raw

PATCH 1/1 Added some addition debug prints for pb_keys

From: Michael Demeter <[email protected]>

Added additional debug output that we always seem to add during power ons to validate firmware operation.

---

 arch/x86/platform/mrst/mrst.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
arch/x86/platform/mrst/mrst.c +2 -0
index a9a4732..3002cc86 100644
@@ -1035,6 +1035,8 @@ static int __init pb_keys_init(void)
 	num = sizeof(gpio_button) / sizeof(struct gpio_keys_button);
 	for (i = 0; i < num; i++) {
 		gb[i].gpio = get_gpio_by_name(gb[i].desc);
+		pr_debug("info[%2d]: name = %s,"
+				"gpio = %d\n", i, gb[i].desc, gb[i].gpio);
 		if (gb[i].gpio == -1)
 			continue;
 
#1 lore raw
Quoted 19 lines · Alan Cox

From: Michael Demeter <[email protected]>

Added additional debug output that we always seem to add during power ons to validate firmware operation.

---

 arch/x86/platform/mrst/mrst.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
arch/x86/platform/mrst/mrst.c +0 -0
index a9a4732..3002cc86 100644

arch/x86/platform/mrst/mrst.c static int __init pb_keys_init(void) · line 1039

Quoted 5 lines
arch/x86/platform/mrst/mrst.c +2 -0
@@ -1035,6 +1035,8 @@ static int __init pb_keys_init(void)
 	num = sizeof(gpio_button) / sizeof(struct gpio_keys_button);
 	for (i = 0; i < num; i++) {
 		gb[i].gpio = get_gpio_by_name(gb[i].desc);
+		pr_debug("info[%2d]: name = %s,"
+				"gpio = %d\n", i, gb[i].desc, gb[i].gpio);

I've fixed this to lie on a single line - there's no point in line-breaking pr_debug()s in general - especially not the format string.

Note that merging the format string unearthed a small formatting ugly:

	"info[%2d]: name = %s,gpio = %d\n"

I edited that to the probably intended:

	"info[%2d]: name = %s, gpio = %d\n"

Thanks,

Ingo

#2 lore raw

[tip:x86/platform] x86/mrst: Add additional debug prints for pb_keys

In reply to Alan Cox
Commit-ID:  d79a8869d8a4b565b12a88faeff834b09a36368c
Gitweb:     http://git.kernel.org/tip/d79a8869d8a4b565b12a88faeff834b09a36368c
Author:     Michael Demeter <[email protected]>
AuthorDate: Thu, 15 Dec 2011 22:31:23 +0000
Committer:  Ingo Molnar <[email protected]>
CommitDate: Sun, 18 Dec 2011 09:37:07 +0100

x86/mrst: Add additional debug prints for pb_keys

Added additional debug output that we always seem to add during power ons to validate firmware operation.

---
 arch/x86/platform/mrst/mrst.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/x86/platform/mrst/mrst.c +1 -0
index 6a21f60..b6a33d2 100644
@@ -983,6 +983,7 @@ static int __init pb_keys_init(void)
 	num = sizeof(gpio_button) / sizeof(struct gpio_keys_button);
 	for (i = 0; i < num; i++) {
 		gb[i].gpio = get_gpio_by_name(gb[i].desc);
+		pr_debug("info[%2d]: name = %s, gpio = %d\n", i, gb[i].desc, gb[i].gpio);
 		if (gb[i].gpio == -1)
 			continue;