NFC: Fix LLCP related build failure
Subsystems (2)
PATCH 1/1 NFC: Fix LLCP related build failure
llcp_mac routines should be static and inlined or build will fail with NFC selected without LLCP.
This patch fixes:
LD [M] net/nfc/nfc.onet/nfc/netlink.o: In function `nfc_llcp_mac_is_down':
netlink.c:(.text+0x0): multiple definition of nfc_llcp_mac_is_down' net/nfc/core.o:(.text+0x0): first defined here net/nfc/netlink.o: In function nfc_llcp_mac_is_up':
netlink.c:(.text+0x10): multiple definition of nfc_llcp_mac_is_up' net/nfc/core.o:(.text+0x10): first defined here net/nfc/af_nfc.o: In function nfc_llcp_mac_is_down':
(.text+0x0): multiple definition of nfc_llcp_mac_is_down' net/nfc/core.o:(.text+0x0): first defined here net/nfc/af_nfc.o: In function nfc_llcp_mac_is_up':
(.text+0x10): multiple definition of nfc_llcp_mac_is_up' net/nfc/core.o:(.text+0x10): first defined here net/nfc/rawsock.o: In function nfc_llcp_mac_is_down':
rawsock.c:(.text+0x0): multiple definition of nfc_llcp_mac_is_down' net/nfc/core.o:(.text+0x0): first defined here net/nfc/rawsock.o: In function nfc_llcp_mac_is_up':
rawsock.c:(.text+0x10): multiple definition of `nfc_llcp_mac_is_up' net/nfc/core.o:(.text+0x10): first defined here
---
John, if you want to revert d646960f7986fefb460a2b062d5ccc8ccfeacc3a, I can send you an updated one with that fix included. Let me know what you'd prefer.
--- net/nfc/nfc.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
net/nfc/nfc.h +2 -2
@@ -60,11 +60,11 @@ void nfc_llcp_exit(void);#else -void nfc_llcp_mac_is_down (struct nfc_dev *dev) +static inline void nfc_llcp_mac_is_down (struct nfc_dev *dev) { } -void nfc_llcp_mac_is_up (struct nfc_dev *dev,u32 target_idx, +static inline void nfc_llcp_mac_is_up (struct nfc_dev *dev,u32 target_idx,u8 comm_mode,u8 rf_mode) { }
Signature · 5 lines
1.7.7.3 -- Intel Open Source Technology Centre http://oss.intel.com/