mpc8xxx: Fix "DRAM" message formatting
PATCH 1/1 mpc8xxx: Fix "DRAM" message formatting
When the "Detected RDIMM [...]" message was added, it broke the pretty-printing of the DRAM information during boot.
It used to look like this:
DRAM: 2 GiB (DDR2, 64-bit, CL=4, ECC on)
DDR Chip-Select Interleaving Mode: CS0+CS1
Right now, it looks like this:
DRAM: Detected RDIMM VL493T5663D-E6M
2 GiB (DDR2, 64-bit, CL=4, ECC on)
DDR Chip-Select Interleaving Mode: CS0+CS1
After this patch, it is:
DRAM: Detected RDIMM VL493T5663D-E6M
2 GiB (DDR2, 64-bit, CL=4, ECC on) DDR Chip-Select Interleaving Mode: CS0+CS1
--- .../cpu/mpc8xxx/ddr/lc_common_dimm_params.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
arch/powerpc/cpu/mpc8xxx/ddr/lc_common_dimm_params.c +2 -2
@@ -209,11 +209,11 @@ compute_lowest_common_dimm_parameters(const dimm_params_t *dimm_params,if (dimm_params[i].n_ranks) {if (dimm_params[i].registered_dimm) { temp1 =1 ; -printf ("Detected RDIMM %s\n" , +printf ("Detected RDIMM %s\n " , dimm_params[i].mpart); }else { temp2 =1 ; -printf ("Detected UDIMM %s\n" , +printf ("Detected UDIMM %s\n " , dimm_params[i].mpart); } }
Signature · 1 line
1.7.7.3
PATCH 1/1 mpc8xxx: Fix "DRAM" message formatting
Dear Kyle Moffett,
Quoted 12 lines · In message <[email protected]> you…
When the "Detected RDIMM [...]" message was added, it broke the pretty-printing of the DRAM information during boot.
It used to look like this:
DRAM: 2 GiB (DDR2, 64-bit, CL=4, ECC on)
DDR Chip-Select Interleaving Mode: CS0+CS1Right now, it looks like this:
DRAM: Detected RDIMM VL493T5663D-E6M
2 GiB (DDR2, 64-bit, CL=4, ECC on)
DDR Chip-Select Interleaving Mode: CS0+CS1
Quoted 4 lines
After this patch, it is:
DRAM: Detected RDIMM VL493T5663D-E6M
2 GiB (DDR2, 64-bit, CL=4, ECC on) DDR Chip-Select Interleaving Mode: CS0+CS1
We discussed this before.
This outpout is too verbose. It should read:
DRAM: 2 GiB
And not more. Any additional information should only be printed upon explicit request from the user.
Thanks.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A verbal contract isn't worth the paper it's written on.
-- Samuel Goldwyn