kvm tool: Introduce own BUG_ON handler

PATCH New Cyrill Gorcunov 1 participant 1 message Dec 20, 2011 KVM

lore

Share & tools

lore

Cyrill Gorcunov

author

2011-12-20 16:58 UTC #0 lore raw

PATCH 1/1 kvm tool: Introduce own BUG_ON handler

Raise SIGABRT in case if run-time crtitical
problem found.

Proposed-by Ingo Molnar <[email protected]>

Signed-off-by Cyrill Gorcunov <[email protected]>

---

Ingo, you meant something like below?

 tools/kvm/include/kvm/util.h |   17 ++++++++++++++---
 1 file changed, 14 insertions(+), 3 deletions(-)

tools/kvm/include/kvm/util.h +14 -3

Index: linux-2.6.git/tools/kvm/include/kvm/util.h
===================================================================
@@ -9,7 +9,6 @@
  * Some bits are stolen from perf tool :)
  */
 
-#include <assert.h>
 #include <unistd.h>
 #include <stdio.h>
 #include <stddef.h>

@@ -17,6 +16,7 @@
 #include <stdarg.h>
 #include <string.h>
 #include <stdbool.h>
+#include <signal.h>
 #include <errno.h>
 #include <limits.h>
 #include <sys/param.h>

@@ -51,9 +51,20 @@ extern void set_die_routine(void (*routi
 				__func__, __LINE__, ##__VA_ARGS__);	\
 	} while (0)
 
-#
+
 #define BUILD_BUG_ON(condition)	((void)sizeof(char[1 - 2*!!(condition)]))
-#define BUG_ON(condition)	assert(!(condition))
+
+#ifndef BUG_ON_HANDLER
+# define BUG_ON_HANDLER(condition)					\
+	do {								\
+		if ((condition)) {					\
+			pr_err("BUG at %s:%d", __FILE__, __LINE__);	\
+			raise(SIGABRT);					\
+		}							\
+	} while (0)
+#endif
+
+#define BUG_ON(condition)	BUG_ON_HANDLER((condition))
 
 #define DIE_IF(cnd)						\
 do {								\