Skip to contentSkip to conversation

out-of-tree module shouldn't disable lockdep

DISCUSSION Tejun Heo 1 participant 2 messages Dec 22, 2011

lore
Share & tools
lore

Tejun Heo

author
#0 lore raw

Hello, guys.

2449b8ba074 "module,bug: Add TAINT_OOT_MODULE flag for modules not built in-tree" added TAINT_OOT_MODULE to mark kernel which has out-of-tree module loaded, which might be a good idea but an unfortunate side effect of tainting is that it disables lockdep. So, now, none of my test modules is watched by lockdep. This is a bad bad idea. People use oot modules to write test code and disabling lockdep for test codes is silly. Can we please fix this?

Thanks.

Signature · 1 line
tejun
author
#1 lore raw
Quoted 9 lines · Tejun Heo

Hello, guys.

2449b8ba074 "module,bug: Add TAINT_OOT_MODULE flag for modules not built in-tree" added TAINT_OOT_MODULE to mark kernel which has out-of-tree module loaded, which might be a good idea but an unfortunate side effect of tainting is that it disables lockdep. So, now, none of my test modules is watched by lockdep. This is a bad bad idea. People use oot modules to write test code and disabling lockdep for test codes is silly. Can we please fix this?

Ingo just told me it's already fixed and scheduled for upstream, so please forget about this thread.

Thanks.

Signature · 1 line
tejun