Skip to contentSkip to conversation

udf: Mark LVID buffer as uptodate before marking it dirty

PATCH In review Jan Kara 2 participants 3 messages Dec 23, 2011

Subsystems (2)
lore
Share & tools
lore

Jan Kara

author reviewer
#0 lore raw

PATCH 1/1 udf: Mark LVID buffer as uptodate before marking it dirty

When we hit EIO while writing LVID, the buffer uptodate bit is cleared. This then results in an anoying warning from mark_buffer_dirty() when we write the buffer again. So just set uptodate flag unconditionally.

---
 fs/udf/super.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

I carry this patch in my tree and will merge it with Linus in the next
merge window if noone objects.

fs/udf/super.c +6 -0
index e185253..87cb24a 100644
@@ -1799,6 +1799,12 @@ static void udf_close_lvid(struct super_block *sb)
 				le16_to_cpu(lvid->descTag.descCRCLength)));
 
 	lvid->descTag.tagChecksum = udf_tag_checksum(&lvid->descTag);
+	/*
+	 * We set buffer uptodate unconditionally here to avoid spurious
+	 * warnings from mark_buffer_dirty() when previous EIO has marked
+	 * the buffer as !uptodate
+	 */
+	set_buffer_uptodate(bh);
 	mark_buffer_dirty(bh);
 	sbi->s_lvid_dirty = 0;
 	mutex_unlock(&sbi->s_alloc_mutex);
Signature · 1 line
1.7.1
author reviewer
#2 lore raw
Quoted 10 lines · Namjae Jeon

2011/12/23 Jan Kara <[email protected]>:

Quoted 5 lines

When we hit EIO while writing LVID, the buffer uptodate bit is cleared. This then results in an anoying warning from mark_buffer_dirty() when we write the buffer again. So just set uptodate flag unconditionally.

Quoted 1 line

---

Hi. Jan.
looks good to me !!.

Thanks for review!

Honza