Skip to contentSkip to conversation

Xorg and Tslib

PATCH New Sergio Prado 7 participants 10 messages Dec 23, 2011 – Dec 24, 2011

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Xorg and Tslib

Hello guys!

First of all, congratulations for the great work you have been doing on the Buildroot project!

That's my first message on the group. I have been using Buildroot professionally for some time now.

Nowadays I have a training company here in Brazil, and guess what I am using to teach embedded Linux? Buildroot, of course! :)

OK, so now that I have introduced myself, I would like to talk about about a problem I was having here with X11 and touch screen devices.

I have generated a rootfs with X11 and Matchbox support. Everything but the touchscreen works fine. I could use the ts_calibrate and ts_test tools to test the TS device. But when I started X11/Matchbox, the cursor was not calibrated.

Then I discovered that for X11 to talk directly to TS devices, it needs the xf86-input-tslib driver. And we don't have it on Buildroot (as far as I understood, it was developed by the Ubuntu team, not the xorg team).

I integrated this package to the Buildoot build system, compiled and tested. Everything is working now.

Here is the patch to include the xf86-input-tslib driver:

---
 package/x11r7/Config.in                            |    1 +
 package/x11r7/xdriver_xf86-input-tslib/Config.in   |    8 ++++++++
 .../xdriver_xf86-input-tslib.mk                    |   13 +++++++++++++
 3 files changed, 22 insertions(+), 0 deletions(-)
 create mode 100644 package/x11r7/xdriver_xf86-input-tslib/Config.in
 create mode 100644

package/x11r7/xdriver_xf86-input-tslib/xdriver_xf86-input-tslib.mk

package/x11r7/Config.in +1 -0
index 50816f2..af55939 100644
@@ -176,6 +176,7 @@ endmenu
 		source package/x11r7/xdriver_xf86-input-synaptics/Config.in
 		source package/x11r7/xdriver_xf86-input-vmmouse/Config.in
 		source package/x11r7/xdriver_xf86-input-void/Config.in
+		source package/x11r7/xdriver_xf86-input-tslib/Config.in
 		source package/x11r7/xdriver_xf86-video-apm/Config.in
 		source package/x11r7/xdriver_xf86-video-ark/Config.in
 		source package/x11r7/xdriver_xf86-video-ast/Config.in
(quoted diff) +0 -0

b/package/x11r7/xdriver_xf86-input-tslib/Config.in new file mode 100644
index 0000000..4c3f719

package/x11r7/xdriver_xf86-input-tslib/Config.in new file +8 -0
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_XDRIVER_XF86_INPUT_TSLIB
+	bool "xf86-input-tslib"
+	select BR2_PACKAGE_XPROTO_INPUTPROTO
+	select BR2_PACKAGE_XSERVER_XORG_SERVER
+	select BR2_PACKAGE_XPROTO_RANDRPROTO
+	select BR2_PACKAGE_XPROTO_XPROTO
+	help
+	  Touch screen library input driver
(quoted diff) +0 -0

b/package/x11r7/xdriver_xf86-input-tslib/xdriver_xf86-input-tslib.mk new file mode 100644
index 0000000..b6455e7

package/x11r7/xdriver_xf86-input-tslib/xdriver_xf86-input-tslib.mk new file +8 -0
@@ -0,0 +1,13 @@
+################################################################################
+#
+# xdriver_xf86-input-tslib -- Touch screen library input driver
+#
+################################################################################
+
+XDRIVER_XF86_INPUT_TSLIB_VERSION = 0.0.6
+XDRIVER_XF86_INPUT_TSLIB_SOURCE =

xf86-input-tslib_$(XDRIVER_XF86_INPUT_TSLIB_VERSION).orig.tar.gz +XDRIVER_XF86_INPUT_TSLIB_SITE =
http://ftp.de.debian.org/debian/pool/main/x/xf86-input-tslib/
+XDRIVER_XF86_INPUT_TSLIB_AUTORECONF = NO +XDRIVER_XF86_INPUT_TSLIB_DEPENDENCIES = xproto_inputproto xserver_xorg-server xproto_randrproto xproto_xproto
+
+$(eval $(call AUTOTARGETS,package/x11r7,xdriver_xf86-input-tslib))

Signature · 6 lines
1.7.1

--
Sergio Prado
www.sergioprado.org
Twitter @sergioprado
#1 lore raw

PATCH 1/1 Xorg and Tslib

Sorry, I forgot to send it in rich text format. Here is the patch again:

---
 package/x11r7/Config.in                            |    1 +
 package/x11r7/xdriver_xf86-input-tslib/Config.in   |    8 ++++++++
 .../xdriver_xf86-input-tslib.mk                    |   13 +++++++++++++
 3 files changed, 22 insertions(+), 0 deletions(-)
 create mode 100644 package/x11r7/xdriver_xf86-input-tslib/Config.in
 create mode 100644 package/x11r7/xdriver_xf86-input-tslib/

xdriver_xf86-input-tslib.mk

package/x11r7/Config.in +1 -0
index 50816f2..af55939 100644
@@ -176,6 +176,7 @@ endmenu
  source package/x11r7/xdriver_xf86-input-synaptics/Config.in
  source package/x11r7/xdriver_xf86-input-vmmouse/Config.in
  source package/x11r7/xdriver_xf86-input-void/Config.in
+ source package/x11r7/xdriver_xf86-input-tslib/Config.in
  source package/x11r7/xdriver_xf86-video-apm/Config.in
  source package/x11r7/xdriver_xf86-video-ark/Config.in
  source package/x11r7/xdriver_xf86-video-ast/Config.in
(quoted diff) +0 -0

b/package/x11r7/xdriver_xf86-input-tslib/Config.in new file mode 100644
index 0000000..4c3f719

package/x11r7/xdriver_xf86-input-tslib/Config.in new file +8 -0
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_XDRIVER_XF86_INPUT_TSLIB
+ bool "xf86-input-tslib"
+ select BR2_PACKAGE_XPROTO_INPUTPROTO
+ select BR2_PACKAGE_XSERVER_XORG_SERVER
+ select BR2_PACKAGE_XPROTO_RANDRPROTO
+ select BR2_PACKAGE_XPROTO_XPROTO
+ help
+  Touch screen library input driver
(quoted diff) +0 -0

xdriver_xf86-input-tslib.mk b/package/x11r7/xdriver_xf86-input-tslib/ xdriver_xf86-input-tslib.mk
new file mode 100644
index 0000000..b6455e7

package/x11r7/xdriver_xf86-input-tslib/xdriver_xf86-input-tslib.mk new file +8 -0
@@ -0,0 +1,13 @@
+################################################################################
+#
+# xdriver_xf86-input-tslib -- Touch screen library input driver
+#
+################################################################################
+
+XDRIVER_XF86_INPUT_TSLIB_VERSION = 0.0.6
+XDRIVER_XF86_INPUT_TSLIB_SOURCE =

xf86-input-tslib_$(XDRIVER_XF86_INPUT_TSLIB_VERSION).orig.tar.gz +XDRIVER_XF86_INPUT_TSLIB_SITE =
http://ftp.de.debian.org/debian/pool/main/x/xf86-input-tslib/
+XDRIVER_XF86_INPUT_TSLIB_AUTORECONF = NO +XDRIVER_XF86_INPUT_TSLIB_DEPENDENCIES = xproto_inputproto xserver_xorg-server xproto_randrproto xproto_xproto
+
+$(eval $(call AUTOTARGETS,package/x11r7,xdriver_xf86-input-tslib))

Signature · 10 lines
1.7.1


Sergio Prado
www.sergioprado.org
Twitter @sergioprado



2011/12/23 Sergio Prado <[email protected]>:

Review

Quoted 66 lines

Hello guys!

First of all, congratulations for the great work you have been doing on the Buildroot project!

That's my first message on the group. I have been using Buildroot professionally for some time now.

Nowadays I have a training company here in Brazil, and guess what I am using to teach embedded Linux? Buildroot, of course! :)

OK, so now that I have introduced myself, I would like to talk about about a problem I was having here with X11 and touch screen devices.

I have generated a rootfs with X11 and Matchbox support. Everything but the touchscreen works fine. I could use the ts_calibrate and ts_test tools to test the TS device. But when I started X11/Matchbox, the cursor was not calibrated.

Then I discovered that for X11 to talk directly to TS devices, it needs the xf86-input-tslib driver. And we don't have it on Buildroot (as far as I understood, it was developed by the Ubuntu team, not the xorg team).

I integrated this package to the Buildoot build system, compiled and tested. Everything is working now.

Here is the patch to include the xf86-input-tslib driver:

---
 package/x11r7/Config.in                            |    1 +
 package/x11r7/xdriver_xf86-input-tslib/Config.in   |    8 ++++++++
 .../xdriver_xf86-input-tslib.mk                    |   13 +++++++++++++
 3 files changed, 22 insertions(+), 0 deletions(-)
 create mode 100644 package/x11r7/xdriver_xf86-input-tslib/Config.in
 create mode 100644

package/x11r7/xdriver_xf86-input-tslib/xdriver_xf86-input-tslib.mk

package/x11r7/Config.in +1 -0
index 50816f2..af55939 100644
@@ -176,6 +176,7 @@ endmenu
               source package/x11r7/xdriver_xf86-input-synaptics/Config.in
               source package/x11r7/xdriver_xf86-input-vmmouse/Config.in
               source package/x11r7/xdriver_xf86-input-void/Config.in
+               source package/x11r7/xdriver_xf86-input-tslib/Config.in
               source package/x11r7/xdriver_xf86-video-apm/Config.in
               source package/x11r7/xdriver_xf86-video-ark/Config.in
               source package/x11r7/xdriver_xf86-video-ast/Config.in
package/x11r7/xdriver_xf86-input-tslib/Config.in new file +8 -0
new file mode 100644
index 0000000..4c3f719
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_XDRIVER_XF86_INPUT_TSLIB
+       bool "xf86-input-tslib"
+       select BR2_PACKAGE_XPROTO_INPUTPROTO
+       select BR2_PACKAGE_XSERVER_XORG_SERVER
+       select BR2_PACKAGE_XPROTO_RANDRPROTO
+       select BR2_PACKAGE_XPROTO_XPROTO
+       help
+         Touch screen library input driver
(quoted diff) +0 -0

xdriver_xf86-input-tslib.mk

package/x11r7/xdriver_xf86-input-tslib/xdriver_xf86-input-tslib.mk

Quoted 7 lines

b/package/x11r7/xdriver_xf86-input-tslib/xdriver_xf86-input-tslib.mk new file mode 100644
index 0000000..b6455e7

package/x11r7/xdriver_xf86-input-tslib/xdriver_xf86-input-tslib.mk new file +0 -0
@@ -0,0 +1,13 @@

+################################################################################

package/x11r7/xdriver_xf86-input-tslib/xdriver_xf86-input-tslib.mk line 3

Quoted 4 lines
package/x11r7/xdriver_xf86-input-tslib/xdriver_xf86-input-tslib.mk new file +3 -0
+#
+# xdriver_xf86-input-tslib -- Touch screen library input driver
+#

+################################################################################

Quoted 14 lines
package/x11r7/xdriver_xf86-input-tslib/xdriver_xf86-input-tslib.mk new file +3 -0
+
+XDRIVER_XF86_INPUT_TSLIB_VERSION = 0.0.6
+XDRIVER_XF86_INPUT_TSLIB_SOURCE =

xf86-input-tslib_$(XDRIVER_XF86_INPUT_TSLIB_VERSION).orig.tar.gz +XDRIVER_XF86_INPUT_TSLIB_SITE =
http://ftp.de.debian.org/debian/pool/main/x/xf86-input-tslib/

package/x11r7/xdriver_xf86-input-tslib/xdriver_xf86-input-tslib.mk new file +2 -0
+XDRIVER_XF86_INPUT_TSLIB_AUTORECONF = NO
+XDRIVER_XF86_INPUT_TSLIB_DEPENDENCIES = xproto_inputproto

xserver_xorg-server xproto_randrproto xproto_xproto
+
+$(eval $(call AUTOTARGETS,package/x11r7,xdriver_xf86-input-tslib)) --
1.7.1

Quoted 4 lines

--
Sergio Prado
www.sergioprado.org
Twitter @sergioprado

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20111223/2062d304/attachment.html>

#2 lore raw

PATCH 1/1 Xorg and Tslib

Quoted 1 line · Sergio Prado

Pardon a small bit of nit-picking...

Quoted 2 lines

Sorry, I forgot to send it in rich text format. Here is the patch again:

Plain text works best for patches.

Quoted 14 lines
---
 package/x11r7/Config.in                            |    1 +
 package/x11r7/xdriver_xf86-input-tslib/Config.in   |    8 ++++++++
 .../xdriver_xf86-input-tslib.mk                    |   13 +++++++++++++
 3 files changed, 22 insertions(+), 0 deletions(-)
 create mode 100644 package/x11r7/xdriver_xf86-input-tslib/Config.in
 create mode 100644 package/x11r7/xdriver_xf86-input-tslib/

xdriver_xf86-input-tslib.mk

package/x11r7/Config.in +0 -0
index 50816f2..af55939 100644

package/x11r7/Config.in endmenu · line 179

Quoted 4 lines
package/x11r7/Config.in +1 -0
@@ -176,6 +176,7 @@ endmenu
  source package/x11r7/xdriver_xf86-input-synaptics/Config.in
  source package/x11r7/xdriver_xf86-input-vmmouse/Config.in
  source package/x11r7/xdriver_xf86-input-void/Config.in
+ source package/x11r7/xdriver_xf86-input-tslib/Config.in

T before V

Mike

Quoted 42 lines
package/x11r7/Config.in +0 -0
  source package/x11r7/xdriver_xf86-video-apm/Config.in
  source package/x11r7/xdriver_xf86-video-ark/Config.in
  source package/x11r7/xdriver_xf86-video-ast/Config.in
package/x11r7/xdriver_xf86-input-tslib/Config.in new file +8 -0
new file mode 100644
index 0000000..4c3f719
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_XDRIVER_XF86_INPUT_TSLIB
+ bool "xf86-input-tslib"
+ select BR2_PACKAGE_XPROTO_INPUTPROTO
+ select BR2_PACKAGE_XSERVER_XORG_SERVER
+ select BR2_PACKAGE_XPROTO_RANDRPROTO
+ select BR2_PACKAGE_XPROTO_XPROTO
+ help
+  Touch screen library input driver
(quoted diff) +0 -0

xdriver_xf86-input-tslib.mk b/package/x11r7/xdriver_xf86-input-tslib/ xdriver_xf86-input-tslib.mk
new file mode 100644
index 0000000..b6455e7

package/x11r7/xdriver_xf86-input-tslib/xdriver_xf86-input-tslib.mk new file +8 -0
@@ -0,0 +1,13 @@
+################################################################################
+#
+# xdriver_xf86-input-tslib -- Touch screen library input driver
+#
+################################################################################
+
+XDRIVER_XF86_INPUT_TSLIB_VERSION = 0.0.6
+XDRIVER_XF86_INPUT_TSLIB_SOURCE =

xf86-input-tslib_$(XDRIVER_XF86_INPUT_TSLIB_VERSION).orig.tar.gz +XDRIVER_XF86_INPUT_TSLIB_SITE =
http://ftp.de.debian.org/debian/pool/main/x/xf86-input-tslib/

package/x11r7/xdriver_xf86-input-tslib/xdriver_xf86-input-tslib.mk new file +2 -0
+XDRIVER_XF86_INPUT_TSLIB_AUTORECONF = NO
+XDRIVER_XF86_INPUT_TSLIB_DEPENDENCIES = xproto_inputproto

xserver_xorg-server xproto_randrproto xproto_xproto
+
+$(eval $(call AUTOTARGETS,package/x11r7,xdriver_xf86-input-tslib))

#3 lore raw

PATCH 1/1 Xorg and Tslib

Thanks for the feedback Michael.

I totally agree that plain text is much better for patches. The problem is that Gmail wraps lines somewhere around 80 characters, as you can see from my first email, and the patch gets all messed up.

I search everywhere in the Gmail configuration and Google forums, and I did not find a way (yet) to disable it.

Anyway, here is the patch again, with the change you suggest:

---
 package/x11r7/Config.in |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
package/x11r7/Config.in +1 -0
index 50816f2..664226f 100644
@@ -174,6 +174,7 @@ endmenu
  source package/x11r7/xdriver_xf86-input-keyboard/Config.in
  source package/x11r7/xdriver_xf86-input-mouse/Config.in
  source package/x11r7/xdriver_xf86-input-synaptics/Config.in
+ source package/x11r7/xdriver_xf86-input-tslib/Config.in
  source package/x11r7/xdriver_xf86-input-vmmouse/Config.in
  source package/x11r7/xdriver_xf86-input-void/Config.in
  source package/x11r7/xdriver_xf86-video-apm/Config.in
Signature · 1 line
1.7.1
#4 lore raw

PATCH 1/1 Xorg and Tslib

In reply to Sergio Prado

Hello,

Le Fri, 23 Dec 2011 20:07:21 -0200,
Sergio Prado <[email protected]> a ?crit :

Quoted 1 line

Sorry, I forgot to send it in rich text format. Here is the patch again:

Please don't include "personal" messages before the "---". Everything which is placed before this "---" marker ends up inside the commit message which is stored forever in the Git history.

Moreover, you should add a Signed-off-by: line to your patch. Some further comments below.

package/x11r7/xdriver_xf86-input-tslib/Config.in line 8

Quoted 10 lines

+++ b/package/x11r7/xdriver_xf86-input-tslib/Config.in

package/x11r7/xdriver_xf86-input-tslib/Config.in new file +8 -0
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_XDRIVER_XF86_INPUT_TSLIB
+ bool "xf86-input-tslib"
+ select BR2_PACKAGE_XPROTO_INPUTPROTO
+ select BR2_PACKAGE_XSERVER_XORG_SERVER
+ select BR2_PACKAGE_XPROTO_RANDRPROTO
+ select BR2_PACKAGE_XPROTO_XPROTO
+ help
+  Touch screen library input driver

Indentation broken here, but it was correct in your first patch. Since your patch is also word-wrapped, I'd recommend either to fix your e-mail client, or better, to use "git send-email" to send your patches (this way you're sure that your e-mail client will not do evil things with the patches).

Quoted 5 lines
package/x11r7/xdriver_xf86-input-tslib/xdriver_xf86-input-tslib.mk new file +2 -0
+XDRIVER_XF86_INPUT_TSLIB_VERSION = 0.0.6
+XDRIVER_XF86_INPUT_TSLIB_SOURCE =

xf86-input-tslib_$(XDRIVER_XF86_INPUT_TSLIB_VERSION).orig.tar.gz +XDRIVER_XF86_INPUT_TSLIB_SITE =
http://ftp.de.debian.org/debian/pool/main/x/xf86-input-tslib/

Instead of Debian, could you use the upstream version available at
http://www.ptxdist.org/software/xf86-input-tslib/download/ ?

Quoted 1 line

+XDRIVER_XF86_INPUT_TSLIB_AUTORECONF = NO

Not needed, this is the default.

Quoted 1 line

+$(eval $(call AUTOTARGETS,package/x11r7,xdriver_xf86-input-tslib))

Since Buildroot 2011.11, this line should be simply:

$(eval $(call AUTOTARGETS))

Regards,

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#5 lore raw

[Buildroot] Thank You

Hello all,

I'd like to thank all contributors for this great piece of work they made for all of us!

Have a happy Christmas and a great, successful new year!

Stephan

Signature · 4 lines
reLinux     -    Stephan Hoffmann
Am Schmidtgrund 124    50765 K?ln
Tel. +49.221.95595-19    Fax: -64
www.reLinux.de     sho at reLinux.de
#6 lore raw

[Buildroot] Thank You

Quoted 4 lines · Stephan Hoffmann

I'd like to thank all contributors for this great piece of work they made for all of us!

Have a happy Christmas and a great, successful new year!

+1
You guys have done outstanding work to buildroot! To excellent times with family and friends, and to 2012!

Cheers,

Bryan Hundven

#7 lore raw

[Buildroot] Thank You

In reply to Stephan Hoffmann

Le Sat, 24 Dec 2011 10:50:58 +0100,
Stephan Hoffmann <[email protected]> a ?crit :

Quoted 2 lines

I'd like to thank all contributors for this great piece of work they made for all of us!

Thanks! Merry Christmas to everyone!

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#8 lore raw

[Buildroot] Thank You

Quoted 8 lines · Thomas Petazzoni

Le Sat, 24 Dec 2011 10:50:58 +0100,
Stephan Hoffmann <[email protected]> a ?crit :

Quoted 2 lines

I'd like to thank all contributors for this great piece of work they made for all of us!

Thanks! Merry Christmas to everyone!

The same from me, Merry Christmas and a great 2012 for all of you!

Although I haven't followed buildroot for that long, I have the impression that quite some infrastructure improvements were made this year. Several new download methods were added, including support for development source trees; a cmake infrastructure was created next to gentargets and autotargets; the board support was completely reworked; there have been quite some changes on the toolchain part; linux and the bootloaders now use gentargets as well; and the documentation was converted to asciidoc.

Looking at these achievements, I'm looking forward to seeing the changes in 2012!

All the best,
Thomas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20111224/7b7499df/attachment.html>

#9 lore raw

[Buildroot] Thank You

Quoted 22 lines · Thomas De Schampheleire
Quoted 8 lines · Thomas Petazzoni

Le Sat, 24 Dec 2011 10:50:58 +0100,
Stephan Hoffmann <[email protected]> a ?crit :

Quoted 2 lines

I'd like to thank all contributors for this great piece of work they made for all of us!

Thanks! Merry Christmas to everyone!

The same from me, Merry Christmas and a great 2012 for all of you!

Although I haven't followed buildroot for that long, I have the impression that quite some infrastructure improvements were made this year. Several new download methods were added, including support for development source trees; a cmake infrastructure was created next to gentargets and autotargets; the board support was completely reworked; there have been quite some changes on the toolchain part; linux and the bootloaders now use gentargets as well; and the documentation was converted to asciidoc.

Quoted 2 lines

Looking at these achievements, I'm looking forward to seeing the changes in 2012!

Merry Christmas and Happy New Year from me too!

There were really a lot of improvements in BR this year. I hope next year will bring even more. Let's make it real.

Yegor