Skip to contentSkip to conversation

ARM: S3C64XX: Reduce residency requirement for cpuidle WFI mode

PATCH New Mark Brown 2 participants 4 messages Dec 26, 2011 – Dec 30, 2011

Subsystems (3)
lore
Share & tools
lore

Mark Brown

author
#0 lore raw

PATCH 1/1 ARM: S3C64XX: Reduce residency requirement for cpuidle WFI mode

Entering and leaving WFI is really cheap so there's no reason to have much of a residency requirement for the state. Lower it to 1ms.

---
 arch/arm/mach-s3c64xx/cpuidle.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach-s3c64xx/cpuidle.c +1 -1
index 625d2c7..179460f 100644
@@ -55,7 +55,7 @@ static struct cpuidle_state s3c64xx_cpuidle_set[] = {
 	[0] = {
 		.enter			= s3c64xx_enter_idle,
 		.exit_latency		= 1,
-		.target_residency	= 100000,
+		.target_residency	= 1,
 		.flags			= CPUIDLE_FLAG_TIME_VALID,
 		.name			= "IDLE",
 		.desc			= "System active, ARM gated",
Signature · 1 line
1.7.7.3
#1 lore raw

PATCH 1/1 ARM: S3C64XX: Reduce residency requirement for cpuidle WFI mode

Quoted 24 lines · Mark Brown

Entering and leaving WFI is really cheap so there's no reason to have much of a residency requirement for the state. Lower it to 1ms.

---
 arch/arm/mach-s3c64xx/cpuidle.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach- renamed from arch/arm/mach-s3c64xx/cpuidle.c +0 -0

s3c64xx/cpuidle.c
index 625d2c7..179460f 100644

arch/arm/mach-s3c64xx/cpuidle.c +1 -2
@@ -55,7 +55,7 @@ static struct cpuidle_state s3c64xx_cpuidle_set[] = {
 	[0] = {
 		.enter			= s3c64xx_enter_idle,
 		.exit_latency		= 1,
-		.target_residency	= 100000,
+		.target_residency	= 1,
 		.flags			= CPUIDLE_FLAG_TIME_VALID,
 		.name			= "IDLE",
 		.desc			= "System active, ARM gated",
--
Quoted 1 line

1.7.7.3

OK, will apply.
Mark, do you want to send this before v3.2?

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.

author
#2 lore raw

PATCH 1/1 ARM: S3C64XX: Reduce residency requirement for cpuidle WFI mode

Quoted 10 lines · Kukjin Kim

arch/arm/mach-s3c64xx/cpuidle.c static struct cpuidle_state s3c64xx_cpuidle_set[] = { · line 58

Quoted 5 lines · Mark Brown

Entering and leaving WFI is really cheap so there's no reason to have much of a residency requirement for the state. Lower it to 1ms.

arch/arm/mach-s3c64xx/cpuidle.c +1 -1
-		.target_residency	= 100000,
+		.target_residency	= 1,

OK, will apply.
Mark, do you want to send this before v3.2?

It doesn't seem super urgent, though it'd be nice to get it into 3.3 with the original patch adding the support.

#3 lore raw

PATCH 1/1 ARM: S3C64XX: Reduce residency requirement for cpuidle WFI mode

Quoted 8 lines · Mark Brown
Quoted 3 lines · Kukjin Kim
Quoted 1 line · Mark Brown

Entering and leaving WFI is really cheap so there's no reason to have

much

Quoted 1 line
Quoted 1 line

of a residency requirement for the state. Lower it to 1ms.

Quoted 8 lines
Quoted 5 lines

arch/arm/mach-s3c64xx/cpuidle.c static struct cpuidle_state s3c64xx_cpuidle_set[] = { · line 58

Quoted 2 lines
arch/arm/mach-s3c64xx/cpuidle.c +1 -1
-		.target_residency	= 100000,
+		.target_residency	= 1,

OK, will apply.
Mark, do you want to send this before v3.2?

It doesn't seem super urgent, though it'd be nice to get it into 3.3 with the original patch adding the support.

Ah, OK, I've applied this with that.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.