Skip to contentSkip to conversation

ARM: S3C64XX: Fix interrupt configuration for PCA935x on Cragganmore

PATCH New Mark Brown 2 participants 4 messages Dec 29, 2011 – Dec 30, 2011

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm Samsung Exynos
lore
Share & tools
lore

Mark Brown

author
#0 lore raw

PATCH 1/1 ARM: S3C64XX: Fix interrupt configuration for PCA935x on Cragganmore

0 is a valid IRQ but the interrupt line for the pca935x certainly isn't connected there which causes it to fail to probe.

Signed-off-by Mark Brown <[email protected]>
---
 arch/arm/mach-s3c64xx/mach-crag6410.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach-s3c64xx/mach-crag6410.c +1 -1
index 46dfb14..139d16e 100644
@@ -357,7 +357,7 @@ static struct platform_device *crag6410_devices[] __initdata = {
 
 static struct pca953x_platform_data crag6410_pca_data = {
 	.gpio_base	= PCA935X_GPIO_BASE,
-	.irq_base	= 0,
+	.irq_base	= -1,
 };
 
 /* VDDARM is controlled by DVS1 connected to GPK(0) */
Signature · 1 line
1.7.7.3
#1 lore raw

PATCH 1/1 ARM: S3C64XX: Fix interrupt configuration for PCA935x on Cragganmore

Quoted 23 lines · Mark Brown

0 is a valid IRQ but the interrupt line for the pca935x certainly isn't connected there which causes it to fail to probe.

Signed-off-by Mark Brown <[email protected]>
---
 arch/arm/mach-s3c64xx/mach-crag6410.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach- renamed from arch/arm/mach-s3c64xx/mach-crag6410.c +0 -0

s3c64xx/mach-crag6410.c
index 46dfb14..139d16e 100644

arch/arm/mach-s3c64xx/mach-crag6410.c +1 -1
@@ -357,7 +357,7 @@ static struct platform_device *crag6410_devices[]
 __initdata = {
 
 static struct pca953x_platform_data crag6410_pca_data = {
 	.gpio_base	= PCA935X_GPIO_BASE,
-	.irq_base	= 0,
+	.irq_base	= -1,
 };
Quoted 3 lines

/* VDDARM is controlled by DVS1 connected to GPK(0) */
--
1.7.7.3

OK, so do you want to apply this before v3.2?

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.

author
#2 lore raw

PATCH 1/1 ARM: S3C64XX: Fix interrupt configuration for PCA935x on Cragganmore

Quoted 1 line · Kukjin Kim

OK, so do you want to apply this before v3.2?

The problem is mostly cosmetic as the chip isn't actually used by current cosmetics so no need to try to get it into 3.2.

#3 lore raw

PATCH 1/1 ARM: S3C64XX: Fix interrupt configuration for PCA935x on Cragganmore

Quoted 7 lines · Mark Brown
Quoted 1 line · Kukjin Kim

OK, so do you want to apply this before v3.2?

The problem is mostly cosmetic as the chip isn't actually used by current cosmetics so no need to try to get it into 3.2.

OK, I see.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.