omap: add rcu_locking to omap2_set_init_voltage.
PATCH 1/1 omap: add rcu_locking to omap2_set_init_voltage.
opp_find_freq_ceil and opp_get_voltage are documented as requiring rcu_lock to be held. So hold it.
Signed-off-by NeilBrown <[email protected]>
arch/arm/mach-omap2/pm.c +3 -0
@@ -174,14 +174,17 @@ static int __init omap2_set_init_voltage(char *vdd_name, char *clk_name, freq = clk->rate;clk_put (clk); +rcu_read_lock (); opp =opp_find_freq_ceil (dev, &freq);if (IS_ERR (opp)) { +rcu_read_unlock ();pr_err ("%s: unable to find boot up OPP for vdd_%s\n" , __func__, vdd_name); goto exit; } bootup_volt =opp_get_voltage (opp); +rcu_read_unlock ();if (!bootup_volt) {pr_err ("%s: unable to find voltage corresponding " "to the bootup OPP for vdd_%s\n" , __func__, vdd_name);
Quoted 4 lines · NeilBrown
opp_find_freq_ceilandopp_get_voltageare documented as requiringrcu_lockto be held. So hold it.Signed-off-by NeilBrown <[email protected]>
Looks good, thanks for the patch.
Do you mind reposting with [email protected] in CC, and also use the 'ARM:' prefix in the subject as requested by the arm-soc maintainers.
After that, I'll queue it as a fix for v3.3,
Thanks,
Kevin