Skip to contentSkip to conversation

usb: gadget: mv_udc: remove unneeded NULL check

PATCH Applied Dan Carpenter 2 participants 2 messages Jan 4, 2012 – Jan 24, 2012

Subsystems (2)
USB Kernel janitors
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 usb: gadget: mv_udc: remove unneeded NULL check

We've dereferenced req already, and we checked for bogus parameters at the start of the function.

Signed-off-by Dan Carpenter <[email protected]>
drivers/usb/gadget/mv_udc_core.c +1 -2
index f97e737..8dd398b 100644
@@ -771,8 +771,7 @@ mv_ep_queue(struct usb_ep *_ep, struct usb_request *_req, gfp_t gfp_flags)
 		udc->ep0_state = DATA_STATE_XMIT;
 
 	/* irq handler advances the queue */
-	if (req != NULL)
-		list_add_tail(&req->queue, &ep->queue);
+	list_add_tail(&req->queue, &ep->queue);
 	spin_unlock_irqrestore(&udc->lock, flags);
 
 	return 0;