ext4: release donor reference when EXT4_IOC_MOVE_EXT ioctl fails

PATCH Applied Djalal Harouni 2 participants 2 messages Jan 6, 2012 – Sep 27, 2012 ext4 file system

Share & tools

Djalal Harouni

author

2012-01-06 21:47 UTC #0 lore raw

PATCH 1/1 ext4: release donor reference when EXT4_IOC_MOVE_EXT ioctl fails

When the EXT4_IOC_MOVE_EXT ioctl() fails on bigalloc file systems, we should jump to the 'mext_out' label to release the donor file reference.

Signed-off-by Djalal Harouni <[email protected]>

---
 fs/ext4/ioctl.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

fs/ext4/ioctl.c +2 -1

index a567968..034e147 100644
@@ -237,7 +237,8 @@ setversion_out:
 			       EXT4_FEATURE_RO_COMPAT_BIGALLOC)) {
 			ext4_msg(sb, KERN_ERR,
 				 "Online defrag not supported with bigalloc");
-			return -EOPNOTSUPP;
+			err = -EOPNOTSUPP;
+			goto mext_out;
 		}
 
 		err = mnt_want_write(filp->f_path.mnt);

Signature · 1 line

1.7.1

Theodore Ts'o

maintainer Applied

2012-09-27 02:59 UTC #1 lore raw

Quoted 4 lines · Djalal Harouni

When the EXT4_IOC_MOVE_EXT ioctl() fails on bigalloc file systems, we should jump to the 'mext_out' label to release the donor file reference.
Signed-off-by Djalal Harouni <[email protected]>

Thanks, applied!

- Ted