Skip to contentSkip to conversation

autotools ./configure don't like compat.h

PATCH In review David Sommerseth 4 participants 4 messages Jan 11, 2012

lore
Share & tools
lore

David Sommerseth

author
#0 lore raw

PATCH 1/1 autotools ./configure don't like compat.h

The compat.h include file cannot be loaded when ./configure runs, as many of the HAVE_* declarations are not set. This makes test compilations when looking for features fail.

As ./configure will load syshead.h, it pulls in compat.h this way. Looking more carefully at syshead.h, there's a #ifndef PACKAGE_NAME check if config.h should be included. This looks like a check if syshead.h is loaded via ./configure or if it is a more normal compilation. Moving the compat.h inclusion into this #ifndef block.

Signed-off-by David Sommerseth <[email protected]...>
---
 syshead.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
syshead.h +1 -1
index fba6f84..f121114 100644
@@ -34,9 +34,9 @@
 #endif
 #ifndef PACKAGE_NAME
 #include "config.h"
+#include "compat.h"
 #endif
 
-#include "compat.h"
 
 /* branch prediction hints */
 #if defined(__GNUC__)
Signature · 1 line
1.7.4.4
#1 lore raw

Hi,

Quoted 9 lines · David Sommerseth

The compat.h include file cannot be loaded when ./configure runs, as many of the HAVE_* declarations are not set. This makes test compilations when looking for features fail.

As ./configure will load syshead.h, it pulls in compat.h this way. Looking more carefully at syshead.h, there's a #ifndef PACKAGE_NAME check if config.h should be included. This looks like a check if syshead.h is loaded via ./configure or if it is a more normal compilation. Moving the compat.h inclusion into this #ifndef block.

As I've seen you testing this on IRC and this fixes things -> ACK :)

gert

Signature · 4 lines
USENET is *not* the non-clickable part of WWW!
                                                           //www.muc.de/~gert/
Gert Doering - Munich, Germany                             [email protected]...
fax: +49-89-35655025                        [email protected]...
#2 lore raw
In reply to David Sommerseth

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 4 lines · David Sommerseth

The compat.h include file cannot be loaded when ./configure runs, as many of the HAVE_* declarations are not set. This makes test compilations when looking for features fail.

Quoted 8 lines

As ./configure will load syshead.h, it pulls in compat.h this way. Looking more carefully at syshead.h, there's a #ifndef PACKAGE_NAME check if config.h should be included. This looks like a check if syshead.h is loaded via ./configure or if it is a more normal compilation. Moving the compat.h inclusion into this #ifndef block.

Signed-off-by David Sommerseth <[email protected]...> --- syshead.h |

2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

Applied to master branches on -stable and -testing trees.

commit 330baf2aee70b351cce2d138299118837adbe237

Author: David Sommerseth <[email protected]...>
Date:   Wed Jan 11 14:52:21 2012 +0100
    Signed-off-by: David Sommerseth <[email protected]...>
    Acked-by: Gert Doering <[email protected]...>

kind regards,

David Sommerseth
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk8N4F0ACgkQDC186MBRfrrKXACgl9S32mQ5DXHZwuI8VEyykoSm Hi8AoLF2f1+NEd32qflZIqn4f812CbG3
=6SVX
-----END PGP SIGNATURE-----

#3 lore raw

The syshead.h is totally invalid and should be revised long time ago.

Most of the tests within the syshead.h should be done using autoconf and inject into config.h.

This way, there is a single point of platform specific tests.

Quoted 50 lines · David Sommerseth

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 4 lines · David Sommerseth

The compat.h include file cannot be loaded when ./configure runs, as many of the HAVE_* declarations are not set.  This makes test compilations when looking for features fail.

Quoted 8 lines

As ./configure will load syshead.h, it pulls in compat.h this way. Looking more carefully at syshead.h, there's a #ifndef PACKAGE_NAME check if config.h should be included.  This looks like a check if syshead.h is loaded via ./configure or if it is a more normal compilation.  Moving the compat.h inclusion into this #ifndef block.

Signed-off-by David Sommerseth <[email protected]...> --- syshead.h |

2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

Applied to master branches on -stable and -testing trees.

commit 330baf2aee70b351cce2d138299118837adbe237
Author: David Sommerseth <[email protected]...>
Date:   Wed Jan 11 14:52:21 2012 +0100

Signed-off-by David Sommerseth <[email protected]...>
Acked-by Gert Doering <[email protected]...>

kind regards,

David Sommerseth
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk8N4F0ACgkQDC186MBRfrrKXACgl9S32mQ5DXHZwuI8VEyykoSm Hi8AoLF2f1+NEd32qflZIqn4f812CbG3
=6SVX
-----END PGP SIGNATURE-----

------------------------------------------------------------------------------
Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex infrastructure or vast IT resources to deliver seamless, secure access to virtual desktops. With this all-in-one solution, easily deploy virtual desktops for less than the cost of PCs and save 60% on VDI infrastructure costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox
_______________________________________________
Openvpn-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel