dmaengine: shdma: add IRQ resource name definition macros
PATCH v4 1/6 dmaengine: shdma: add IRQ resource name definition macros
The SH DMAC has an ERROR IRQ and channel IRQs. So, the defination macros are used as the resource name, and the resource name will be used to detect each IRQ by the driver.
---
about v4:
- add defination macros for IRQ resource first.
include/linux/sh_dma.h | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)
include/linux/sh_dma.h +4 -0
@@ -13,6 +13,10 @@#include <linux/list.h> #include <linux/dmaengine.h> +/* resource name of IORESOURCE_IRQ */ +#define SH_DMA_IRQ_ERROR "error" +#define SH_DMA_IRQ_CHANNEL "channel" +/* Used by slave DMA clients to request DMA to/from a specific peripheral */ struct sh_dmae_slave {unsigned int slave_id;/* Set by the platform */
Signature · 1 line
1.7.1
Quoted 17 lines · Yoshihiro
The SH DMAC has an ERROR IRQ and channel IRQs. So, the defination macros are used as the resource name, and the resource name will be used to detect each IRQ by the driver.
Signed-off-by Yoshihiro Shimoda <[email protected]>---
about v4:
- add defination macros for IRQ resource first.include/linux/sh_dma.h | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)include/linux/sh_dma.h +0
-0
include/linux/sh_dma.h line 19
Quoted 7 lines
include/linux/sh_dma.h +4
-0@@ -13,6 +13,10 @@#include <linux/list.h> #include <linux/dmaengine.h> +/* resource name of IORESOURCE_IRQ */ +#define SH_DMA_IRQ_ERROR "error" +#define SH_DMA_IRQ_CHANNEL "channel" +
Why? This is just pointless churn, there's nothing wrong with using the strings open-coded like the vast majority of other drivers/platforms do without issue. If you can't spell it properly, too bad.
Quoted 21 lines · Paul Mundt
Quoted 20 lines · Yoshihiro
The SH DMAC has an ERROR IRQ and channel IRQs. So, the defination macros are used as the resource name, and the resource name will be used to detect each IRQ by the driver.
Signed-off-by Yoshihiro Shimoda <[email protected]>---
about v4:
- add defination macros for IRQ resource first.include/linux/sh_dma.h | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)include/linux/sh_dma.h +0
-0@@ -13,6 +13,10 @@#include <linux/list.h> #include <linux/dmaengine.h>
Quoted 8 lines
include/linux/sh_dma.h line 19
Quoted 4 lines
include/linux/sh_dma.h +4
-0+/* resource name of IORESOURCE_IRQ */ +#define SH_DMA_IRQ_ERROR "error" +#define SH_DMA_IRQ_CHANNEL "channel" +Why? This is just pointless churn, there's nothing wrong with using the strings open-coded like the vast majority of other
drivers/platformsdo without issue. If you can't spell it properly, too bad.
Thank you for your point.
I read your comment, I thought that it is good.
I am mixed up about the shdma driver patch for the Error IRQ registration... I am thinking that the v3 patches are good because they have Paul's "Acked-by".
Best regards,
Yoshihiro Shimoda
Quoted 31 lines · Yoshihiro
Quoted 21 lines · Paul Mundt
Quoted 20 lines · Yoshihiro
The SH DMAC has an ERROR IRQ and channel IRQs. So, the defination macros are used as the resource name, and the resource name will be used to detect each IRQ by the driver.
Signed-off-by Yoshihiro Shimoda <[email protected]>---
about v4:
- add defination macros for IRQ resource first.include/linux/sh_dma.h | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)include/linux/sh_dma.h +0
-0@@ -13,6 +13,10 @@#include <linux/list.h> #include <linux/dmaengine.h> Quoted 8 lines
include/linux/sh_dma.h line 19
Quoted 4 lines
include/linux/sh_dma.h +4
-0+/* resource name of IORESOURCE_IRQ */ +#define SH_DMA_IRQ_ERROR "error" +#define SH_DMA_IRQ_CHANNEL "channel" +Why? This is just pointless churn, there's nothing wrong with using the strings open-coded like the vast majority of other
drivers/platformsdo without issue. If you can't spell it properly, too bad.
Quoted 6 lines
Thank you for your point.
I read your comment, I thought that it is good.I am mixed up about the shdma driver patch for the Error IRQ registration... I am thinking that the v3 patches are good because they have Paul's "Acked-by".
Yes, the v3 patches are fine. There's no particular need for stop-gap transition patches as we'll have these error string patches in place for the relevant platforms long before these patches hit mainline, and anything out of tree obviously doesn't matter.