Skip to contentSkip to conversation

drm/i915: remove ACPI related DRM_ERRORs

PATCH Jesse Barnes 4 participants 5 messages Jan 12, 2012 – Jan 16, 2012

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

They're not really errors (well actually I don't know; I don't understand _DSM and _MUX well enough to say, but I do know they spam people's logs and seem to be harmless).

drivers/gpu/drm/i915/intel_acpi.c +0 -3
index cb91210..01c671f 100644
@@ -182,8 +182,6 @@ static void intel_dsm_platform_mux_info(void)
 			DRM_DEBUG_DRIVER("  hpd mux info: %s\n",
 			       intel_dsm_mux_type(info->buffer.pointer[3]));
 		}
-	} else {
-		DRM_ERROR("MUX INFO call failed\n");
 	}
 
 out:
@@ -208,7 +206,6 @@ static bool intel_dsm_pci_probe(struct pci_dev *pdev)
 
 	ret = intel_dsm(dhandle, INTEL_DSM_FN_SUPPORTED_FUNCTIONS, 0);
 	if (ret < 0) {
-		DRM_ERROR("failed to get supported _DSM functions\n");
 		return false;
 	}
 

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw
Quoted 6 lines · On Thu, 12 Jan 2012 09:20:20 -0800 Keith Packard <[email protected]> wrote:
Quoted 3 lines · Jesse Barnes

They're not really errors (well actually I don't know; I don't understand _DSM and _MUX well enough to say, but I do know they spam people's logs and seem to be harmless).

Maybe change them to DRM_DEBUG_DRIVER?

Thought about that, but I don't even know what these failures mean in real life, so having debug output for them is also superfluous.

Maybe Matthew or Dave have ideas? AFAIK these bits are only for switchable gfx configs anyway...

Signature · 1 line
Jesse Barnes, Intel Open Source Technology Center

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reviewed-by
#3 lore raw
In reply to Jesse Barnes
Quoted 3 lines · Jesse Barnes

They're not really errors (well actually I don't know; I don't understand _DSM and _MUX well enough to say, but I do know they spam people's logs and seem to be harmless).

Looks familiar!

http://lists.freedesktop.org/archives/intel-gfx/2011-September/011994.html
http://lists.freedesktop.org/archives/intel-gfx/2011-October/012563.html

- ajax

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw
Quoted 11 lines · Adam Jackson
Quoted 3 lines · Jesse Barnes

They're not really errors (well actually I don't know; I don't understand _DSM and _MUX well enough to say, but I do know they spam people's logs and seem to be harmless).

Looks familiar!

http://lists.freedesktop.org/archives/intel-gfx/2011-September/011994.html
http://lists.freedesktop.org/archives/intel-gfx/2011-October/012563.html

I've picked up the old one ;-)
-Daniel

Signature · 3 lines
Daniel Vetter
Mail: [email protected]
Mobile: +41 (0)79 365 57 48