Skip to contentSkip to conversation

ethtool: bump to 3.2

PATCH New yegorslists at googlemail.com 4 participants 13 messages Jan 16, 2012 – Jan 17, 2012

lore
Share & tools
lore

yegorslists at googlemail.com

author
#0 lore raw

PATCH 1/2 ethtool: bump to 3.2

From: Yegor Yefremov <[email protected]>

Signed-off-by Yegor Yefremov <[email protected]>
---
 package/ethtool/ethtool.mk |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
package/ethtool/ethtool.mk +1 -1
index 04f7dac..101d0a1 100644
@@ -4,7 +4,7 @@
 #
 #############################################################
 
-ETHTOOL_VERSION = 3.1
+ETHTOOL_VERSION = 3.2
 ETHTOOL_SITE = $(BR2_KERNEL_MIRROR)/software/network/ethtool
 
 $(eval $(call AUTOTARGETS))
Signature · 1 line
1.7.1.1
author
#1 lore raw

PATCH 2/2 New package: kmod

From: Yegor Yefremov <[email protected]>

Signed-off-by Yegor Yefremov <[email protected]>
---
 package/Config.in      |    1 +
 package/kmod/Config.in |    7 +++++++
 package/kmod/kmod.mk   |    8 ++++++++
 3 files changed, 16 insertions(+), 0 deletions(-)
 create mode 100644 package/kmod/Config.in
 create mode 100644 package/kmod/kmod.mk
package/Config.in +1 -0
index 1042d95..2d0550f 100644
@@ -557,6 +557,7 @@ if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
 source "package/bootutils/Config.in"
 endif
 source "package/htop/Config.in"
+source "package/kmod/Config.in"
 if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
 source "package/module-init-tools/Config.in"
 source "package/procps/Config.in"
package/kmod/Config.in new file +7 -0
new file mode 100644
index 0000000..f83237e
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_KMOD
+	bool "kmod"
+	help
+	  handle kernel modules
+
+	  http://git.profusion.mobi/cgit.cgi/kmod.git/
+
package/kmod/kmod.mk new file +8 -0
new file mode 100644
index 0000000..1d21296
@@ -0,0 +1,8 @@
+KMOD_VERSION = 3
+KMOD_SOURCE = kmod-$(KMOD_VERSION).tar.bz2
+KMOD_SITE = http://git.profusion.mobi/cgit.cgi/kmod.git/snapshot
+KMOD_INSTALL_STAGING =YES
+KMOD_AUTORECONF = YES
+
+$(eval $(call AUTOTARGETS))
+
Signature · 1 line
1.7.1.1
#2 lore raw

PATCH 2/2 New package: kmod

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"yegorslists" == yegorslists <[email protected]> writes:

yegorslists> From: Yegor Yefremov <[email protected]> yegorslists> Signed-off-by: Yegor Yefremov <[email protected]>

You were missing a host-pkg-config dependency. I've fixed that and committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#3 lore raw

PATCH 2/2 New package: kmod

In reply to yegorslists at googlemail.com

package/kmod/Config.in line 6

Quoted 12 lines · On Monday 16 January 2012 16:04:36 yegorslists at googlemail.com wrote:
package/kmod/Config.in new file +6 -0
new file mode 100644
index 0000000..f83237e
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_KMOD
+	bool "kmod"
+	help
+	  handle kernel modules
+
+	  http://git.profusion.mobi/cgit.cgi/kmod.git/

It would be nice if there was a config option to disable installing
the tools, in case you want to use it as a library (which is probably the primary intention).

That option should set
KMOD_INSTALL_STAGING = NO
KMOD_CONF_OPT += --disable-tools

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#4 lore raw

PATCH 2/2 New package: kmod

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Arnout" == Arnout Vandecappelle <[email protected]> writes:

Quoted 4 lines · Arnout> On Monday 16 January 2012 16:04:36 yegorslists at googlemail.com wrote:
Quoted 4 lines
package/kmod/Config.in new file +0 -1
new file mode 100644
index 0000000..f83237e
--- /dev/null
Quoted 8 lines

package/kmod/Config.in line 6

Quoted 8 lines

+++ b/package/kmod/Config.in

package/kmod/Config.in new file +6 -0
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_KMOD
+	bool "kmod"
+	help
+	  handle kernel modules
+
+	  http://git.profusion.mobi/cgit.cgi/kmod.git/

Arnout> It would be nice if there was a config option to disable installing Arnout> the tools, in case you want to use it as a library (which is probably Arnout> the primary intention).

True. /usr/bin/kmod is 88k, so not huge - But ok.

Arnout> That option should set
Arnout> KMOD_INSTALL_STAGING = NO

Why would you not install into staging?

Arnout> KMOD_CONF_OPT += --disable-tools

Signature · 1 line
Bye, Peter Korsgaard
#5 lore raw

PATCH 2/2 New package: kmod

Quoted 18 lines · On Monday 16 January 2012 20:27:20 Peter Korsgaard wrote:
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Arnout" == Arnout Vandecappelle <[email protected]> writes:

Quoted 4 lines · Arnout> On Monday 16 January 2012 16:04:36 yegorslists at googlemail.com wrote:
Quoted 4 lines
package/kmod/Config.in new file +0 -1
new file mode 100644
index 0000000..f83237e
--- /dev/null
Quoted 8 lines

package/kmod/Config.in line 6

Quoted 8 lines

+++ b/package/kmod/Config.in

package/kmod/Config.in new file +6 -0
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_KMOD
+	bool "kmod"
+	help
+	  handle kernel modules
+
+	  http://git.profusion.mobi/cgit.cgi/kmod.git/

Arnout> That option should set
Arnout> KMOD_INSTALL_STAGING = NO

Quoted 1 line

Why would you not install into staging?

That should me KMOD_INSTALL_TARGET, of course.

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#6 lore raw

PATCH 2/2 New package: kmod

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Arnout" == Arnout Vandecappelle <[email protected]> writes:

Arnout> That option should set
Arnout> KMOD_INSTALL_STAGING = NO

Quoted 2 lines
Quoted 2 lines

Why would you not install into staging?

Arnout> That should me KMOD_INSTALL_TARGET, of course.

You would still need to install the shared library, so we should rather remove the binary instead.

Signature · 1 line
Bye, Peter Korsgaard
author
#7 lore raw

PATCH 2/2 New package: kmod

Quoted 11 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Arnout" == Arnout Vandecappelle <[email protected]> writes:

?Arnout> That option should set
?Arnout> KMOD_INSTALL_STAGING = NO
?>>
?>> Why would you not install into staging?

?Arnout> ?That should me KMOD_INSTALL_TARGET, of course.

You would still need to install the shared library, so we should rather remove the binary instead.

I added this package, because it is udev's dependency now. I'll have to look into udev, to tell if it uses only library or binary too.

As we came to this topic, what is your opinion on adding /run? It also became udev's dependency.

I'll set my udev's patch series tomorrow.

Yegor

#8 lore raw

PATCH 2/2 New package: kmod

Quoted 7 lines · Yegor Yefremov

I added this package, because it is udev's dependency now. I'll have to look into udev, to tell if it uses only library or binary too. As we came to this topic, what is your opinion on adding /run? It also became udev's dependency. I'll set my udev's patch series tomorrow. Yegor _______________________________________________ buildroot mailing list buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

udev byself needs only the lib. the binarys can be used as insmod/rmmod/modprobe/modinfo replacement from module-init-tools or busybox's solution. the "kmod" binary byself is a multicall binary so insmod/rmmod/... can be symlinks to this binary.

Stephan

#9 lore raw

PATCH 2/2 New package: kmod

In reply to Yegor Yefremov
Quoted 2 lines · On Tuesday 17 January 2012 23:13:08 Yegor Yefremov wrote:

As we came to this topic, what is your opinion on adding /run? It also became udev's dependency.

IIRC /run basically replaces /var/run in Fedora, Debian, SuSE and others.
Since we anyway symlink /var/run to /tmp, we can easily do the same for /run.

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#10 lore raw

PATCH 2/2 New package: kmod

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Arnout" == Arnout Vandecappelle <[email protected]> writes:

Quoted 2 lines · Arnout> On Tuesday 17 January 2012 23:13:08 Yegor Yefremov wrote:
Quoted 2 lines

As we came to this topic, what is your opinion on adding /run? It also became udev's dependency.

Arnout> IIRC /run basically replaces /var/run in Fedora, Debian, SuSE Arnout> and others. Since we anyway symlink /var/run to /tmp, we can Arnout> easily do the same for /run.

That's my understanding as well. I don't have any issues with adding a /run symlink to fs/skeleton.

Signature · 1 line
Bye, Peter Korsgaard
author
#11 lore raw

PATCH 2/2 New package: kmod

Quoted 6 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Arnout" == Arnout Vandecappelle <[email protected]> writes:

?Arnout> On Tuesday 17 January 2012 23:13:08 Yegor Yefremov wrote:
?>> As we came to this topic, what is your opinion on adding /run? It also ?>> became udev's dependency.

Quoted 6 lines

?Arnout> ?IIRC /run basically replaces /var/run in Fedora, Debian, SuSE ?Arnout> and others. ?Since we anyway symlink /var/run to /tmp, we can ?Arnout> easily do the same for /run.

That's my understanding as well. I don't have any issues with adding a /run symlink to fs/skeleton.

O.K. I'll prepare the patch.

Yegor