Skip to contentSkip to conversation

ARM: mx28: Let audio support be built by default

PATCH Superseded Fabio Estevam 5 participants 7 messages Dec 29, 2011 – Jan 27, 2012

Subsystems (2)
Arm (32-bit) Arm i.MX and Layerscape
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 ARM: mx28: Let audio support be built by default

Let audio support be built by default.

As sgtl5000 codec is connected via I2C, let MXS I2C driver also be built by default.

Signed-off-by Fabio Estevam <[email protected]>
---
 arch/arm/configs/mxs_defconfig |   19 ++++++++++++++++---
 1 files changed, 16 insertions(+), 3 deletions(-)
arch/arm/configs/mxs_defconfig +16 -3
index 6ee781b..4a13f93 100644
@@ -77,10 +77,10 @@ CONFIG_DEVPTS_MULTIPLE_INSTANCES=y
 CONFIG_SERIAL_AMBA_PL011=y
 CONFIG_SERIAL_AMBA_PL011_CONSOLE=y
 # CONFIG_HW_RANDOM is not set
-CONFIG_I2C=m
+CONFIG_I2C=y
 # CONFIG_I2C_COMPAT is not set
-CONFIG_I2C_CHARDEV=m
-CONFIG_I2C_MXS=m
+CONFIG_I2C_CHARDEV=y
+CONFIG_I2C_MXS=y
 CONFIG_SPI=y
 CONFIG_SPI_GPIO=m
 CONFIG_DEBUG_GPIO=y

@@ -90,6 +90,19 @@ CONFIG_GPIO_SYSFS=y
 CONFIG_DISPLAY_SUPPORT=m
 # CONFIG_HID_SUPPORT is not set
 # CONFIG_USB_SUPPORT is not set
+CONFIG_SOUND=y
+CONFIG_SND=y
+CONFIG_SND_TIMER=y
+CONFIG_SND_PCM=y
+CONFIG_SND_JACK=y
+CONFIG_SND_DRIVERS=y
+CONFIG_SND_ARM=y
+CONFIG_SND_SPI=y
+CONFIG_SND_SOC=y
+CONFIG_SND_MXS_SOC=y
+CONFIG_SND_SOC_MXS_SGTL5000=y
+CONFIG_SND_SOC_I2C_AND_SPI=y
+CONFIG_SND_SOC_SGTL5000=y
 CONFIG_MMC=y
 CONFIG_MMC_MXS=y
 CONFIG_RTC_CLASS=y
Signature · 1 line
1.7.1
#1 lore raw

PATCH 1/1 ARM: mx28: Let audio support be built by default

Quoted 38 lines

Let audio support be built by default.

As sgtl5000 codec is connected via I2C, let MXS I2C driver also be built by default.

Signed-off-by Fabio Estevam <[email protected]>
---
 arch/arm/configs/mxs_defconfig |   19 ++++++++++++++++---
 1 files changed, 16 insertions(+), 3 deletions(-)
(quoted diff) +0 -0

b/arch/arm/configs/mxs_defconfig index 6ee781b..4a13f93 100644

arch/arm/configs/mxs_defconfig +9 -3
@@ -77,10 +77,10 @@ CONFIG_DEVPTS_MULTIPLE_INSTANCES=y
 CONFIG_SERIAL_AMBA_PL011=y
 CONFIG_SERIAL_AMBA_PL011_CONSOLE=y
 # CONFIG_HW_RANDOM is not set
-CONFIG_I2C=m
+CONFIG_I2C=y
 # CONFIG_I2C_COMPAT is not set
-CONFIG_I2C_CHARDEV=m
-CONFIG_I2C_MXS=m
+CONFIG_I2C_CHARDEV=y
+CONFIG_I2C_MXS=y
 CONFIG_SPI=y
 CONFIG_SPI_GPIO=m
 CONFIG_DEBUG_GPIO=y

@@ -90,6 +90,19 @@ CONFIG_GPIO_SYSFS=y
 CONFIG_DISPLAY_SUPPORT=m
 # CONFIG_HID_SUPPORT is not set
 # CONFIG_USB_SUPPORT is not set
+CONFIG_SOUND=y
+CONFIG_SND=y
+CONFIG_SND_TIMER=y
+CONFIG_SND_PCM=y
+CONFIG_SND_JACK=y
+CONFIG_SND_DRIVERS=y

arch/arm/configs/mxs_defconfig CONFIG_GPIO_SYSFS=y · line 108

Quoted 10 lines
arch/arm/configs/mxs_defconfig +7 -0
+CONFIG_SND_ARM=y
+CONFIG_SND_SPI=y
+CONFIG_SND_SOC=y
+CONFIG_SND_MXS_SOC=y
+CONFIG_SND_SOC_MXS_SGTL5000=y
+CONFIG_SND_SOC_I2C_AND_SPI=y
+CONFIG_SND_SOC_SGTL5000=y
 CONFIG_MMC=y
 CONFIG_MMC_MXS=y
 CONFIG_RTC_CLASS=y
Acked-by Marek Vasut <[email protected]>
#2 lore raw

PATCH 1/1 ARM: mx28: Let audio support be built by default

In reply to Fabio Estevam
Quoted 10 lines · Fabio Estevam

Let audio support be built by default.

As sgtl5000 codec is connected via I2C, let MXS I2C driver also be built by default.

Signed-off-by Fabio Estevam <[email protected]>
---
 arch/arm/configs/mxs_defconfig |   19 ++++++++++++++++---
 1 files changed, 16 insertions(+), 3 deletions(-)

The changes are not sufficient for audio to work.
CONFIG_REGULATOR_FIXED_VOLTAGE is needed too.

Signature · 2 lines
Regards,
Shawn
#3 lore raw

PATCH v2 1/1 ARM: mx28: Let audio support be built by default

In reply to Fabio Estevam

Let audio support be built by default.

As sgtl5000 codec is connected via I2C, let MXS I2C driver also be built by default.

Signed-off-by Fabio Estevam <[email protected]>

---
Changes since v1:
- Add regulator config options

 arch/arm/configs/mxs_defconfig |   20 +++++++++++++++++---
 1 files changed, 17 insertions(+), 3 deletions(-)
arch/arm/configs/mxs_defconfig +17 -3
index 6ee781b..1ebbf45 100644
@@ -77,10 +77,10 @@ CONFIG_DEVPTS_MULTIPLE_INSTANCES=y
 CONFIG_SERIAL_AMBA_PL011=y
 CONFIG_SERIAL_AMBA_PL011_CONSOLE=y
 # CONFIG_HW_RANDOM is not set
-CONFIG_I2C=m
+CONFIG_I2C=y
 # CONFIG_I2C_COMPAT is not set
-CONFIG_I2C_CHARDEV=m
-CONFIG_I2C_MXS=m
+CONFIG_I2C_CHARDEV=y
+CONFIG_I2C_MXS=y
 CONFIG_SPI=y
 CONFIG_SPI_GPIO=m
 CONFIG_DEBUG_GPIO=y

@@ -90,6 +90,20 @@ CONFIG_GPIO_SYSFS=y
 CONFIG_DISPLAY_SUPPORT=m
 # CONFIG_HID_SUPPORT is not set
 # CONFIG_USB_SUPPORT is not set
+CONFIG_SOUND=y
+CONFIG_SND=y
+CONFIG_SND_TIMER=y
+CONFIG_SND_PCM=y
+CONFIG_SND_JACK=y
+CONFIG_SND_DRIVERS=y
+CONFIG_SND_ARM=y
+CONFIG_SND_SOC=y
+CONFIG_SND_MXS_SOC=y
+CONFIG_SND_SOC_MXS_SGTL5000=y
+CONFIG_SND_SOC_I2C_AND_SPI=y
+CONFIG_SND_SOC_SGTL5000=y
+CONFIG_REGULATOR=y
+CONFIG_REGULATOR_FIXED_VOLTAGE=y
 CONFIG_MMC=y
 CONFIG_MMC_MXS=y
 CONFIG_RTC_CLASS=y
Signature · 1 line
1.7.1
#4 lore raw

PATCH v2 1/1 ARM: mx28: Let audio support be built by default

Quoted 42 lines

Let audio support be built by default.

As sgtl5000 codec is connected via I2C, let MXS I2C driver also be built by default.

Signed-off-by Fabio Estevam <[email protected]>

---
Changes since v1:
- Add regulator config options

 arch/arm/configs/mxs_defconfig |   20 +++++++++++++++++---
 1 files changed, 17 insertions(+), 3 deletions(-)
(quoted diff) +0 -0

b/arch/arm/configs/mxs_defconfig index 6ee781b..1ebbf45 100644

arch/arm/configs/mxs_defconfig +10 -3
@@ -77,10 +77,10 @@ CONFIG_DEVPTS_MULTIPLE_INSTANCES=y
 CONFIG_SERIAL_AMBA_PL011=y
 CONFIG_SERIAL_AMBA_PL011_CONSOLE=y
 # CONFIG_HW_RANDOM is not set
-CONFIG_I2C=m
+CONFIG_I2C=y
 # CONFIG_I2C_COMPAT is not set
-CONFIG_I2C_CHARDEV=m
-CONFIG_I2C_MXS=m
+CONFIG_I2C_CHARDEV=y
+CONFIG_I2C_MXS=y
 CONFIG_SPI=y
 CONFIG_SPI_GPIO=m
 CONFIG_DEBUG_GPIO=y

@@ -90,6 +90,20 @@ CONFIG_GPIO_SYSFS=y
 CONFIG_DISPLAY_SUPPORT=m
 # CONFIG_HID_SUPPORT is not set
 # CONFIG_USB_SUPPORT is not set
+CONFIG_SOUND=y
+CONFIG_SND=y
+CONFIG_SND_TIMER=y
+CONFIG_SND_PCM=y
+CONFIG_SND_JACK=y
+CONFIG_SND_DRIVERS=y
+CONFIG_SND_ARM=y

arch/arm/configs/mxs_defconfig CONFIG_GPIO_SYSFS=y · line 109

Quoted 10 lines
arch/arm/configs/mxs_defconfig +7 -0
+CONFIG_SND_SOC=y
+CONFIG_SND_MXS_SOC=y
+CONFIG_SND_SOC_MXS_SGTL5000=y
+CONFIG_SND_SOC_I2C_AND_SPI=y
+CONFIG_SND_SOC_SGTL5000=y
+CONFIG_REGULATOR=y
+CONFIG_REGULATOR_FIXED_VOLTAGE=y
 CONFIG_MMC=y
 CONFIG_MMC_MXS=y
 CONFIG_RTC_CLASS=y
Acked-by Marek Vasut <[email protected]>
author reviewer
#5 lore raw

PATCH v2 1/1 ARM: mx28: Let audio support be built by default

In reply to Fabio Estevam

Hi Shawn,

Quoted 9 lines · Fabio Estevam

Let audio support be built by default.

As sgtl5000 codec is connected via I2C, let MXS I2C driver also be built by default.

Signed-off-by Fabio Estevam <[email protected]>

---
Changes since v1:
- Add regulator config options

Is this good now?

Regards,

Fabio Estevam

#6 lore raw

PATCH v2 1/1 ARM: mx28: Let audio support be built by default

Quoted 8 lines · Fabio Estevam

Hi Shawn,

Quoted 5 lines · Fabio Estevam

Let audio support be built by default.

As sgtl5000 codec is connected via I2C, let MXS I2C driver also be built by default.

Quoted 7 lines
Quoted 4 lines
Signed-off-by Fabio Estevam <[email protected]>

---
Changes since v1:
- Add regulator config options

Is this good now?

Yes. Applied, thanks.

Signature · 2 lines
Regards,
Shawn