Document strdup allocation in snd_card_get_name family
PATCH 1/1 Document strdup allocation in snd_card_get_name family
This was spotted by Jörg Höhle on the wine-patches ML.
---
I noticed my documentation patches haven't been making their way into alsa-lib.git. Am I submitting these wrong? I added the SOB line above, although I notice not all patches that get into ALSA have it. On the other hand, alsa-lib.git hasn't been changed since November so perhaps my patches are sitting in someone's tree waiting to be pushed :)
Please let me know if I can help get these in.
src/control/cards.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-)
src/control/cards.c +6 -0
@@ -166,6 +166,9 @@ int snd_card_get_index(const char *string)* \param card Card number * \param name Result - card name corresponding to card number * \result zero if success, otherwise a negative error code +* +* The value returned in name is allocated with strdup and should be +* freed when no longer used. */ int snd_card_get_name (int card,char **name) {
@@ -193,6 +196,9 @@ int snd_card_get_name(int card, char **name)* \param card Card number * \param name Result - card long name corresponding to card number * \result zero if success, otherwise a negative error code +* +* The value returned in name is allocated with strdup and should be +* freed when no longer used. */ int snd_card_get_longname (int card,char **name) {
At Wed, 18 Jan 2012 08:58:08 -0600,
Quoted 11 lines · Andrew Eikum
This was spotted by Jörg Höhle on the wine-patches ML.
Signed-off-by Andrew Eikum <[email protected]>---
I noticed my documentation patches haven't been making their way into alsa-lib.git. Am I submitting these wrong? I added the SOB line above, although I notice not all patches that get into ALSA have it. On the other hand, alsa-lib.git hasn't been changed since November so perhaps my patches are sitting in someone's tree waiting to be pushed :)
Sorry, I simply overlooked your patches since they have been posted during my vacation. Now all patches are committed and pushed out.
Quoted 1 line
Please let me know if I can help get these in.
Please add maintainers to Cc. Also, at the next time, try to create patches directly applicable via git-am. I had to apply and fix them manually.
thanks,
Takashi
_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Quoted 8 lines · Takashi Iwai
At Wed, 18 Jan 2012 08:58:08 -0600,
Quoted 6 lines · Andrew Eikum
This was spotted by Jörg Höhle on the wine-patches ML.
Signed-off-by Andrew Eikum <[email protected]>---
Quoted 9 lines
Quoted 5 lines
I noticed my documentation patches haven't been making their way into alsa-lib.git. Am I submitting these wrong? I added the SOB line above, although I notice not all patches that get into ALSA have it. On the other hand, alsa-lib.git hasn't been changed since November so perhaps my patches are sitting in someone's tree waiting to be pushed :)
Sorry, I simply overlooked your patches since they have been posted during my vacation. Now all patches are committed and pushed out.
Great, thank you!
Quoted 6 lines
Quoted 1 line
Please let me know if I can help get these in.
Please add maintainers to Cc. Also, at the next time, try to create patches directly applicable via git-am. I had to apply and fix them manually.
Hm, that's strange. I use format-patch to generate the mail files which I then send out with mutt, and they work fine on my end. I pulled the mail file for the strdup patch as delivered by alsa-devel off our mail server and imported it with git-am without any issue at all. What do the mail files look like when they reach you?
Here's the mail as it arrived in my Maildir, which imports fine with git-am 1.7.8.3:
<http://pastebin.com/C4R08Xj3>
Andrew
_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
At Thu, 19 Jan 2012 08:48:45 -0600,
Quoted 35 lines · Andrew Eikum
Quoted 8 lines · Takashi Iwai
At Wed, 18 Jan 2012 08:58:08 -0600,
Quoted 6 lines · Andrew Eikum
This was spotted by Jörg Höhle on the wine-patches ML.
Signed-off-by Andrew Eikum <[email protected]>---
Quoted 9 lines
Quoted 5 lines
I noticed my documentation patches haven't been making their way into alsa-lib.git. Am I submitting these wrong? I added the SOB line above, although I notice not all patches that get into ALSA have it. On the other hand, alsa-lib.git hasn't been changed since November so perhaps my patches are sitting in someone's tree waiting to be pushed :)
Sorry, I simply overlooked your patches since they have been posted during my vacation. Now all patches are committed and pushed out.
Great, thank you!
Quoted 6 lines
Quoted 1 line
Please let me know if I can help get these in.
Please add maintainers to Cc. Also, at the next time, try to create patches directly applicable via git-am. I had to apply and fix them manually.
Hm, that's strange. I use format-patch to generate the mail files which I then send out with mutt, and they work fine on my end. I pulled the mail file for the strdup patch as delivered by alsa-devel off our mail server and imported it with git-am without any issue at all. What do the mail files look like when they reach you?
Quoted 3 lines
Here's the mail as it arrived in my Maildir, which imports fine with git-am 1.7.8.3:
<http://pastebin.com/C4R08Xj3>
Did you really create it via git-format-patch? It won't create any attachment usually but the patch must be embedded.
If it's not manageable, try git-send-email instead.
Takashi
_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel