cifs: fetch credentials out of keyring for non-krb5 auth multiuser mounts

DISCUSSION Dan Carpenter 2 participants 2 messages Jan 20, 2012 1 message not in the archive

Subsystems (2)

SMB client (CIFS) Kernel SMB3 server (ksmbd)

lore

Share & tools

lore

Dan Carpenter

author

2012-01-20 08:21 UTC #0 lore raw

Hi Jeff,

The patch 8a8798a5ff90: "cifs: fetch credentials out of keyring for non-krb5 auth multiuser mounts" from Jan 17, 2012, has a problem here:

+ upayload = key->payload.data;
+ if (IS_ERR_OR_NULL(upayload)) {

+               rc = PTR_ERR(key);
                             ^^^

"key" is a valid pointer not an ERR_PTR. Also "upayload" can be NULL and PTR_ERR(NULL) is success.

+ goto out_key_put;
+ }

regards,
dan carpenter

A message that is not in the archive (sent off-list or not yet received): [email protected]

Jeff Layton

2012-01-20 12:23 UTC #2 lore raw

Quoted 15 lines · On Fri, 20 Jan 2012 11:21:32 +0300 Dan Carpenter…

Hi Jeff,
The patch 8a8798a5ff90: "cifs: fetch credentials out of keyring for non-krb5 auth multiuser mounts" from Jan 17, 2012, has a problem here:
(quoted diff) +3 -0
+       upayload = key->payload.data;
+       if (IS_ERR_OR_NULL(upayload)) {
+               rc = PTR_ERR(key);
                             ^^^
"key" is a valid pointer not an ERR_PTR. Also "upayload" can be NULL and PTR_ERR(NULL) is success.
(quoted diff) +2 -0
+               goto out_key_put;
+       }

Quoted 3 lines

regards,
dan carpenter

Doh! Good catch. Steve has already queued this patch for inclusion, but I'll spin up a patch to fix it.

Thanks,

Signature · 1 line

Jeff Layton <[email protected]>