Skip to contentSkip to conversation

S3C24XX DMA resume regression fix

PATCH Superseded Gusakov Andrey 4 participants 5 messages Jan 13, 2012 – Jan 20, 2012

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm Samsung Exynos

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Gusakov Andrey

author
#0 lore raw

PATCH 1/1 S3C24XX DMA resume regression fix

In commit bb072c3cf21d1c9a5a2eeb5a00679ee7bf39675b suspend/resume hooks were added. s3c2410_dma_suspend suspends channels from 0 to dma_channels. s3c2410_dma_resume resumes channels in reverse order. So pointer should be decremented insted of being incremented.

Signed-off-by Gusakov Andrey <[email protected]>
---
 arch/arm/plat-s3c24xx/dma.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/plat-s3c24xx/dma.c +1 -1
index 57abec9..16510d5 100644
@@ -1249,7 +1249,7 @@ static void s3c2410_dma_resume(void)
 	struct s3c2410_dma_chan *cp = s3c2410_chans + dma_channels - 1;
 	int channel;
 
-	for (channel = dma_channels - 1; channel >= 0; cp++, channel--)
+	for (channel = dma_channels - 1; channel >= 0; cp--, channel--)
 		s3c2410_dma_resume_chan(cp);
 }
Signature · 1 line
1.7.0.4
#1 lore raw

PATCH 1/1 S3C24XX DMA resume regression fix

Hello.

Quoted 1 line · Gusakov Andrey

In commit bb072c3cf21d1c9a5a2eeb5a00679ee7bf39675b suspend/resume

Please also specify that commit's summary in parens.

Quoted 5 lines

hooks were added. s3c2410_dma_suspend suspends channels from 0 to dma_channels. s3c2410_dma_resume resumes channels in reverse order. So pointer should be decremented insted of being incremented.

Signed-off-by Gusakov Andrey<[email protected]>

WBR, Sergei

#2 lore raw

PATCH 1/1 S3C24XX DMA resume regression fix

Quoted 7 lines · Sergei Shtylyov

Hello.

Quoted 1 line · Gusakov Andrey

In commit bb072c3cf21d1c9a5a2eeb5a00679ee7bf39675b suspend/resume

Please also specify that commit's summary in parens.

Could you please point me in direction of patch submission guide where that is explained.

The commit message summary is
ARM / Samsung: Use struct syscore_ops for "core" power management

But that is not revert of that commit, so I don't really see a point. This is bug fix which fixes resume code path.

Thanks a lot,
S.

#3 lore raw

PATCH 1/1 S3C24XX DMA resume regression fix

Quoted 11 lines · Sergey Lapin
Quoted 7 lines · Sergei Shtylyov

Hello.

Quoted 1 line · Gusakov Andrey

In commit bb072c3cf21d1c9a5a2eeb5a00679ee7bf39675b suspend/resume

Please also specify that commit's summary in parens.

Could you please point me in direction of patch submission guide where that is explained.

It's something that's been asked for by Linus - and as Linus can refuse to pull anything he doesn't like, it's something that we'd better satisfy if we want patches to hit mainline.

Like everything in kernel development, what's written in documentation is never the full story; things change through discussions on mailing lists, new guidelines get created, and the documents become stale. That's the nature of this.

Anyone is free to update the documentation, so if you think it's got a shortcoming, please feel free to send a documentation patch.

Quoted 5 lines

The commit message summary is
ARM / Samsung: Use struct syscore_ops for "core" power management

But that is not revert of that commit, so I don't really see a point. This is bug fix which fixes resume code path.

The point is that if you include a commit ID, then you should include the summary, so people reading the commit message don't have to faff around trying to find out what you're referring to.

See, for example, http://lkml.org/lkml/2010/6/1/498

#4 lore raw

PATCH 1/1 S3C24XX DMA resume regression fix

Quoted 15 lines
Quoted 6 lines
Quoted 3 lines
Quoted 1 line

In commit bb072c3cf21d1c9a5a2eeb5a00679ee7bf39675b suspend/resume

Please also specify that commit's summary in parens.

Could you please point me in direction of patch submission guide where that is explained.

It's something that's been asked for by Linus - and as Linus can refuse to pull anything he doesn't like, it's something that we'd better satisfy if we want patches to hit mainline.

Like everything in kernel development, what's written in documentation is never the full story; things change through discussions on mailing lists, new guidelines get created, and the documents become stale. That's the nature of this.

...

Quoted 5 lines

The point is that if you include a commit ID, then you should include the summary, so people reading the commit message don't have to faff around trying to find out what you're referring to.

See, for example, http://lkml.org/lkml/2010/6/1/498

Thanks a lot for good explanation,

S.