Ext3 & ext2 fix, quota improvement
Hello Linus,
could you please pull from
git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git for_linus
The most important is an ext3 fix of corruption after power failure. The other two patches are just minor things...
Top of the tree is 46fe44c. The full shortlog is:
Djalal Harouni (1):
ext2: protect inode changes in the SETVERSION and SETFLAGS ioctls
Jan Kara (2):
jbd: Issue cache flush after checkpointing
quota: Pass information that quota is stored in system file to userspace
The diffstat is
fs/ext2/ioctl.c | 22 ++++++++++++++++------ fs/jbd/checkpoint.c | 27 ++++++++++++++++++++++----- fs/jbd/recovery.c | 4 ++++ fs/quota/dquot.c | 8 +++++--- include/linux/quota.h | 6 +++++- 5 files changed, 52 insertions(+), 15 deletions(-)
Thanks
Honza
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR
Quoted 1 line · Jan Kara
quota: Pass information that quota is stored in system file to userspace
Was that patch posted somewhere? How does it apply to e.g. xfs, gfs2 and ocfs2 that have always stored quota data internally?
Quoted 5 lines · Christoph Hellwig
Quoted 1 line · Jan Kara
quota: Pass information that quota is stored in system file to userspace
Was that patch posted somewhere? How does it apply to e.g. xfs, gfs2 and ocfs2 that have always stored quota data internally?
It was posted back in November (but I forgot it in a topic branch thus
I'm merging it only now), looking at the post I sent it to linux-ext4 only which was probably a bit unlucky.
Regarding other filesystems - ocfs2 and gfs2 set DQUOT_QUOTA_SYS_FILE flag so this will now be passed properly to userspace to inform userspace programs (but quota-tools anyway use the flag only for ext4, for other filesystems they know quota is handled internally just by looking at filesystem type). XFS doesn't set the flag. It does not matter in practice as XFS doesn't use VFS quota code which cares about the flag (dquot_quota_sync, dquot_disable) and userspace tools know XFS handles quota internally. But maybe we could make XFS set it just for consistency?
Honza
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR
Hello,
Quoted 9 lines · Jan Kara
Hello Linus,
could you please pull from
git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.gitfor_linusThe most important is an ext3 fix of corruption after power failure. The other two patches are just minor things...
Quoted 8 lines
Top of the tree is 46fe44c. The full shortlog is:
Djalal Harouni (1):
ext2: protect inode changes in the SETVERSION and SETFLAGS ioctlsJan Kara (2):
jbd: Issue cache flush after checkpointing
quota: Pass information that quota is stored in system file to userspace
Did you just forget to pull or do you disagree with some of the changes?
Honza
Quoted 20 lines
The diffstat is
fs/ext2/ioctl.c | 22 ++++++++++++++++------ fs/jbd/checkpoint.c | 27 ++++++++++++++++++++++----- fs/jbd/recovery.c | 4 ++++ fs/quota/dquot.c | 8 +++++--- include/linux/quota.h | 6 +++++- 5 files changed, 52 insertions(+), 15 deletions(-)Thanks
HonzaSignature · 7 lines
Jan Kara <[email protected]> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR
Quoted 4 lines · Jan Kara
Quoted 3 lines
Jan Kara (2):
jbd: Issue cache flush after checkpointing
quota: Pass information that quota is stored in system file to userspaceDid you just forget to pull or do you disagree with some of the changes?
FYI, I'll take my complaint back. While waiting multiple month between review and pull isn't nice it's probably fine by the protocol, and the actual change looks fine.