Skip to contentSkip to conversation

libevas: Add new package.

PATCH New Will Newton 2 participants 2 messages Jan 18, 2012 – Jan 21, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 3/7 libevas: Add new package.

---
 package/efl/Config.in          |    1 +
 package/efl/libevas/Config.in  |  199 ++++++++++++++++++++++++++++++++++++++++
 package/efl/libevas/libevas.mk |  165 +++++++++++++++++++++++++++++++++
 3 files changed, 365 insertions(+), 0 deletions(-)
 create mode 100644 package/efl/libevas/Config.in
 create mode 100644 package/efl/libevas/libevas.mk
package/efl/Config.in +1 -0
index 8ca514d..27d1f95 100644
@@ -10,6 +10,7 @@ if BR2_PACKAGE_EFL
 
 source "package/efl/libeina/Config.in"
 source "package/efl/libeet/Config.in"
+source "package/efl/libevas/Config.in"
 
 endif # BR2_PACKAGE_EFL
 
package/efl/libevas/Config.in new file +199 -0

199 lines not on this page · raw message

package/efl/libevas/libevas.mk new file +165 -0

165 lines not on this page · raw message

Signature · 2 lines
1.7.1
-------------- next part --------------
#1 lore raw

PATCH 3/7 libevas: Add new package.

Quoted 1 line · On Wednesday 18 January 2012 12:15:31 Will Newton wrote:

[snip]

package/efl/libevas/Config.in line 98

Quoted 2 lines
package/efl/libevas/Config.in new file +2 -0
+config BR2_PACKAGE_LIBEVAS_SDL
+	bool "libevas sdl backend"

I would expect a select BR2_PACKAGE_SDL here.

Quoted 4 lines
package/efl/libevas/Config.in new file +4 -0
+	help
+	  This is the sdl engine that uses sdl library
+	  (http://www.libsdl.org). This library should work on many
+	  operating system.

[snip]

Quoted 1 line

+comment "libevas code tunning"

tuning, not tunning

I would expect the following to be a choice rather than a set of bools.
Or can you sensibly compile libevas with no code?

package/efl/libevas/Config.in line 122

Quoted 3 lines
package/efl/libevas/Config.in new file +3 -0
+
+config BR2_PACKAGE_LIBEVAS_C
+	bool "libevas c code"

This probably needs a 'default y'.

package/efl/libevas/Config.in line 130

Quoted 8 lines
package/efl/libevas/Config.in new file +8 -0
+	help
+	  This enabled the c code. you can actually build the code
+	  without the c fallback code and only have the mmx routines
+	  for example.
+
+config BR2_PACKAGE_LIBEVAS_MMX
+	bool "libevas mmx routines"
+	depends on BR2_i386 || BR2_x86_64

These dependencies could be a bit more accurate. You can find in 'man gcc'
which architectures support MMX. I guess something like this should work:
depends on (BR2_i386 && !BR2_x86_i386 && !BR2_x86_i486 && !BR2_x86_i586 && !BR2_x86_i686 && !BR2_x86_pentiumpro) || BR2_x86_64

package/efl/libevas/Config.in line 138

Quoted 8 lines
package/efl/libevas/Config.in new file +8 -0
+	help
+	  This enables the mmx optimised routines. this works for
+	  pentium, pentium2, pentium3, pentium4, athlon and duron
+	  processors.
+
+config BR2_PACKAGE_LIBEVAS_SSE
+	bool "libevas sse routines"
+	depends on BR2_i386 || BR2_x86_64

Same remark, but here you should find out of it is SSE, SSE2, SSE3, or
SSSE3 is required.

Quoted 4 lines
package/efl/libevas/Config.in new file +4 -0
+	help
+	  This enables sse optimizations availbale in he pentium3 and
+	  4 cpus (not athlon and duron or pentium 2 or pentium cpu's).
+

[snip]

Quoted 7 lines
package/efl/libevas/libevas.mk new file +1 -0
new file mode 100644
index 0000000..7bea475
@@ -0,0 +1,165 @@
+#############################################################

package/efl/libevas/libevas.mk line 11

Quoted 10 lines
package/efl/libevas/libevas.mk new file +10 -0
+#
+# libevas
+#
+#############################################################
+
+LIBEVAS_VERSION = 1.1.0
+LIBEVAS_SOURCE = evas-$(LIBEVAS_VERSION).tar.bz2
+LIBEVAS_SITE = http://download.enlightenment.org/releases/
+LIBEVAS_INSTALL_STAGING = YES
+LIBEVAS_INSTALL_TARGET = YES

_INSTALL_TARGET already defaults to YES.

package/efl/libevas/libevas.mk line 15

Quoted 3 lines
package/efl/libevas/libevas.mk new file +3 -0
+LIBEVAS_DEPENDENCIES = host-pkg-config zlib libeina freetype
+
+LIBEVAS_CONF_OPT =

_CONF_OPT defaults to empty. It's OK to immediately assign using +=.

[snip]

package/efl/libevas/libevas.mk line 70

Quoted 4 lines
package/efl/libevas/libevas.mk new file +4 -0
+ifeq ($(BR2_PACKAGE_LIBEVAS_GL_X11),y)
+
+LIBEVAS_CONF_OPT += --enable-gl-x11
+LIBEVAS_DEPENDENCIES += xserver_xorg-server

This doesn't correspond to the dependency in Config.in.

[snip]

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F