mx28: Show CPU frequency

PATCH New Fabio Estevam 3 participants 6 messages Jan 23, 2012 – Jan 24, 2012 Arm (32-bit)

lore

Share & tools

lore

Fabio Estevam

author

2012-01-23 02:38 UTC #0 lore raw

PATCH 1/1 mx28: Show CPU frequency

Showing CPU frequency during boot is useful information.

Signed-off-by Fabio Estevam <[email protected]>

---
 arch/arm/cpu/arm926ejs/mx28/mx28.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

arch/arm/cpu/arm926ejs/mx28/mx28.c +2 -1

index da90360..683777f 100644
@@ -169,7 +169,8 @@ int arch_cpu_init(void)
 #if defined(CONFIG_DISPLAY_CPUINFO)
 int print_cpuinfo(void)
 {
-	printf("Freescale i.MX28 family\n");
+	printf("Freescale i.MX28 family at %d MHz\n",
+			mxc_get_clock(MXC_ARM_CLK) / 1000000);
 	return 0;
 }
 #endif

Signature · 1 line

1.7.1

Marek Vasut

2012-01-23 04:21 UTC #1 lore raw

PATCH 1/1 mx28: Show CPU frequency

Quoted 12 lines

Showing CPU frequency during boot is useful information.
Signed-off-by Fabio Estevam <[email protected]>
---
 arch/arm/cpu/arm926ejs/mx28/mx28.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
(quoted diff) +0 -0
b/arch/arm/cpu/arm926ejs/mx28/mx28.c index da90360..683777f 100644

arch/arm/cpu/arm926ejs/mx28/mx28.c int arch_cpu_init(void) · line 176

Quoted 9 lines

arch/arm/cpu/arm926ejs/mx28/mx28.c +2 -1

@@ -169,7 +169,8 @@ int arch_cpu_init(void)
 #if defined(CONFIG_DISPLAY_CPUINFO)
 int print_cpuinfo(void)
 {
-	printf("Freescale i.MX28 family\n");
+	printf("Freescale i.MX28 family at %d MHz\n",
+			mxc_get_clock(MXC_ARM_CLK) / 1000000);
 	return 0;
 }
 #endif

Just put it amongst the other frequencies displayed by the clock command.

Fabio Estevam

author

2012-01-23 15:52 UTC #2 lore raw

PATCH 1/1 mx28: Show CPU frequency

Quoted 1 line · Marek Vasut

Just put it amongst the other frequencies displayed by the clock command.

What about this?

arch/arm/cpu/arm926ejs/mx28/mx28.c +1 -0

@@ -170,6 +170,7 @@ int arch_cpu_init(void)
 int print_cpuinfo(void)
 {
        printf("Freescale i.MX28 family\n");
+       do_mx28_showclocks();
        return 0;
 }
 #endif

It will print a lot more info though.

Regards,

Fabio Estevam

Stefano Babic

2012-01-23 16:02 UTC #3 lore raw

PATCH 1/1 mx28: Show CPU frequency

Quoted 17 lines · Fabio Estevam

Quoted 1 line · Marek Vasut
Just put it amongst the other frequencies displayed by the clock command.
What about this?
arch/arm/cpu/arm926ejs/mx28/mx28.c +1 -0
@@ -170,6 +170,7 @@ int arch_cpu_init(void)
 int print_cpuinfo(void)
 {
        printf("Freescale i.MX28 family\n");
+       do_mx28_showclocks();
        return 0;
 }
 #endif

Quoted 1 line

It will print a lot more info though.

Well, this is the reason we have a separate function / command (clocks) that can be called only when needed. Generally, we avoid to print too much information if they are not required and can slow down the boot process.

In print_cpuinfo() we output the processor type, the revision if it is available and maybe the processor frequency - nothing more. And if we need a complete overview of the clocks, there is the "clocks" command.

So really I prefer the patch as it is - the information printed are the same as for other SOCs, not only i.MX.

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

Marek Vasut

2012-01-23 16:52 UTC #4 lore raw

PATCH 1/1 mx28: Show CPU frequency

Quoted 34 lines · Fabio Estevam

Quoted 17 lines · Marek Vasut
Quoted 2 lines
Just put it amongst the other frequencies displayed by the clock command.
What about this?
arch/arm/cpu/arm926ejs/mx28/mx28.c +1 -0
@@ -170,6 +170,7 @@ int arch_cpu_init(void)
 
 int print_cpuinfo(void)
 {
 
        printf("Freescale i.MX28 family\n");
 
+       do_mx28_showclocks();
Quoted 6 lines
        return 0;
}
#endif
It will print a lot more info though.
Well, this is the reason we have a separate function / command (clocks) that can be called only when needed. Generally, we avoid to print too much information if they are not required and can slow down the boot process.
In print_cpuinfo() we output the processor type, the revision if it is available and maybe the processor frequency - nothing more. And if we need a complete overview of the clocks, there is the "clocks" command.

Quoted 5 lines

So really I prefer the patch as it is - the information printed are the same as for other SOCs, not only i.MX.
Best regards,
Stefano Babic

Ok, fine by me then.

Acked-by Marek Vasut <[email protected]>

Stefano Babic

2012-01-24 08:36 UTC #5 lore raw

PATCH 1/1 mx28: Show CPU frequency

In reply to Fabio Estevam

Quoted 12 lines · Fabio Estevam

Showing CPU frequency during boot is useful information.
Signed-off-by Fabio Estevam <[email protected]>
---
 arch/arm/cpu/arm926ejs/mx28/mx28.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
arch/arm/cpu/arm926ejs/mx28/mx28.c +0 -0
index da90360..683777f 100644

arch/arm/cpu/arm926ejs/mx28/mx28.c int arch_cpu_init(void) · line 176

Quoted 9 lines

arch/arm/cpu/arm926ejs/mx28/mx28.c +2 -1

@@ -169,7 +169,8 @@ int arch_cpu_init(void)
 #if defined(CONFIG_DISPLAY_CPUINFO)
 int print_cpuinfo(void)
 {
-	printf("Freescale i.MX28 family\n");
+	printf("Freescale i.MX28 family at %d MHz\n",
+			mxc_get_clock(MXC_ARM_CLK) / 1000000);
 	return 0;
 }
 #endif

Applied to u-boot-imx, thanks.

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================