Skip to contentSkip to conversation

TRATS: Fix uart gpio config

PATCH New Chander Kashyap 3 participants 3 messages Jan 25, 2012 – Jan 26, 2012

lore
Share & tools
lore

Chander Kashyap

author
#0 lore raw

PATCH 1/1 TRATS: Fix uart gpio config

It updates the missing gpio configuration of UART port.

Signed-off-by Chander Kashyap <[email protected]>
Cc HeungJun, Kim <[email protected]>
---
 board/samsung/trats/trats.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
board/samsung/trats/trats.c +2 -2
index f795ff0..4c9773d 100644
@@ -337,7 +337,7 @@ static void board_uart_init(void)
 	int i;
 
 	/* UART0-UART1 GPIOs (part1) : 0x22222222 */
-	for (i = 0; i < 7; i++) {
+	for (i = 0; i < 8; i++) {
 		s5p_gpio_set_pull(&gpio1->a0, i, GPIO_PULL_NONE);
 		s5p_gpio_cfg_pin(&gpio1->a0, i, GPIO_FUNC(0x2));
 	}

@@ -347,7 +347,7 @@ static void board_uart_init(void)
 	 * GPA1CON[3] = I2C_3_SCL (3)
 	 * GPA1CON[2] = I2C_3_SDA (3)
 	 */
-	for (i = 0; i < 5; i++) {
+	for (i = 0; i < 6; i++) {
 		s5p_gpio_set_pull(&gpio1->a1, i, GPIO_PULL_NONE);
 		s5p_gpio_cfg_pin(&gpio1->a1, i,
 				GPIO_FUNC((i == 2 || i == 3) ? 0x3 : 0x2));
Signature · 1 line
1.7.5.4
#1 lore raw

PATCH 1/1 TRATS: Fix uart gpio config

Quoted 22 lines

It updates the missing gpio configuration of UART port.

Signed-off-by Chander Kashyap <[email protected]>
Cc HeungJun, Kim <[email protected]>
---
 board/samsung/trats/trats.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
board/samsung/trats/trats.c +1 -1
index f795ff0..4c9773d 100644
@@ -337,7 +337,7 @@ static void board_uart_init(void)
 	int i;
 
 	/* UART0-UART1 GPIOs (part1) : 0x22222222 */
-	for (i = 0; i < 7; i++) {
+	for (i = 0; i < 8; i++) {
 		s5p_gpio_set_pull(&gpio1->a0, i, GPIO_PULL_NONE);
 		s5p_gpio_cfg_pin(&gpio1->a0, i, GPIO_FUNC(0x2));
 	}

board/samsung/trats/trats.c static void board_uart_init(void) · line 353

Quoted 8 lines
board/samsung/trats/trats.c +1 -1
@@ -347,7 +347,7 @@ static void board_uart_init(void)
 	 * GPA1CON[3] = I2C_3_SCL (3)
 	 * GPA1CON[2] = I2C_3_SDA (3)
 	 */
-	for (i = 0; i < 5; i++) {
+	for (i = 0; i < 6; i++) {
 		s5p_gpio_set_pull(&gpio1->a1, i, GPIO_PULL_NONE);
 		s5p_gpio_cfg_pin(&gpio1->a1, i,
 				GPIO_FUNC((i == 2 || i == 3) ? 0x3 : 0x2));
Acked-by Marek Vasut <[email protected]>
#2 lore raw

PATCH 1/1 TRATS: Fix uart gpio config

In reply to Chander Kashyap

Dear Chander Kashyap,

Quoted 24 lines · Chander Kashyap

It updates the missing gpio configuration of UART port.

Signed-off-by Chander Kashyap <[email protected]>
Cc HeungJun, Kim <[email protected]>

---
?board/samsung/trats/trats.c | ? ?4 ++--
?1 files changed, 2 insertions(+), 2 deletions(-)

board/samsung/trats/trats.c +0 -0
index f795ff0..4c9773d 100644
@@ -337,7 +337,7 @@ static void board_uart_init(void)
 ? ? ? ?int i;

? ? ? ?/* UART0-UART1 GPIOs (part1) : 0x22222222 */
- ? ? ? for (i = 0; i < 7; i++) {
+ ? ? ? for (i = 0; i < 8; i++) {
? ? ? ? ? ? ? ?s5p_gpio_set_pull(&gpio1->a0, i, GPIO_PULL_NONE); ? ? ? ? ? ? ? ?s5p_gpio_cfg_pin(&gpio1->a0, i, GPIO_FUNC(0x2)); ? ? ? ?}

board/samsung/trats/trats.c +0 -0
@@ -347,7 +347,7 @@ static void board_uart_init(void)
 ? ? ? ? * GPA1CON[3] = I2C_3_SCL (3)
 ? ? ? ? * GPA1CON[2] = I2C_3_SDA (3)
Quoted 7 lines

? ? ? ? */
- ? ? ? for (i = 0; i < 5; i++) {
+ ? ? ? for (i = 0; i < 6; i++) {
? ? ? ? ? ? ? ?s5p_gpio_set_pull(&gpio1->a1, i, GPIO_PULL_NONE); ? ? ? ? ? ? ? ?s5p_gpio_cfg_pin(&gpio1->a1, i,
? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?GPIO_FUNC((i == 2 || i == 3) ? 0x3 : 0x2)); --

Actually we don't have to set all?of UARTs.
Because, we only use UART2 for serial.
I will post new patch for it.

Thanks
Minkyu Kang.

Signature · 2 lines
from. prom.
www.promsoft.net